more testing of the api. Changing the generator so that it is a constant to come...

[rails.git] / lib / osm.rb

diff --git a/lib/osm.rb b/lib/osm.rb
index a64aa8c4870afc4ee2331ef49769682f318467d3..e9d3c946468723af7ce34ad96eada774b864838c 100644 (file)
--- a/lib/osm.rb
+++ b/lib/osm.rb
@@ -33,6 +33,27 @@ module OSM
     end
   end
 
     end
   end
 

+  # Raised when the user logged in isn't the same as the changeset
+  class APIUserChangesetMismatchError < APIError
+    def render_opts
+      { :text => "The user doesn't own that changeset", :status => :conflict }
+    end
+  end
+
+  # Raised when the changeset provided is already closed
+  class APIChangesetAlreadyClosedError < APIError
+    def render_opts
+      { :text => "The supplied changeset has already been closed", :status => :conflict }
+    end
+  end
+  
+  # Raised when a change is expecting a changeset, but the changeset doesn't exist
+  class APIChangesetMissingError < APIError
+    def render_opts
+      { :text => "You need to supply a changeset to be able to make a change", :status => :conflict }
+    end
+  end
+

   # Raised when the provided version is not equal to the latest in the db.
   class APIVersionMismatchError < APIError
     def initialize(provided, latest)
   # Raised when the provided version is not equal to the latest in the db.
   class APIVersionMismatchError < APIError
     def initialize(provided, latest)


@@ -43,7 +64,22 @@ module OSM
 
     def render_opts
       { :text => "Version mismatch: Provided " + provided.to_s +
 
     def render_opts
       { :text => "Version mismatch: Provided " + provided.to_s +

-       ", server had: " + latest.to_s, :status => :bad_request }
+      ", server had: " + latest.to_s, :status => :conflict }
+    end
+  end
+
+  # raised when a two tags have a duplicate key string in an element.
+  # this is now forbidden by the API.
+  class APIDuplicateTagsError < APIError
+    def initialize(type, id, tag_key)
+      @type, @id, @tag_key = type, id, tag_key
+    end
+
+    attr_reader :type, :id, :tag_key
+
+    def render_opts
+      { :text => "Element #{@type}/#{@id} has duplicate tags with key #{@tag_key}.",
+        :status => :bad_request }

     end
   end
 
     end
   end
 


@@ -213,7 +249,7 @@ module OSM
       doc.encoding = 'UTF-8' 
       root = XML::Node.new 'osm'
       root['version'] = API_VERSION
       doc.encoding = 'UTF-8' 
       root = XML::Node.new 'osm'
       root['version'] = API_VERSION

-      root['generator'] = 'OpenStreetMap server'
+      root['generator'] = GENERATOR

       doc.root = root
       return doc
     end
       doc.root = root
       return doc
     end