Merge remote-tracking branch 'upstream/pull/3061'

[rails.git] / app / models / relation.rb

diff --git a/app/models/relation.rb b/app/models/relation.rb
index a73d63183b44ee2b31dd7348f9d4e44e5e956c28..5ed838e107ea270671c7551d440ad0e014be6aae 100644 (file)
--- a/app/models/relation.rb
+++ b/app/models/relation.rb
@@ -17,7 +17,7 @@
 #  current_relations_changeset_id_fkey  (changeset_id => changesets.id)
 #
 
 #  current_relations_changeset_id_fkey  (changeset_id => changesets.id)
 #
 

-class Relation < ActiveRecord::Base
+class Relation < ApplicationRecord

   require "xml/libxml"
 
   include ConsistencyValidations
   require "xml/libxml"
 
   include ConsistencyValidations


@@ -54,19 +54,21 @@ class Relation < ActiveRecord::Base
 
   TYPES = %w[node way relation].freeze
 
 
   TYPES = %w[node way relation].freeze
 

-  def self.from_xml(xml, create = false)
+  def self.from_xml(xml, create: false)

     p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
     doc = p.parse
     p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
     doc = p.parse

+    pt = doc.find_first("//osm/relation")

 
 

-    doc.find("//osm/relation").each do |pt|
-      return Relation.from_xml_node(pt, create)
+    if pt
+      Relation.from_xml_node(pt, :create => create)
+    else
+      raise OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/relation element.")

     end
     end

-    raise OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/relation element.")

   rescue LibXML::XML::Error, ArgumentError => e
     raise OSM::APIBadXMLError.new("relation", xml, e.message)
   end
 
   rescue LibXML::XML::Error, ArgumentError => e
     raise OSM::APIBadXMLError.new("relation", xml, e.message)
   end
 

-  def self.from_xml_node(pt, create = false)
+  def self.from_xml_node(pt, create: false)

     relation = Relation.new
 
     raise OSM::APIBadXMLError.new("relation", pt, "Version is required when updating") unless create || !pt["version"].nil?
     relation = Relation.new
 
     raise OSM::APIBadXMLError.new("relation", pt, "Version is required when updating") unless create || !pt["version"].nil?


@@ -132,9 +134,7 @@ class Relation < ActiveRecord::Base
     @tags ||= Hash[relation_tags.collect { |t| [t.k, t.v] }]
   end
 
     @tags ||= Hash[relation_tags.collect { |t| [t.k, t.v] }]
   end
 

-  attr_writer :members
-
-  attr_writer :tags
+  attr_writer :members, :tags

 
   def add_member(type, id, role)
     @members ||= []
 
   def add_member(type, id, role)
     @members ||= []