Merge remote-tracking branch 'upstream/pull/2505'

[rails.git] / test / integration / user_terms_seen_test.rb

diff --git a/test/integration/user_terms_seen_test.rb b/test/integration/user_terms_seen_test.rb
index a00ad39d57891b7a652f80a657c1a86273e53ac1..51eab5b18947ca0d0d53c635a8aa9a305b17d228 100644 (file)
--- a/test/integration/user_terms_seen_test.rb
+++ b/test/integration/user_terms_seen_test.rb
@@ -1,85 +1,69 @@
 require "test_helper"
 
 class UserTermsSeenTest < ActionDispatch::IntegrationTest
 require "test_helper"
 
 class UserTermsSeenTest < ActionDispatch::IntegrationTest

-  fixtures :users
-

   def test_api_blocked
   def test_api_blocked

-    with_terms_seen(true) do
-      user = users(:terms_not_seen_user)
+    user = create(:user, :terms_seen => false, :terms_agreed => nil)

 
 

-      get "/api/#{API_VERSION}/user/preferences", nil, auth_header(user.display_name, "test")
-      assert_response :forbidden
+    get "/api/#{Settings.api_version}/user/preferences", :headers => auth_header(user.display_name, "test")
+    assert_response :forbidden

 
 

-      # touch it so that the user has seen the terms
-      user.terms_seen = true
-      user.save
+    # touch it so that the user has seen the terms
+    user.terms_seen = true
+    user.save

 
 

-      get "/api/#{API_VERSION}/user/preferences", nil, auth_header(user.display_name, "test")
-      assert_response :success
-    end
+    get "/api/#{Settings.api_version}/user/preferences", :headers => auth_header(user.display_name, "test")
+    assert_response :success

   end
 
   def test_terms_presented_at_login
   end
 
   def test_terms_presented_at_login

-    with_terms_seen(true) do
-      user = users(:terms_not_seen_user)
-
-      # try to log in
-      get_via_redirect "/login"
-      assert_response :success
-      assert_template "user/login"
-      post "/login", "username" => user.email, "password" => "test", :referer => "/"
-      assert_response :redirect
-      # but now we need to look at the terms
-      assert_redirected_to "controller" => "user", "action" => "terms", :referer => "/"
-      follow_redirect!
-      assert_response :success
-
-      # don't agree to the terms, but hit decline
-      post "/user/save", "decline" => "decline", "referer" => "/"
-      assert_redirected_to "/"
-      follow_redirect!
-
-      # should be carried through to a normal login with a message
-      assert_response :success
-      assert !flash[:notice].nil?
-    end
+    user = create(:user, :terms_seen => false, :terms_agreed => nil)
+
+    # try to log in
+    get "/login"
+    follow_redirect!
+    assert_response :success
+    assert_template "users/login"
+    post "/login", :params => { :username => user.email, :password => "test", :referer => "/diary/new" }
+    assert_response :redirect
+    # but now we need to look at the terms
+    assert_redirected_to :controller => :users, :action => :terms, :referer => "/diary/new"
+    follow_redirect!
+    assert_response :success
+
+    # don't agree to the terms, but hit decline
+    post "/user/save", :params => { :decline => true, :referer => "/diary/new" }
+    assert_redirected_to "/diary/new"
+    follow_redirect!
+
+    # should be carried through to a normal login with a message
+    assert_response :success
+    assert_not flash[:notice].nil?

   end
 
   def test_terms_cant_be_circumvented
   end
 
   def test_terms_cant_be_circumvented

-    with_terms_seen(true) do
-      user = users(:terms_not_seen_user)
-
-      # try to log in
-      get_via_redirect "/login"
-      assert_response :success
-      assert_template "user/login"
-      post "/login", "username" => user.email, "password" => "test", :referer => "/"
-      assert_response :redirect
-      # but now we need to look at the terms
-      assert_redirected_to "controller" => "user", "action" => "terms", :referer => "/"
-      follow_redirect!
-      assert_response :success
-
-      # check that if we go somewhere else now, it redirects
-      # back to the terms page.
-      get "/traces/mine"
-      assert_redirected_to "controller" => "user", "action" => "terms", :referer => "/traces/mine"
-    end
+    user = create(:user, :terms_seen => false, :terms_agreed => nil)
+
+    # try to log in
+    get "/login"
+    follow_redirect!
+    assert_response :success
+    assert_template "users/login"
+    post "/login", :params => { :username => user.email, :password => "test", :referer => "/diary/new" }
+    assert_response :redirect
+    # but now we need to look at the terms
+    assert_redirected_to :controller => :users, :action => :terms, :referer => "/diary/new"
+
+    # check that if we go somewhere else now, it redirects
+    # back to the terms page.
+    get "/traces/mine"
+    assert_redirected_to :controller => :users, :action => :terms, :referer => "/traces/mine"
+    get "/traces/mine", :params => { :referer => "/diary/new" }
+    assert_redirected_to :controller => :users, :action => :terms, :referer => "/diary/new"

   end
 
   private
 
   def auth_header(user, pass)
   end
 
   private
 
   def auth_header(user, pass)

-    { "HTTP_AUTHORIZATION" => "Basic %s" % Base64.encode64("#{user}:#{pass}") }
-  end
-
-  def with_terms_seen(value)
-    require_terms_seen = Object.send("remove_const", "REQUIRE_TERMS_SEEN")
-    Object.const_set("REQUIRE_TERMS_SEEN", value)
-
-    yield
-
-    Object.send("remove_const", "REQUIRE_TERMS_SEEN")
-    Object.const_set("REQUIRE_TERMS_SEEN", require_terms_seen)
+    { "HTTP_AUTHORIZATION" => format("Basic %{auth}", :auth => Base64.encode64("#{user}:#{pass}")) }

   end
 end
   end
 end