##
# test the index action
def test_index
+ # The list of blocks should load
get :index
assert_response :success
assert_select "table#block_list", :count => 1 do
##
# test the show action
def test_show
- get :show
- assert_response :not_found
- assert_template "not_found"
- assert_select "p", "Sorry, the user block with ID could not be found."
+ # Viewing a block should fail when no ID is given
+ assert_raise ActionController::UrlGenerationError do
+ get :show
+ end
+ # Viewing a block should fail when a bogus ID is given
get :show, :id => 99999
assert_response :not_found
assert_template "not_found"
assert_select "p", "Sorry, the user block with ID 99999 could not be found."
- get :show, :id => user_blocks(:active_block)
- assert_response :success
-
+ # Viewing an expired block should work
get :show, :id => user_blocks(:expired_block)
assert_response :success
+ # Viewing a revoked block should work
get :show, :id => user_blocks(:revoked_block)
assert_response :success
+
+ # Viewing an active block should work, but shouldn't mark it as seen
+ get :show, :id => user_blocks(:active_block)
+ assert_response :success
+ assert_equal true, UserBlock.find(user_blocks(:active_block).id).needs_view
+
+ # Login as the blocked user
+ session[:user] = users(:blocked_user).id
+
+ # Now viewing it should mark it as seen
+ get :show, :id => user_blocks(:active_block)
+ assert_response :success
+ assert_equal false, UserBlock.find(user_blocks(:active_block).id).needs_view
end
##
# test the new action
def test_new
+ # Check that the block creation page requires us to login
get :new, :display_name => users(:normal_user).display_name
assert_redirected_to login_path(:referer => new_user_block_path(:display_name => users(:normal_user).display_name))
+ # Login as a normal user
session[:user] = users(:public_user).id
- cookies["_osm_username"] = users(:public_user).display_name
+ # Check that normal users can't load the block creation page
get :new, :display_name => users(:normal_user).display_name
assert_redirected_to user_blocks_path
assert_equal "You need to be a moderator to perform that action.", flash[:error]
+ # Login as a moderator
session[:user] = users(:moderator_user).id
- cookies["_osm_username"] = users(:moderator_user).display_name
+ # Check that the block creation page loads for moderators
get :new, :display_name => users(:normal_user).display_name
assert_response :success
assert_select "form#new_user_block", :count => 1 do
assert_select "input[type='submit'][value='Create block']", :count => 1
end
+ # We should get an error if no user is specified
get :new
assert_response :not_found
assert_template "user/no_such_user"
- assert_select "h2", "The user does not exist"
+ assert_select "h1", "The user does not exist"
+ # We should get an error if the user doesn't exist
get :new, :display_name => "non_existent_user"
assert_response :not_found
assert_template "user/no_such_user"
- assert_select "h2", "The user non_existent_user does not exist"
+ assert_select "h1", "The user non_existent_user does not exist"
end
##
# test the edit action
def test_edit
+ # Check that the block edit page requires us to login
get :edit, :id => user_blocks(:active_block).id
assert_redirected_to login_path(:referer => edit_user_block_path(:id => user_blocks(:active_block).id))
+ # Login as a normal user
session[:user] = users(:public_user).id
- cookies["_osm_username"] = users(:public_user).display_name
+ # Check that normal users can't load the block edit page
get :edit, :id => user_blocks(:active_block).id
assert_redirected_to user_blocks_path
assert_equal "You need to be a moderator to perform that action.", flash[:error]
+ # Login as a moderator
session[:user] = users(:moderator_user).id
- cookies["_osm_username"] = users(:moderator_user).display_name
+ # Check that the block edit page loads for moderators
get :edit, :id => user_blocks(:active_block).id
assert_response :success
assert_select "form#edit_user_block_#{user_blocks(:active_block).id}", :count => 1 do
assert_select "input[type='submit'][value='Update block']", :count => 1
end
- get :edit
- assert_response :not_found
- assert_template "not_found"
- assert_select "p", "Sorry, the user block with ID could not be found."
+ # We should get an error if no user is specified
+ assert_raise ActionController::UrlGenerationError do
+ get :edit
+ end
+ # We should get an error if the user doesn't exist
get :edit, :id => 99999
assert_response :not_found
assert_template "not_found"
##
# test the create action
def test_create
+ # Not logged in yet, so creating a block should fail
post :create
assert_response :forbidden
+ # Login as a normal user
session[:user] = users(:public_user).id
- cookies["_osm_username"] = users(:public_user).display_name
+ # Check that normal users can't create blocks
post :create
assert_response :forbidden
+ # Login as a moderator
session[:user] = users(:moderator_user).id
- cookies["_osm_username"] = users(:moderator_user).display_name
+ # A bogus block period should result in an error
assert_no_difference "UserBlock.count" do
post :create,
:display_name => users(:unblocked_user).display_name,
assert_redirected_to new_user_block_path(:display_name => users(:unblocked_user).display_name)
assert_equal "The blocking period must be one of the values selectable in the drop-down list.", flash[:error]
+ # Check that creating a block works
assert_difference "UserBlock.count", 1 do
post :create,
:display_name => users(:unblocked_user).display_name,
assert_equal "markdown", b.reason_format
assert_equal users(:moderator_user).id, b.creator_id
+ # We should get an error if no user is specified
post :create
assert_response :not_found
assert_template "user/no_such_user"
- assert_select "h2", "The user does not exist"
+ assert_select "h1", "The user does not exist"
+ # We should get an error if the user doesn't exist
post :create, :display_name => "non_existent_user"
assert_response :not_found
assert_template "user/no_such_user"
- assert_select "h2", "The user non_existent_user does not exist"
+ assert_select "h1", "The user non_existent_user does not exist"
end
##
# test the update action
def test_update
- put :update
+ # Not logged in yet, so updating a block should fail
+ put :update, :id => user_blocks(:active_block).id
assert_response :forbidden
+ # Login as a normal user
session[:user] = users(:public_user).id
- cookies["_osm_username"] = users(:public_user).display_name
- put :update
+ # Check that normal users can't update blocks
+ put :update, :id => user_blocks(:active_block).id
assert_response :forbidden
+ # Login as the wrong moderator
session[:user] = users(:second_moderator_user).id
- cookies["_osm_username"] = users(:second_moderator_user).display_name
+ # Check that only the person who created a block can update it
assert_no_difference "UserBlock.count" do
put :update,
:id => user_blocks(:active_block).id,
assert_redirected_to edit_user_block_path(:id => user_blocks(:active_block).id)
assert_equal "Only the moderator who created this block can edit it.", flash[:error]
+ # Login as the correct moderator
session[:user] = users(:moderator_user).id
- cookies["_osm_username"] = users(:moderator_user).display_name
+ # A bogus block period should result in an error
assert_no_difference "UserBlock.count" do
put :update,
:id => user_blocks(:active_block).id,
assert_redirected_to edit_user_block_path(:id => user_blocks(:active_block).id)
assert_equal "The blocking period must be one of the values selectable in the drop-down list.", flash[:error]
+ # Check that updating a block works
assert_no_difference "UserBlock.count" do
put :update,
:id => user_blocks(:active_block).id,
assert_equal true, b.needs_view
assert_equal "Vandalism", b.reason
- put :update
- assert_response :not_found
- assert_template "not_found"
- assert_select "p", "Sorry, the user block with ID could not be found."
+ # We should get an error if no block ID is specified
+ assert_raise ActionController::UrlGenerationError do
+ put :update
+ end
+ # We should get an error if the block doesn't exist
put :update, :id => 99999
assert_response :not_found
assert_template "not_found"
##
# test the revoke action
def test_revoke
+ # Check that the block revoke page requires us to login
get :revoke, :id => user_blocks(:active_block).id
assert_redirected_to login_path(:referer => revoke_user_block_path(:id => user_blocks(:active_block).id))
+ # Login as a normal user
session[:user] = users(:public_user).id
- cookies["_osm_username"] = users(:public_user).display_name
+ # Check that normal users can't load the block revoke page
get :revoke, :id => user_blocks(:active_block).id
assert_redirected_to user_blocks_path
assert_equal "You need to be a moderator to perform that action.", flash[:error]
+ # Login as a moderator
session[:user] = users(:moderator_user).id
- cookies["_osm_username"] = users(:moderator_user).display_name
+ # Check that the block revoke page loads for moderators
get :revoke, :id => user_blocks(:active_block).id
assert_response :success
assert_template "revoke"
assert_select "input[type='submit'][value='Revoke!']", :count => 1
end
+ # Check that revoking a block works
post :revoke, :id => user_blocks(:active_block).id, :confirm => true
assert_redirected_to user_block_path(:id => user_blocks(:active_block).id)
b = UserBlock.find(user_blocks(:active_block).id)
assert_in_delta Time.now, b.ends_at, 1
- get :revoke
- assert_response :not_found
- assert_template "not_found"
- assert_select "p", "Sorry, the user block with ID could not be found."
+ # We should get an error if no block ID is specified
+ assert_raise ActionController::UrlGenerationError do
+ get :revoke
+ end
+ # We should get an error if the block doesn't exist
get :revoke, :id => 99999
assert_response :not_found
assert_template "not_found"
##
# test the blocks_on action
def test_blocks_on
- get :blocks_on
- assert_response :not_found
- assert_template "user/no_such_user"
- assert_select "h2", "The user does not exist"
+ # Asking for a list of blocks with no user name should fail
+ assert_raise ActionController::UrlGenerationError do
+ get :blocks_on
+ end
+ # Asking for a list of blocks with a bogus user name should fail
get :blocks_on, :display_name => "non_existent_user"
assert_response :not_found
assert_template "user/no_such_user"
- assert_select "h2", "The user non_existent_user does not exist"
+ assert_select "h1", "The user non_existent_user does not exist"
+ # Check the list of blocks for a user that has never been blocked
get :blocks_on, :display_name => users(:normal_user).display_name
assert_response :success
assert_select "table#block_list", false
assert_select "p", "#{users(:normal_user).display_name} has not been blocked yet."
+ # Check the list of blocks for a user that is currently blocked
get :blocks_on, :display_name => users(:blocked_user).display_name
assert_response :success
assert_select "table#block_list", :count => 1 do
assert_select "a[href='#{user_block_path(user_blocks(:revoked_block))}']", 1
end
+ # Check the list of blocks for a user that has previously been blocked
get :blocks_on, :display_name => users(:unblocked_user).display_name
assert_response :success
assert_select "table#block_list", :count => 1 do
##
# test the blocks_by action
def test_blocks_by
- get :blocks_by
- assert_response :not_found
- assert_template "user/no_such_user"
- assert_select "h2", "The user does not exist"
+ # Asking for a list of blocks with no user name should fail
+ assert_raise ActionController::UrlGenerationError do
+ get :blocks_by
+ end
+ # Asking for a list of blocks with a bogus user name should fail
get :blocks_by, :display_name => "non_existent_user"
assert_response :not_found
assert_template "user/no_such_user"
- assert_select "h2", "The user non_existent_user does not exist"
+ assert_select "h1", "The user non_existent_user does not exist"
+ # Check the list of blocks given by one moderator
get :blocks_by, :display_name => users(:moderator_user).display_name
assert_response :success
assert_select "table#block_list", :count => 1 do
assert_select "a[href='#{user_block_path(user_blocks(:active_block))}']", 1
end
+ # Check the list of blocks given by a different moderator
get :blocks_by, :display_name => users(:second_moderator_user).display_name
assert_response :success
assert_select "table#block_list", :count => 1 do
assert_select "a[href='#{user_block_path(user_blocks(:revoked_block))}']", 1
end
+ # Check the list of blocks (not) given by a normal user
get :blocks_by, :display_name => users(:normal_user).display_name
assert_response :success
assert_select "table#block_list", false
projects / rails.git / blobdiff