Avoid using or comparing explicit model ids

[rails.git] / app / models / user_preference.rb

diff --git a/app/models/user_preference.rb b/app/models/user_preference.rb
index b5110bbf5592fd37b599e8f599ea27c2e77580e7..7c65a589953a688e3d4aa87e533ac00e9c8839ce 100644 (file)
--- a/app/models/user_preference.rb
+++ b/app/models/user_preference.rb
@@ -2,17 +2,16 @@ class UserPreference < ActiveRecord::Base
   self.primary_keys = "user_id", "k"
 
   belongs_to :user
   self.primary_keys = "user_id", "k"
 
   belongs_to :user

-  
-  validates_length_of :k, :within => 1..255
-  validates_length_of :v, :within => 1..255
+
+  validates :user, :presence => true, :associated => true
+  validates :k, :v, :length => 1..255

 
   # Turn this Node in to an XML Node without the <osm> wrapper.
   def to_xml_node
 
   # Turn this Node in to an XML Node without the <osm> wrapper.
   def to_xml_node

-    el1 = XML::Node.new 'preference'
-    el1['k'] = self.k
-    el1['v'] = self.v
-    
-    return el1
-  end
+    el1 = XML::Node.new "preference"
+    el1["k"] = k
+    el1["v"] = v

 
 

+    el1
+  end

 end
 end