Store selected map color scheme

[rails.git] / app / helpers / banner_helper.rb

diff --git a/app/helpers/banner_helper.rb b/app/helpers/banner_helper.rb
index fef6eaa5e77c989c177eb0c15aed84687c844fbf..9048d484001d2d5c12ef23591798bac65532302e 100644 (file)
--- a/app/helpers/banner_helper.rb
+++ b/app/helpers/banner_helper.rb
@@ -1,13 +1,19 @@
 module BannerHelper
   def active_banners
     BANNERS.reject do |_k, v|
 module BannerHelper
   def active_banners
     BANNERS.reject do |_k, v|

-      enddate = v[:enddate]

       begin
       begin

-        parsed = enddate && Date.parse(enddate)
+        startdate = v[:startdate] && Date.parse(v[:startdate])

       rescue StandardError
       rescue StandardError

-        parsed = nil
+        startdate = nil

       end
       end

-      !parsed.is_a?(Date) || (parsed.is_a?(Date) && parsed.past?)
+
+      begin
+        enddate = v[:enddate] && Date.parse(v[:enddate])
+      rescue StandardError
+        enddate = nil
+      end
+
+      startdate&.future? || enddate&.past?

     end
   end
 
     end
   end
 


@@ -28,7 +34,7 @@ module BannerHelper
       index = cval.to_i
       cookies[ckey] = index - 1 if index.positive?
 
       index = cval.to_i
       cookies[ckey] = index - 1 if index.positive?
 

-      # pick banner with mininum queue position
+      # pick banner with minimum queue position

       next if index > min_index
 
       # or if equal queue position, pick banner with soonest end date (i.e. next expiring)
       next if index > min_index
 
       # or if equal queue position, pick banner with soonest end date (i.e. next expiring)