Bump eslint from 8.45.0 to 8.46.0

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a40f0f4f726524d7e89c6358d5dc12f355afcc0b..527c793545f61d6307aedff2f35df3f69cf307cc 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2021-06-29 17:25:37 UTC using RuboCop version 1.18.0.
+# on 2023-04-11 16:47:05 UTC using RuboCop version 1.50.0.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new


@@ -14,17 +14,19 @@ require:
   - rubocop-rails
   - rubocop-rake
 
   - rubocop-rails
   - rubocop-rake
 

-# Offense count: 510
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 557
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.

 # URISchemes: http, https
 Layout/LineLength:
 # URISchemes: http, https
 Layout/LineLength:

-  Max: 270
+  Max: 248

 
 

-# Offense count: 34
+# Offense count: 29
+# This cop supports unsafe autocorrection (--autocorrect-all).

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:

+    - 'app/controllers/accounts_controller.rb'

     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
     - 'app/controllers/application_controller.rb'


@@ -40,44 +42,34 @@ Lint/AssignmentInCondition:
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
     - 'lib/osm.rb'
     - 'script/deliver-message'
 

-# Offense count: 8
-# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
-Lint/DuplicateBranch:
-  Exclude:
-    - 'app/controllers/api_controller.rb'
-    - 'app/controllers/diary_entries_controller.rb'
-    - 'app/controllers/geocoder_controller.rb'
-    - 'app/helpers/browse_tags_helper.rb'
-    - 'lib/password_hash.rb'
-
-# Offense count: 631
-# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+# Offense count: 680
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.

 Metrics/AbcSize:
 Metrics/AbcSize:

-  Max: 235
+  Max: 189

 
 

-# Offense count: 68
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
-# IgnoredMethods: refine
+# Offense count: 73
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
+# AllowedMethods: refine

 Metrics/BlockLength:
   Max: 71
 
 Metrics/BlockLength:
   Max: 71
 

-# Offense count: 15
+# Offense count: 20

 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 5
 

-# Offense count: 25
+# Offense count: 26

 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:

-  Max: 361
+  Max: 285

 
 

-# Offense count: 56
-# Configuration parameters: IgnoredMethods.
+# Offense count: 59
+# Configuration parameters: AllowedMethods, AllowedPatterns.

 Metrics/CyclomaticComplexity:
 Metrics/CyclomaticComplexity:

-  Max: 25
+  Max: 26

 
 

-# Offense count: 703
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# Offense count: 753
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.

 Metrics/MethodLength:
   Max: 179
 
 Metrics/MethodLength:
   Max: 179
 


@@ -86,40 +78,21 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 6
 
 Metrics/ParameterLists:
   Max: 6
 

-# Offense count: 60
-# Configuration parameters: IgnoredMethods.
+# Offense count: 56
+# Configuration parameters: AllowedMethods, AllowedPatterns.

 Metrics/PerceivedComplexity:
 Metrics/PerceivedComplexity:

-  Max: 26
+  Max: 27

 
 

-# Offense count: 519
-Minitest/MultipleAssertions:
-  Max: 88
+# Offense count: 2394
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/EmptyLineBeforeAssertionMethods:
+  Enabled: false

 
 

-# Offense count: 4
-Naming/AccessorMethodName:
-  Exclude:
-    - 'app/controllers/application_controller.rb'
-    - 'app/helpers/title_helper.rb'
-    - 'lib/osm.rb'
+# Offense count: 565
+Minitest/MultipleAssertions:
+  Max: 54

 
 

-# Offense count: 21
-# Configuration parameters: CheckIdentifiers, CheckConstants, CheckVariables, CheckStrings, CheckSymbols, CheckComments, CheckFilepaths, FlaggedTerms.
-Naming/InclusiveLanguage:
-  Exclude:
-    - 'app/controllers/sessions_controller.rb'
-    - 'app/controllers/users_controller.rb'
-    - 'app/helpers/browse_tags_helper.rb'
-    - 'app/views/api/capabilities/show.builder'
-    - 'app/views/confirmations/_resend_success_flash.html.erb'
-    - 'app/views/users/blocked.html.erb'
-    - 'app/views/users/suspended.html.erb'
-    - 'config/environments/production.rb'
-    - 'config/initializers/canonical_rails.rb'
-    - 'config/initializers/config.rb'
-    - 'config/initializers/doorkeeper.rb'
-    - 'test/integration/user_login_test.rb'
-
-# Offense count: 8
+# Offense count: 1

 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # ForbiddenPrefixes: is_, has_, have_
 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
 # ForbiddenPrefixes: is_, has_, have_


@@ -127,12 +100,13 @@ Naming/InclusiveLanguage:
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:

-    - 'app/models/changeset.rb'
-    - 'app/models/old_node.rb'
-    - 'app/models/old_relation.rb'
-    - 'app/models/old_way.rb'

     - 'app/models/user.rb'
     - 'app/models/user.rb'

-    - 'lib/classic_pagination/pagination.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ActionControllerFlashBeforeRender:
+  Exclude:
+    - 'app/controllers/traces_controller.rb'

 
 # Offense count: 5
 # Configuration parameters: Database, Include.
 
 # Offense count: 5
 # Configuration parameters: Database, Include.


@@ -159,12 +133,26 @@ Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/title_helper.rb'
 
   Exclude:
     - 'app/helpers/title_helper.rb'
 

-# Offense count: 1
+# Offense count: 16
+# Configuration parameters: IgnoreScopes, Include.
+# Include: app/models/**/*.rb
+Rails/InverseOf:
+  Exclude:
+    - 'app/models/changeset.rb'
+    - 'app/models/diary_entry.rb'
+    - 'app/models/friendship.rb'
+    - 'app/models/issue.rb'
+    - 'app/models/message.rb'
+    - 'app/models/note.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 2

 # Configuration parameters: Include.
 # Configuration parameters: Include.

-# Include: app/controllers/**/*.rb
+# Include: app/controllers/**/*.rb, app/mailers/**/*.rb

 Rails/LexicallyScopedActionFilter:
   Exclude:
     - 'app/controllers/oauth2_applications_controller.rb'
 Rails/LexicallyScopedActionFilter:
   Exclude:
     - 'app/controllers/oauth2_applications_controller.rb'

+    - 'app/controllers/oauth2_authorizations_controller.rb'

 
 # Offense count: 5
 # Configuration parameters: Include.
 
 # Offense count: 5
 # Configuration parameters: Include.


@@ -177,24 +165,26 @@ Rails/NotNullColumn:
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 

-# Offense count: 9
+# Offense count: 7

 Rails/OutputSafety:
   Exclude:
 Rails/OutputSafety:
   Exclude:

-    - 'app/controllers/sessions_controller.rb'
-    - 'app/controllers/users_controller.rb'

     - 'app/helpers/application_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
     - 'app/helpers/application_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 

-# Offense count: 91
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
-  Enabled: false
+# Offense count: 16
+# Configuration parameters: Include.
+# Include: db/**/*.rb
+Rails/ThreeStateBooleanColumn:
+  Exclude:
+    - 'db/migrate/001_create_osm_db.rb'
+    - 'db/migrate/006_tile_nodes.rb'
+    - 'db/migrate/007_add_relations.rb'
+    - 'db/migrate/054_refactor_map_bug_tables.rb'
+    - 'db/migrate/20140507110937_create_changeset_comments.rb'

 
 # Offense count: 6
 
 # Offense count: 6

-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).

 Rake/Desc:
   Exclude:
     - 'lib/tasks/auto_annotate_models.rake'
 Rake/Desc:
   Exclude:
     - 'lib/tasks/auto_annotate_models.rake'


@@ -202,15 +192,15 @@ Rake/Desc:
     - 'lib/tasks/subscribe_diary_authors.rake'
     - 'lib/tasks/subscribe_old_changesets.rake'
 
     - 'lib/tasks/subscribe_diary_authors.rake'
     - 'lib/tasks/subscribe_old_changesets.rake'
 

-# Offense count: 597
-# Cop supports --auto-correct.
+# Offense count: 632
+# This cop supports unsafe autocorrection (--autocorrect-all).

 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 

-# Offense count: 73
-# Cop supports --auto-correct.
-# Configuration parameters: Strict.
+# Offense count: 72
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.

 Style/NumericLiterals:
   MinDigits: 15
 Style/NumericLiterals:
   MinDigits: 15