Merge branch 'master' into moderation

[rails.git] / app / controllers / oauth_controller.rb

diff --git a/app/controllers/oauth_controller.rb b/app/controllers/oauth_controller.rb
index c7251f0a7c081f4ff23f485435f901514e73009c..84bbcf1850e5c95cf6d6d925c0c009b3f7e83315 100644 (file)
--- a/app/controllers/oauth_controller.rb
+++ b/app/controllers/oauth_controller.rb
@@ -1,9 +1,9 @@
-require 'oauth/controllers/provider_controller'
+require "oauth/controllers/provider_controller"

 
 class OauthController < ApplicationController
   include OAuth::Controllers::ProviderController
 
 
 class OauthController < ApplicationController
   include OAuth::Controllers::ProviderController
 

-  layout 'site'
+  layout "site"

 
   def login_required
     authorize_web
 
   def login_required
     authorize_web


@@ -27,53 +27,51 @@ class OauthController < ApplicationController
   end
 
   def revoke
   end
 
   def revoke

-    @token = current_user.oauth_tokens.find_by_token params[:token]
+    @token = current_user.oauth_tokens.find_by :token => params[:token]

     if @token
       @token.invalidate!
     if @token
       @token.invalidate!

-      flash[:notice] = t('oauth.revoke.flash', :application => @token.client_application.name)
+      flash[:notice] = t("oauth.revoke.flash", :application => @token.client_application.name)

     end
     redirect_to oauth_clients_url(:display_name => @token.user.display_name)
   end
 
     end
     redirect_to oauth_clients_url(:display_name => @token.user.display_name)
   end
 

-protected
+  protected

 
   def oauth1_authorize
 
   def oauth1_authorize

-    unless @token
-      render :action=>"authorize_failure"
-      return
-    end
+    append_content_security_policy_directives(:form_action => %w[*])

 
 

-    unless @token.invalidated?
-      if request.post?
-        if user_authorizes_token?
-          @token.authorize!(current_user)
-          if @token.oauth10?
-            callback_url = params[:oauth_callback] || @token.client_application.callback_url
-          else
-            callback_url = @token.oob? ? @token.client_application.callback_url : @token.callback_url
-          end
-          @redirect_url = URI.parse(callback_url) unless callback_url.blank?
+    if @token.invalidated?
+      @message = t "oauth.oauthorize_failure.invalid"
+      render :action => "authorize_failure"
+    elsif request.post?
+      if user_authorizes_token?
+        @token.authorize!(current_user)
+        callback_url = if @token.oauth10?
+                         params[:oauth_callback] || @token.client_application.callback_url
+                       else
+                         @token.oob? ? @token.client_application.callback_url : @token.callback_url
+                       end
+        @redirect_url = URI.parse(callback_url) if callback_url.present?

 
 

-          unless @redirect_url.to_s.blank?
-            @redirect_url.query = @redirect_url.query.blank? ?
-            "oauth_token=#{@token.token}" :
-              @redirect_url.query + "&oauth_token=#{@token.token}"
-            unless @token.oauth10?
-              @redirect_url.query += "&oauth_verifier=#{@token.verifier}"
-            end
-            redirect_to @redirect_url.to_s
-          else
-            render :action => "authorize_success"
-          end
+        if @redirect_url.to_s.blank?
+          render :action => "authorize_success"

         else
         else

-          @token.invalidate!
-          @message = t("oauth.oauthorize_failure.denied", :app_name => @token.client_application.name)
-          render :action => "authorize_failure"
+          @redirect_url.query = if @redirect_url.query.blank?
+                                  "oauth_token=#{@token.token}"
+                                else
+                                  @redirect_url.query +
+                                    "&oauth_token=#{@token.token}"
+                                end
+
+          @redirect_url.query += "&oauth_verifier=#{@token.verifier}" unless @token.oauth10?
+
+          redirect_to @redirect_url.to_s

         end
         end

+      else
+        @token.invalidate!
+        @message = t("oauth.oauthorize_failure.denied", :app_name => @token.client_application.name)
+        render :action => "authorize_failure"

       end
       end

-    else
-      @message = t "oauth.oauthorize_failure.invalid"
-      render :action => "authorize_failure"

     end
   end
 end
     end
   end
 end