Refactor more controller tests

[rails.git] / test / controllers / issues_controller_test.rb

diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index 141c7b20d99678ebdc65e2d977a43cec2dabd96b..5e980e0b8a02e5962e0bca421129a83fac210b7a 100644 (file)
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -1,26 +1,26 @@
 require "test_helper"
 
 require "test_helper"
 

-class IssuesControllerTest < ActionController::TestCase
+class IssuesControllerTest < ActionDispatch::IntegrationTest

   def test_index
     # Access issues list without login
   def test_index
     # Access issues list without login

-    get :index
+    get issues_path

     assert_response :redirect
     assert_redirected_to login_path(:referer => issues_path)
 
     # Access issues list as normal user
     assert_response :redirect
     assert_redirected_to login_path(:referer => issues_path)
 
     # Access issues list as normal user

-    session[:user] = create(:user).id
-    get :index
+    session_for(create(:user))
+    get issues_path

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Access issues list as administrator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Access issues list as administrator

-    session[:user] = create(:administrator_user).id
-    get :index
+    session_for(create(:administrator_user))
+    get issues_path

     assert_response :success
 
     # Access issues list as moderator
     assert_response :success
 
     # Access issues list as moderator

-    session[:user] = create(:moderator_user).id
-    get :index
+    session_for(create(:moderator_user))
+    get issues_path

     assert_response :success
   end
 
     assert_response :success
   end
 


@@ -29,24 +29,24 @@ class IssuesControllerTest < ActionController::TestCase
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
     # Access issue without login
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
     # Access issue without login

-    get :show, :params => { :id => issue.id }
+    get issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to login_path(:referer => issue_path(issue))
 
     # Access issue as normal user
     assert_response :redirect
     assert_redirected_to login_path(:referer => issue_path(issue))
 
     # Access issue as normal user

-    session[:user] = create(:user).id
-    get :show, :params => { :id => issue.id }
+    session_for(create(:user))
+    get issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Access issue as administrator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Access issue as administrator

-    session[:user] = create(:administrator_user).id
-    get :show, :params => { :id => issue.id }
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)

     assert_redirected_to :controller => :errors, :action => :not_found
 
     # Access issue as moderator
     assert_redirected_to :controller => :errors, :action => :not_found
 
     # Access issue as moderator

-    session[:user] = create(:moderator_user).id
-    get :show, :params => { :id => issue.id }
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)

     assert_response :success
   end
 
     assert_response :success
   end
 


@@ -55,24 +55,24 @@ class IssuesControllerTest < ActionController::TestCase
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
     # Access issue without login
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
     # Access issue without login

-    get :show, :params => { :id => issue.id }
+    get issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to login_path(:referer => issue_path(issue))
 
     # Access issue as normal user
     assert_response :redirect
     assert_redirected_to login_path(:referer => issue_path(issue))
 
     # Access issue as normal user

-    session[:user] = create(:user).id
-    get :show, :params => { :id => issue.id }
+    session_for(create(:user))
+    get issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Access issue as moderator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Access issue as moderator

-    session[:user] = create(:moderator_user).id
-    get :show, :params => { :id => issue.id }
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)

     assert_redirected_to :controller => :errors, :action => :not_found
 
     # Access issue as administrator
     assert_redirected_to :controller => :errors, :action => :not_found
 
     # Access issue as administrator

-    session[:user] = create(:administrator_user).id
-    get :show, :params => { :id => issue.id }
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)

     assert_response :success
   end
 
     assert_response :success
   end
 


@@ -81,25 +81,24 @@ class IssuesControllerTest < ActionController::TestCase
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
     # Resolve issue without login
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
     # Resolve issue without login

-    get :resolve, :params => { :id => issue.id }
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => resolve_issue_path(issue))
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden

 
     # Resolve issue as normal user
 
     # Resolve issue as normal user

-    session[:user] = create(:user).id
-    get :resolve, :params => { :id => issue.id }
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Resolve issue as administrator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Resolve issue as administrator

-    session[:user] = create(:administrator_user).id
-    get :resolve, :params => { :id => issue.id }
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)

     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.resolved?
 
     # Resolve issue as moderator
     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.resolved?
 
     # Resolve issue as moderator

-    session[:user] = create(:moderator_user).id
-    get :resolve, :params => { :id => issue.id }
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)

     assert_response :redirect
     assert issue.reload.resolved?
   end
     assert_response :redirect
     assert issue.reload.resolved?
   end


@@ -109,25 +108,24 @@ class IssuesControllerTest < ActionController::TestCase
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
     # Resolve issue without login
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
     # Resolve issue without login

-    get :resolve, :params => { :id => issue.id }
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => resolve_issue_path(issue))
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden

 
     # Resolve issue as normal user
 
     # Resolve issue as normal user

-    session[:user] = create(:user).id
-    get :resolve, :params => { :id => issue.id }
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Resolve issue as moderator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Resolve issue as moderator

-    session[:user] = create(:moderator_user).id
-    get :resolve, :params => { :id => issue.id }
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)

     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.resolved?
 
     # Resolve issue as administrator
     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.resolved?
 
     # Resolve issue as administrator

-    session[:user] = create(:administrator_user).id
-    get :resolve, :params => { :id => issue.id }
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)

     assert_response :redirect
     assert issue.reload.resolved?
   end
     assert_response :redirect
     assert issue.reload.resolved?
   end


@@ -137,25 +135,24 @@ class IssuesControllerTest < ActionController::TestCase
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
     # Ignore issue without login
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
     # Ignore issue without login

-    get :ignore, :params => { :id => issue.id }
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => ignore_issue_path(issue))
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden

 
     # Ignore issue as normal user
 
     # Ignore issue as normal user

-    session[:user] = create(:user).id
-    get :ignore, :params => { :id => issue.id }
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Ignore issue as administrator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Ignore issue as administrator

-    session[:user] = create(:administrator_user).id
-    get :ignore, :params => { :id => issue.id }
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)

     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.ignored?
 
     # Ignore issue as moderator
     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.ignored?
 
     # Ignore issue as moderator

-    session[:user] = create(:moderator_user).id
-    get :ignore, :params => { :id => issue.id }
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)

     assert_response :redirect
     assert issue.reload.ignored?
   end
     assert_response :redirect
     assert issue.reload.ignored?
   end


@@ -165,25 +162,24 @@ class IssuesControllerTest < ActionController::TestCase
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
     # Ignore issue without login
     issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
     # Ignore issue without login

-    get :ignore, :params => { :id => issue.id }
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => ignore_issue_path(issue))
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden

 
     # Ignore issue as normal user
 
     # Ignore issue as normal user

-    session[:user] = create(:user).id
-    get :ignore, :params => { :id => issue.id }
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Ignore issue as moderator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Ignore issue as moderator

-    session[:user] = create(:moderator_user).id
-    get :ignore, :params => { :id => issue.id }
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)

     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.ignored?
 
     # Ignore issue as administrator
     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.ignored?
 
     # Ignore issue as administrator

-    session[:user] = create(:administrator_user).id
-    get :ignore, :params => { :id => issue.id }
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)

     assert_response :redirect
     assert issue.reload.ignored?
   end
     assert_response :redirect
     assert issue.reload.ignored?
   end


@@ -195,25 +191,24 @@ class IssuesControllerTest < ActionController::TestCase
     issue.resolve!
 
     # Reopen issue without login
     issue.resolve!
 
     # Reopen issue without login

-    get :reopen, :params => { :id => issue.id }
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => reopen_issue_path(issue))
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden

 
     # Reopen issue as normal user
 
     # Reopen issue as normal user

-    session[:user] = create(:user).id
-    get :reopen, :params => { :id => issue.id }
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Reopen issue as administrator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Reopen issue as administrator

-    session[:user] = create(:administrator_user).id
-    get :reopen, :params => { :id => issue.id }
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)

     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.open?
 
     # Reopen issue as moderator
     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.open?
 
     # Reopen issue as moderator

-    session[:user] = create(:moderator_user).id
-    get :reopen, :params => { :id => issue.id }
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)

     assert_response :redirect
     assert issue.reload.open?
   end
     assert_response :redirect
     assert issue.reload.open?
   end


@@ -225,25 +220,24 @@ class IssuesControllerTest < ActionController::TestCase
     issue.resolve!
 
     # Reopen issue without login
     issue.resolve!
 
     # Reopen issue without login

-    get :reopen, :params => { :id => issue.id }
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => reopen_issue_path(issue))
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden

 
     # Reopen issue as normal user
 
     # Reopen issue as normal user

-    session[:user] = create(:user).id
-    get :reopen, :params => { :id => issue.id }
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)

     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Reopen issue as moderator
     assert_response :redirect
     assert_redirected_to :controller => :errors, :action => :forbidden
 
     # Reopen issue as moderator

-    session[:user] = create(:moderator_user).id
-    get :reopen, :params => { :id => issue.id }
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)

     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.open?
 
     # Reopen issue as administrator
     assert_redirected_to :controller => :errors, :action => :not_found
     assert_not issue.reload.open?
 
     # Reopen issue as administrator

-    session[:user] = create(:administrator_user).id
-    get :reopen, :params => { :id => issue.id }
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)

     assert_response :redirect
     assert issue.reload.open?
   end
     assert_response :redirect
     assert issue.reload.open?
   end