User factory for uniqueness tests

[rails.git] / test / models / user_test.rb

diff --git a/test/models/user_test.rb b/test/models/user_test.rb
index b517fd2af8fbb5f0ebd373db6ebe013dda5da62d..3f66c5827460e96ab9b25e1a0cb7407f044d827d 100644 (file)
--- a/test/models/user_test.rb
+++ b/test/models/user_test.rb
@@ -1,9 +1,11 @@
 # -*- coding: utf-8 -*-
 # -*- coding: utf-8 -*-

-require 'test_helper'
+require "test_helper"

 
 class UserTest < ActiveSupport::TestCase
 
 class UserTest < ActiveSupport::TestCase

+  include Rails::Dom::Testing::Assertions::SelectorAssertions
+

   api_fixtures
   api_fixtures

-  fixtures :friends, :languages, :user_roles
+  fixtures :user_roles

 
   def test_invalid_with_empty_attributes
     user = User.new
 
   def test_invalid_with_empty_attributes
     user = User.new


@@ -18,10 +20,11 @@ class UserTest < ActiveSupport::TestCase
   end
 
   def test_unique_email
   end
 
   def test_unique_email

+    existing_user = create(:user)

     new_user = User.new(
     new_user = User.new(

-      :email => users(:normal_user).email,
+      :email => existing_user.email,

       :status => "active",
       :status => "active",

-      :pass_crypt => Digest::MD5.hexdigest('test'),
+      :pass_crypt => Digest::MD5.hexdigest("test"),

       :display_name => "new user",
       :data_public => 1,
       :description => "desc"
       :display_name => "new user",
       :data_public => 1,
       :description => "desc"


@@ -31,11 +34,12 @@ class UserTest < ActiveSupport::TestCase
   end
 
   def test_unique_display_name
   end
 
   def test_unique_display_name

+    existing_user = create(:user)

     new_user = User.new(
       :email => "tester@openstreetmap.org",
       :status => "pending",
     new_user = User.new(
       :email => "tester@openstreetmap.org",
       :status => "pending",

-      :pass_crypt => Digest::MD5.hexdigest('test'),
-      :display_name => users(:normal_user).display_name,
+      :pass_crypt => Digest::MD5.hexdigest("test"),
+      :display_name => existing_user.display_name,

       :data_public => 1,
       :description => "desc"
     )
       :data_public => 1,
       :description => "desc"
     )


@@ -50,20 +54,20 @@ class UserTest < ActiveSupport::TestCase
              輕觸搖晃的遊戲@ah.com も対応します@s.name)
 
     ok.each do |name|
              輕觸搖晃的遊戲@ah.com も対応します@s.name)
 
     ok.each do |name|

-      user = users(:normal_user)
+      user = build(:user)

       user.email = name
       assert user.valid?(:save), user.errors.full_messages.join(",")
     end
 
     bad.each do |name|
       user.email = name
       assert user.valid?(:save), user.errors.full_messages.join(",")
     end
 
     bad.each do |name|

-      user = users(:normal_user)
+      user = build(:user)

       user.email = name
       assert user.invalid?(:save), "#{name} is valid when it shouldn't be"
     end
   end
 
   def test_display_name_length
       user.email = name
       assert user.invalid?(:save), "#{name} is valid when it shouldn't be"
     end
   end
 
   def test_display_name_length

-    user = users(:normal_user)
+    user = build(:user)

     user.display_name = "123"
     assert user.valid?, " should allow nil display name"
     user.display_name = "12"
     user.display_name = "123"
     assert user.valid?, " should allow nil display name"
     user.display_name = "12"


@@ -91,19 +95,20 @@ class UserTest < ActiveSupport::TestCase
            "new", "terms", "save", "confirm", "confirm-email",
            "go_public", "reset-password", "forgot-password", "suspended"]
     ok.each do |display_name|
            "new", "terms", "save", "confirm", "confirm-email",
            "go_public", "reset-password", "forgot-password", "suspended"]
     ok.each do |display_name|

-      user = users(:normal_user)
+      user = build(:user)

       user.display_name = display_name
       assert user.valid?, "#{display_name} is invalid, when it should be"
     end
 
     bad.each do |display_name|
       user.display_name = display_name
       assert user.valid?, "#{display_name} is invalid, when it should be"
     end
 
     bad.each do |display_name|

-      user = users(:normal_user)
+      user = build(:user)

       user.display_name = display_name
       assert !user.valid?, "#{display_name} is valid when it shouldn't be"
     end
   end
 
   def test_friend_with
       user.display_name = display_name
       assert !user.valid?, "#{display_name} is valid when it shouldn't be"
     end
   end
 
   def test_friend_with

+    create(:friend, :befriender => users(:normal_user), :befriendee => users(:public_user))

     assert users(:normal_user).is_friends_with?(users(:public_user))
     assert !users(:normal_user).is_friends_with?(users(:inactive_user))
     assert !users(:public_user).is_friends_with?(users(:normal_user))
     assert users(:normal_user).is_friends_with?(users(:public_user))
     assert !users(:normal_user).is_friends_with?(users(:inactive_user))
     assert !users(:public_user).is_friends_with?(users(:normal_user))


@@ -114,27 +119,26 @@ class UserTest < ActiveSupport::TestCase
 
   def test_users_nearby
     # second user has their data public and is close by normal user
 
   def test_users_nearby
     # second user has their data public and is close by normal user

-    assert_equal [users(:public_user)], users(:normal_user).nearby
+    assert_equal [users(:public_user), users(:german_user)], users(:normal_user).nearby

     # second_user has normal user nearby, but normal user has their data private
     # second_user has normal user nearby, but normal user has their data private

-    assert_equal [], users(:public_user).nearby
+    assert_equal [users(:german_user)], users(:public_user).nearby

     # inactive_user has no user nearby
     assert_equal [], users(:inactive_user).nearby
     # north_pole_user has no user nearby, and doesn't throw exception
     assert_equal [], users(:north_pole_user).nearby
     # inactive_user has no user nearby
     assert_equal [], users(:inactive_user).nearby
     # north_pole_user has no user nearby, and doesn't throw exception
     assert_equal [], users(:north_pole_user).nearby

+    # confirmed_user has no home location
+    assert_equal [], users(:confirmed_user).nearby

   end
 
   def test_friends_with
     # normal user is a friend of second user
   end
 
   def test_friends_with
     # normal user is a friend of second user

-    # it should be a one way friend accossitation
-    assert_equal 1, Friend.count
+    # it should be a one way friend associatation

     norm = users(:normal_user)
     sec = users(:public_user)
     norm = users(:normal_user)
     sec = users(:public_user)

-    # friend = Friend.new
-    # friend.befriender = norm
-    # friend.befriendee = sec
-    # friend.save
-    assert_equal [sec], norm.nearby
-    assert_equal 1, norm.nearby.size
+    create(:friend, :befriender => norm, :befriendee => sec)
+    assert_equal 1, Friend.count
+    assert_equal [sec], norm.friend_users
+    assert_equal 1, norm.friend_users.size

     assert_equal 1, Friend.count
     assert norm.is_friends_with?(sec)
     assert !sec.is_friends_with?(norm)
     assert_equal 1, Friend.count
     assert norm.is_friends_with?(sec)
     assert !sec.is_friends_with?(norm)


@@ -148,8 +152,8 @@ class UserTest < ActiveSupport::TestCase
   end
 
   def test_user_preferred_editor
   end
 
   def test_user_preferred_editor

-    user = users(:normal_user)
-    assert_equal nil, user.preferred_editor
+    user = create(:user)
+    assert_nil user.preferred_editor

     user.preferred_editor = "potlatch"
     assert_equal "potlatch", user.preferred_editor
     user.save!
     user.preferred_editor = "potlatch"
     assert_equal "potlatch", user.preferred_editor
     user.save!


@@ -159,88 +163,132 @@ class UserTest < ActiveSupport::TestCase
   end
 
   def test_visible
   end
 
   def test_visible

-    assert_equal 15, User.visible.count
+    pending = create(:user, :pending)
+    active = create(:user, :active)
+    confirmed = create(:user, :confirmed)
+    suspended = create(:user, :suspended)
+    deleted = create(:user, :deleted)
+
+    assert User.visible.find(pending.id)
+    assert User.visible.find(active.id)
+    assert User.visible.find(confirmed.id)

     assert_raise ActiveRecord::RecordNotFound do
     assert_raise ActiveRecord::RecordNotFound do

-      User.visible.find(users(:suspended_user).id)
+      User.visible.find(suspended.id)

     end
     assert_raise ActiveRecord::RecordNotFound do
     end
     assert_raise ActiveRecord::RecordNotFound do

-      User.visible.find(users(:deleted_user).id)
+      User.visible.find(deleted.id)

     end
   end
 
   def test_active
     end
   end
 
   def test_active

-    assert_equal 14, User.active.count
+    pending = create(:user, :pending)
+    active = create(:user, :active)
+    confirmed = create(:user, :confirmed)
+    suspended = create(:user, :suspended)
+    deleted = create(:user, :deleted)
+
+    assert User.active.find(active.id)
+    assert User.active.find(confirmed.id)

     assert_raise ActiveRecord::RecordNotFound do
     assert_raise ActiveRecord::RecordNotFound do

-      User.active.find(users(:inactive_user).id)
+      User.active.find(pending.id)

     end
     assert_raise ActiveRecord::RecordNotFound do
     end
     assert_raise ActiveRecord::RecordNotFound do

-      User.active.find(users(:suspended_user).id)
+      User.active.find(suspended.id)

     end
     assert_raise ActiveRecord::RecordNotFound do
     end
     assert_raise ActiveRecord::RecordNotFound do

-      User.active.find(users(:deleted_user).id)
+      User.active.find(deleted.id)

     end
   end
 
   def test_identifiable
     end
   end
 
   def test_identifiable

-    assert_equal 16, User.identifiable.count
+    public_user = create(:user, :data_public => true)
+    private_user = create(:user, :data_public => false)
+
+    assert User.identifiable.find(public_user.id)

     assert_raise ActiveRecord::RecordNotFound do
     assert_raise ActiveRecord::RecordNotFound do

-      User.identifiable.find(users(:normal_user).id)
+      User.identifiable.find(private_user.id)

     end
   end
 
   def test_languages
     end
   end
 
   def test_languages

+    create(:language, :code => "en")
+    create(:language, :code => "de")
+    create(:language, :code => "sl")
+

     user = users(:normal_user)
     assert_equal ["en"], user.languages
     user.languages = %w(de fr en)
     assert_equal %w(de fr en), user.languages
     user.languages = %w(fr de sl)
     assert_equal "de", user.preferred_language
     user = users(:normal_user)
     assert_equal ["en"], user.languages
     user.languages = %w(de fr en)
     assert_equal %w(de fr en), user.languages
     user.languages = %w(fr de sl)
     assert_equal "de", user.preferred_language

-    assert_equal "de", user.preferred_language_from(%w(en sl de es))
+    assert_equal %w(fr de sl), user.preferred_languages.map(&:to_s)
+    user = users(:public_user)
+    assert_equal %w(en de), user.languages

   end
 
   def test_visible?
   end
 
   def test_visible?

-    assert_equal true, users(:inactive_user).visible?
-    assert_equal true, users(:normal_user).visible?
-    assert_equal true, users(:confirmed_user).visible?
-    assert_equal false, users(:suspended_user).visible?
-    assert_equal false, users(:deleted_user).visible?
+    assert_equal true, build(:user, :pending).visible?
+    assert_equal true, build(:user, :active).visible?
+    assert_equal true, build(:user, :confirmed).visible?
+    assert_equal false, build(:user, :suspended).visible?
+    assert_equal false, build(:user, :deleted).visible?

   end
 
   def test_active?
   end
 
   def test_active?

-    assert_equal false, users(:inactive_user).active?
-    assert_equal true, users(:normal_user).active?
-    assert_equal true, users(:confirmed_user).active?
-    assert_equal false, users(:suspended_user).active?
-    assert_equal false, users(:deleted_user).active?
+    assert_equal false, build(:user, :pending).active?
+    assert_equal true, build(:user, :active).active?
+    assert_equal true, build(:user, :confirmed).active?
+    assert_equal false, build(:user, :suspended).active?
+    assert_equal false, build(:user, :deleted).active?

   end
 
   def test_moderator?
   end
 
   def test_moderator?

-    assert_equal false, users(:normal_user).moderator?
-    assert_equal true, users(:moderator_user).moderator?
+    assert_equal false, create(:user).moderator?
+    assert_equal true, create(:moderator_user).moderator?

   end
 
   def test_administrator?
   end
 
   def test_administrator?

-    assert_equal false, users(:normal_user).administrator?
-    assert_equal true, users(:administrator_user).administrator?
+    assert_equal false, create(:user).administrator?
+    assert_equal true, create(:administrator_user).administrator?

   end
 
   def test_has_role?
   end
 
   def test_has_role?

-    assert_equal false, users(:normal_user).has_role?("administrator")
-    assert_equal false, users(:normal_user).has_role?("moderator")
-    assert_equal true, users(:administrator_user).has_role?("administrator")
-    assert_equal true, users(:moderator_user).has_role?("moderator")
+    assert_equal false, create(:user).has_role?("administrator")
+    assert_equal false, create(:user).has_role?("moderator")
+    assert_equal true, create(:administrator_user).has_role?("administrator")
+    assert_equal true, create(:moderator_user).has_role?("moderator")

   end
 
   def test_delete
   end
 
   def test_delete

-    user = users(:normal_user)
+    user = create(:user, :with_home_location, :description => "foo")

     user.delete
     assert_equal "user_#{user.id}", user.display_name
     assert user.description.blank?
     user.delete
     assert_equal "user_#{user.id}", user.display_name
     assert user.description.blank?

-    assert_equal nil, user.home_lat
-    assert_equal nil, user.home_lon
+    assert_nil user.home_lat
+    assert_nil user.home_lon

     assert_equal false, user.image.file?
     assert_equal "deleted", user.status
     assert_equal false, user.visible?
     assert_equal false, user.active?
   end
     assert_equal false, user.image.file?
     assert_equal "deleted", user.status
     assert_equal false, user.visible?
     assert_equal false, user.active?
   end

+
+  def test_to_xml
+    user = build(:user, :with_home_location)
+    xml = user.to_xml
+    assert_select Nokogiri::XML::Document.parse(xml.to_s), "user" do
+      assert_select "[display_name=?]", user.display_name
+      assert_select "[account_created=?]", user.creation_time.xmlschema
+      assert_select "home[lat=?][lon=?][zoom=?]", user.home_lat.to_s, user.home_lon.to_s, user.home_zoom.to_s
+    end
+  end
+
+  def test_to_xml_node
+    user = build(:user, :with_home_location)
+    xml = user.to_xml_node
+    assert_select Nokogiri::XML::DocumentFragment.parse(xml.to_s), "user" do
+      assert_select "[display_name=?]", user.display_name
+      assert_select "[account_created=?]", user.creation_time.xmlschema
+      assert_select "home[lat=?][lon=?][zoom=?]", user.home_lat.to_s, user.home_lon.to_s, user.home_zoom.to_s
+    end
+  end

 end
 end