Use the user factory to generate login details.

[rails.git] / test / integration / user_terms_seen_test.rb

diff --git a/test/integration/user_terms_seen_test.rb b/test/integration/user_terms_seen_test.rb
index 64a101024738c3642bc8d5ebe07efe3accd425d7..ad0c3b211da494073470e3b648a3cb436c2bd162 100644 (file)
--- a/test/integration/user_terms_seen_test.rb
+++ b/test/integration/user_terms_seen_test.rb
@@ -1,15 +1,13 @@
-require File.dirname(__FILE__) + '/../test_helper'
+require "test_helper"

 
 

-class UserTermsSeenTest < ActionController::IntegrationTest
-  fixtures :users
-
-  def auth_header(user, pass)
-    {"HTTP_AUTHORIZATION" => "Basic %s" % Base64.encode64("#{user}:#{pass}")}
+class UserTermsSeenTest < ActionDispatch::IntegrationTest
+  def setup
+    stub_hostip_requests

   end
 
   def test_api_blocked
   end
 
   def test_api_blocked

-    if REQUIRE_TERMS_SEEN
-      user = users(:terms_not_seen_user)
+    with_terms_seen(true) do
+      user = create(:user, :terms_seen => false)

 
       get "/api/#{API_VERSION}/user/preferences", nil, auth_header(user.display_name, "test")
       assert_response :forbidden
 
       get "/api/#{API_VERSION}/user/preferences", nil, auth_header(user.display_name, "test")
       assert_response :forbidden


@@ -24,25 +22,25 @@ class UserTermsSeenTest < ActionController::IntegrationTest
   end
 
   def test_terms_presented_at_login
   end
 
   def test_terms_presented_at_login

-    if REQUIRE_TERMS_SEEN
-      user = users(:terms_not_seen_user)
+    with_terms_seen(true) do
+      user = create(:user, :terms_seen => false)

 
       # try to log in
       get_via_redirect "/login"
       assert_response :success
 
       # try to log in
       get_via_redirect "/login"
       assert_response :success

-      assert_template 'user/login'
-      post "/login", {'username' => user.email, 'password' => 'test', :referer => "/"}
+      assert_template "user/login"
+      post "/login", :username => user.email, :password => "test", :referer => "/diary/new"

       assert_response :redirect
       # but now we need to look at the terms
       assert_response :redirect
       # but now we need to look at the terms

-      assert_redirected_to "controller" => "user", "action" => "terms", :referer => "/"
+      assert_redirected_to :controller => :user, :action => :terms, :referer => "/diary/new"

       follow_redirect!
       assert_response :success
 
       # don't agree to the terms, but hit decline
       follow_redirect!
       assert_response :success
 
       # don't agree to the terms, but hit decline

-      post "/user/save", {'decline' => 'decline', 'referer' => '/'}
-      assert_redirected_to "/"
+      post "/user/save", :decline => true, :referer => "/diary/new"
+      assert_redirected_to "/diary/new"

       follow_redirect!
       follow_redirect!

-      
+

       # should be carried through to a normal login with a message
       assert_response :success
       assert !flash[:notice].nil?
       # should be carried through to a normal login with a message
       assert_response :success
       assert !flash[:notice].nil?


@@ -50,24 +48,40 @@ class UserTermsSeenTest < ActionController::IntegrationTest
   end
 
   def test_terms_cant_be_circumvented
   end
 
   def test_terms_cant_be_circumvented

-    if REQUIRE_TERMS_SEEN
-      user = users(:terms_not_seen_user)
+    with_terms_seen(true) do
+      user = create(:user, :terms_seen => false)

 
       # try to log in
       get_via_redirect "/login"
       assert_response :success
 
       # try to log in
       get_via_redirect "/login"
       assert_response :success

-      assert_template 'user/login'
-      post "/login", {'username' => user.email, 'password' => 'test', :referer => "/"}
+      assert_template "user/login"
+      post "/login", :username => user.email, :password => "test", :referer => "/diary/new"

       assert_response :redirect
       # but now we need to look at the terms
       assert_response :redirect
       # but now we need to look at the terms

-      assert_redirected_to "controller" => "user", "action" => "terms", :referer => "/"
-      follow_redirect!
-      assert_response :success
+      assert_redirected_to :controller => :user, :action => :terms, :referer => "/diary/new"

 
       # check that if we go somewhere else now, it redirects
       # back to the terms page.
       get "/traces/mine"
 
       # check that if we go somewhere else now, it redirects
       # back to the terms page.
       get "/traces/mine"

-      assert_redirected_to "controller" => "user", "action" => "terms", :referer => "/traces/mine"
+      assert_redirected_to :controller => :user, :action => :terms, :referer => "/traces/mine"
+      get "/traces/mine", :referer => "/diary/new"
+      assert_redirected_to :controller => :user, :action => :terms, :referer => "/diary/new"

     end
   end
     end
   end

+
+  private
+
+  def auth_header(user, pass)
+    { "HTTP_AUTHORIZATION" => format("Basic %s", Base64.encode64("#{user}:#{pass}")) }
+  end
+
+  def with_terms_seen(value)
+    require_terms_seen = Object.send("remove_const", "REQUIRE_TERMS_SEEN")
+    Object.const_set("REQUIRE_TERMS_SEEN", value)
+
+    yield
+
+    Object.send("remove_const", "REQUIRE_TERMS_SEEN")
+    Object.const_set("REQUIRE_TERMS_SEEN", require_terms_seen)
+  end

 end
 end