{ :path => "/api/0.6/relation/1/2.json", :method => :get },
{ :controller => "api/old_relations", :action => "show", :relation_id => "1", :version => "2", :format => "json" }
)
- assert_routing(
- { :path => "/api/0.6/relation/1/2/redact", :method => :post },
- { :controller => "api/old_relations", :action => "redact", :relation_id => "1", :version => "2" }
- )
end
##
assert_response :success, "Redacted relation should not be gone for moderator, when flag passed."
end
-
- ##
- # test the redaction of an old version of a relation, while not being
- # authorised.
- def test_redact_relation_unauthorised
- do_redact_redactable_relation
- assert_response :unauthorized, "should need to be authenticated to redact."
- end
-
- ##
- # test the redaction of an old version of a relation, while being
- # authorised as a normal user.
- def test_redact_relation_normal_user
- do_redact_redactable_relation bearer_authorization_header
- assert_response :forbidden, "should need to be moderator to redact."
- end
-
- ##
- # test that, even as moderator, the current version of a relation
- # can't be redacted.
- def test_redact_relation_current_version
- relation = create(:relation, :with_history, :version => 2)
- redaction = create(:redaction)
- auth_header = bearer_authorization_header create(:moderator_user)
-
- post relation_version_redact_path(relation, 2), :params => { :redaction => redaction.id }, :headers => auth_header
-
- assert_response :bad_request, "shouldn't be OK to redact current version as moderator."
- end
-
- def test_redact_relation_by_regular_without_write_redactions_scope
- auth_header = bearer_authorization_header(create(:user), :scopes => %w[read_prefs write_api])
- do_redact_redactable_relation(auth_header)
- assert_response :forbidden, "should need to be moderator to redact."
- end
-
- def test_redact_relation_by_regular_with_write_redactions_scope
- auth_header = bearer_authorization_header(create(:user), :scopes => %w[write_redactions])
- do_redact_redactable_relation(auth_header)
- assert_response :forbidden, "should need to be moderator to redact."
- end
-
- def test_redact_relation_by_moderator_without_write_redactions_scope
- auth_header = bearer_authorization_header(create(:moderator_user), :scopes => %w[read_prefs write_api])
- do_redact_redactable_relation(auth_header)
- assert_response :forbidden, "should need to have write_redactions scope to redact."
- end
-
- def test_redact_relation_by_moderator_with_write_redactions_scope
- auth_header = bearer_authorization_header(create(:moderator_user), :scopes => %w[write_redactions])
- do_redact_redactable_relation(auth_header)
- assert_response :success, "should be OK to redact old version as moderator with write_redactions scope."
- end
-
- ##
- # test the redaction of an old version of a relation, while being
- # authorised as a moderator.
- def test_redact_relation_moderator
- relation = create(:relation, :with_history, :version => 2)
- relation_v1 = relation.old_relations.find_by(:version => 1)
- redaction = create(:redaction)
- auth_header = bearer_authorization_header create(:moderator_user)
-
- post relation_version_redact_path(*relation_v1.id), :params => { :redaction => redaction.id }, :headers => auth_header
-
- assert_response :success, "should be OK to redact old version as moderator."
- relation_v1.reload
- assert_predicate relation_v1, :redacted?
- assert_equal redaction, relation_v1.redaction
- end
-
- ##
- # test the unredaction of an old version of a relation, while not being
- # authorised.
- def test_unredact_relation_unauthorised
- relation = create(:relation, :with_history, :version => 2)
- relation_v1 = relation.old_relations.find_by(:version => 1)
- relation_v1.redact!(create(:redaction))
-
- post relation_version_redact_path(relation_v1.relation_id, relation_v1.version)
- assert_response :unauthorized, "should need to be authenticated to unredact."
- end
-
- ##
- # test the unredaction of an old version of a relation, while being
- # authorised as a normal user.
- def test_unredact_relation_normal_user
- relation = create(:relation, :with_history, :version => 2)
- relation_v1 = relation.old_relations.find_by(:version => 1)
- relation_v1.redact!(create(:redaction))
-
- auth_header = bearer_authorization_header
-
- post relation_version_redact_path(relation_v1.relation_id, relation_v1.version), :headers => auth_header
- assert_response :forbidden, "should need to be moderator to unredact."
- end
-
- ##
- # test the unredaction of an old version of a relation, while being
- # authorised as a moderator.
- def test_unredact_relation_moderator
- relation = create(:relation, :with_history, :version => 2)
- relation_v1 = relation.old_relations.find_by(:version => 1)
- relation_v1.redact!(create(:redaction))
-
- auth_header = bearer_authorization_header create(:moderator_user)
-
- post relation_version_redact_path(relation_v1.relation_id, relation_v1.version), :headers => auth_header
- assert_response :success, "should be OK to unredact old version as moderator."
-
- # check moderator can still see the redacted data, without passing
- # the appropriate flag
- get api_relation_version_path(relation_v1.relation_id, relation_v1.version), :headers => auth_header
- assert_response :success, "After unredaction, relation should not be gone for moderator."
-
- # and when accessed via history
- get api_relation_versions_path(relation), :headers => auth_header
- assert_response :success, "Redaction shouldn't have stopped history working."
- assert_select "osm relation[id='#{relation_v1.relation_id}'][version='#{relation_v1.version}']", 1,
- "relation #{relation_v1.relation_id} version #{relation_v1.version} should still be present in the history for moderators."
-
- auth_header = bearer_authorization_header
-
- # check normal user can now see the redacted data
- get api_relation_version_path(relation_v1.relation_id, relation_v1.version), :headers => auth_header
- assert_response :success, "After redaction, node should not be gone for normal user."
-
- # and when accessed via history
- get api_relation_versions_path(relation), :headers => auth_header
- assert_response :success, "Redaction shouldn't have stopped history working."
- assert_select "osm relation[id='#{relation_v1.relation_id}'][version='#{relation_v1.version}']", 1,
- "relation #{relation_v1.relation_id} version #{relation_v1.version} should still be present in the history for normal users."
- end
-
- private
-
- def do_redact_redactable_relation(headers = {})
- relation = create(:relation, :with_history, :version => 2)
- redaction = create(:redaction)
-
- post relation_version_redact_path(relation, 1), :params => { :redaction => redaction.id }, :headers => headers
- end
end
end
projects / rails.git / blobdiff