Fix new rubocop warnings

[rails.git] / app / models / node.rb

diff --git a/app/models/node.rb b/app/models/node.rb
index 2e71813ff948e853a429df6764b4ca375f220ce0..3214564c8e4fbf7c1eb15e75f953e9f187869c41 100644 (file)
--- a/app/models/node.rb
+++ b/app/models/node.rb
@@ -21,13 +21,12 @@
 #  current_nodes_changeset_id_fkey  (changeset_id => changesets.id)
 #
 
 #  current_nodes_changeset_id_fkey  (changeset_id => changesets.id)
 #
 

-class Node < ActiveRecord::Base
+class Node < ApplicationRecord

   require "xml/libxml"
 
   include GeoRecord
   include ConsistencyValidations
   include NotRedactable
   require "xml/libxml"
 
   include GeoRecord
   include ConsistencyValidations
   include NotRedactable

-  include ObjectMetadata

 
   self.table_name = "current_nodes"
 
 
   self.table_name = "current_nodes"
 


@@ -71,19 +70,21 @@ class Node < ActiveRecord::Base
   end
 
   # Read in xml as text and return it's Node object representation
   end
 
   # Read in xml as text and return it's Node object representation

-  def self.from_xml(xml, create = false)
+  def self.from_xml(xml, create: false)

     p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
     doc = p.parse
     p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR)
     doc = p.parse

+    pt = doc.find_first("//osm/node")

 
 

-    doc.find("//osm/node").each do |pt|
-      return Node.from_xml_node(pt, create)
+    if pt
+      Node.from_xml_node(pt, :create => create)
+    else
+      raise OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/node element.")

     end
     end

-    raise OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/node element.")

   rescue LibXML::XML::Error, ArgumentError => e
     raise OSM::APIBadXMLError.new("node", xml, e.message)
   end
 
   rescue LibXML::XML::Error, ArgumentError => e
     raise OSM::APIBadXMLError.new("node", xml, e.message)
   end
 

-  def self.from_xml_node(pt, create = false)
+  def self.from_xml_node(pt, create: false)

     node = Node.new
 
     raise OSM::APIBadXMLError.new("node", pt, "lat missing") if pt["lat"].nil?
     node = Node.new
 
     raise OSM::APIBadXMLError.new("node", pt, "lat missing") if pt["lat"].nil?


@@ -205,7 +206,7 @@ class Node < ActiveRecord::Base
   end
 
   def tags
   end
 
   def tags

-    @tags ||= Hash[node_tags.collect { |t| [t.k, t.v] }]
+    @tags ||= node_tags.to_h { |t| [t.k, t.v] }

   end
 
   attr_writer :tags
   end
 
   attr_writer :tags