Merge branch 'master' into HEAD

[rails.git] / test / controllers / reports_controller_test.rb

diff --git a/test/controllers/reports_controller_test.rb b/test/controllers/reports_controller_test.rb
index 9c39350f95dfce9b1cf223678dc01b7e91a941a9..e8f59ec5ec1df1ed270c4f4e47607520a0300060 100644 (file)
--- a/test/controllers/reports_controller_test.rb
+++ b/test/controllers/reports_controller_test.rb
@@ -1,9 +1,9 @@
 require "test_helper"
 
 require "test_helper"
 

-class ReportsControllerTest < ActionController::TestCase
+class ReportsControllerTest < ActionDispatch::IntegrationTest

   def test_new_report_without_login
     target_user = create(:user)
   def test_new_report_without_login
     target_user = create(:user)

-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
+    get new_report_path(:reportable_id => target_user.id, :reportable_type => "User")

     assert_response :redirect
     assert_redirected_to login_path(:referer => new_report_path(:reportable_id => target_user.id, :reportable_type => "User"))
   end
     assert_response :redirect
     assert_redirected_to login_path(:referer => new_report_path(:reportable_id => target_user.id, :reportable_type => "User"))
   end


@@ -11,26 +11,22 @@ class ReportsControllerTest < ActionController::TestCase
   def test_new_report_after_login
     target_user = create(:user)
 
   def test_new_report_after_login
     target_user = create(:user)
 

-    session[:user] = create(:user).id
-
-    assert_equal 0, Issue.count
+    session_for(create(:user))

 
     # Create an Issue and a report
 
     # Create an Issue and a report

-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
+    get new_report_path(:reportable_id => target_user.id, :reportable_type => "User")

     assert_response :success
     assert_difference "Issue.count", 1 do
       details = "Details of a report"
     assert_response :success
     assert_difference "Issue.count", 1 do
       details = "Details of a report"

-      post :create,
-           :params => {
-             :report => {
-               :details => details,
-               :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
-             }
-           }
+      category = "other"
+      post reports_path(:report => {
+                          :details => details,
+                          :category => category,
+                          :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
+                        })

     end
     end

-    assert_equal 1, Issue.count

     assert_response :redirect
     assert_response :redirect

-    assert_redirected_to root_path
+    assert_redirected_to user_path(target_user)

   end
 
   def test_new_report_with_incomplete_details
   end
 
   def test_new_report_with_incomplete_details


@@ -38,55 +34,41 @@ class ReportsControllerTest < ActionController::TestCase
     target_user = create(:user)
 
     # Login
     target_user = create(:user)
 
     # Login

-    session[:user] = create(:user).id
-
-    assert_equal 0, Issue.count
+    session_for(create(:user))

 
     # Create an Issue and a report
 
     # Create an Issue and a report

-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
+    get new_report_path(:reportable_id => target_user.id, :reportable_type => "User")

     assert_response :success
     assert_difference "Issue.count", 1 do
       details = "Details of a report"
     assert_response :success
     assert_difference "Issue.count", 1 do
       details = "Details of a report"

-      post :create,
-           :params => {
-             :report => {
-               :details => details,
-               :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
-             }
-           }
+      category = "other"
+      post reports_path(:report => {
+                          :details => details,
+                          :category => category,
+                          :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
+                        })

     end
     end

-    assert_equal 1, Issue.count

     assert_response :redirect
     assert_response :redirect

-    assert_redirected_to root_path
+    assert_redirected_to user_path(target_user)

 
 

-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
-    assert_response :success
+    issue = Issue.last

 
 

-    # Report without report_type
-    assert_no_difference "Issue.count" do
-      details = "Details of another report under the same issue"
-      post :create,
-           :params => {
-             :report => {
-               :details => details,
-               :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
-             }
-           }
-    end
-    assert_response :redirect
-    assert_equal 1, Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count
+    assert_equal 1, issue.reports.count
+
+    get new_report_path(:reportable_id => target_user.id, :reportable_type => "User")
+    assert_response :success

 
     # Report without details
     assert_no_difference "Issue.count" do
 
     # Report without details
     assert_no_difference "Issue.count" do

-      post :create,
-           :params => {
-             :report => {
-               :issue => { :reportable_id => 1, :reportable_type => "User" }
-             }
-           }
+      category = "other"
+      post reports_path(:report => {
+                          :category => category,
+                          :issue => { :reportable_id => 1, :reportable_type => "User" }
+                        })

     end
     assert_response :redirect
     end
     assert_response :redirect

-    assert_equal 1, Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count
+
+    assert_equal 1, issue.reports.count

   end
 
   def test_new_report_with_complete_details
   end
 
   def test_new_report_with_complete_details


@@ -94,42 +76,41 @@ class ReportsControllerTest < ActionController::TestCase
     target_user = create(:user)
 
     # Login
     target_user = create(:user)
 
     # Login

-    session[:user] = create(:user).id
-
-    assert_equal 0, Issue.count
+    session_for(create(:user))

 
     # Create an Issue and a report
 
     # Create an Issue and a report

-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
+    get new_report_path(:reportable_id => target_user.id, :reportable_type => "User")

     assert_response :success
     assert_difference "Issue.count", 1 do
       details = "Details of a report"
     assert_response :success
     assert_difference "Issue.count", 1 do
       details = "Details of a report"

-      post :create,
-           :params => {
-             :report => {
-               :details => details,
-               :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
-             }
-           }
+      category = "other"
+      post reports_path(:report => {
+                          :details => details,
+                          :category => category,
+                          :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
+                        })

     end
     end

-    assert_equal 1, Issue.count

     assert_response :redirect
     assert_response :redirect

-    assert_redirected_to root_path
+    assert_redirected_to user_path(target_user)
+
+    issue = Issue.last
+
+    assert_equal 1, issue.reports.count

 
     # Create a report for an existing Issue
 
     # Create a report for an existing Issue

-    get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User" }
+    get new_report_path(:reportable_id => target_user.id, :reportable_type => "User")

     assert_response :success
     assert_no_difference "Issue.count" do
       details = "Details of another report under the same issue"
     assert_response :success
     assert_no_difference "Issue.count" do
       details = "Details of another report under the same issue"

-      post :create,
-           :params => {
-             :report => {
-               :details => details,
-               :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
-             }
-           }
+      category = "other"
+      post reports_path(:report => {
+                          :details => details,
+                          :category => category,
+                          :issue => { :reportable_id => target_user.id, :reportable_type => "User" }
+                        })

     end
     assert_response :redirect
     end
     assert_response :redirect

-    report_count = Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count
-    assert_equal 2, report_count
+
+    assert_equal 2, issue.reports.count

   end
 end
   end
 end