Fix most auto-correctable rubocop issues

[rails.git] / app / controllers / user_blocks_controller.rb

diff --git a/app/controllers/user_blocks_controller.rb b/app/controllers/user_blocks_controller.rb
index 2284174be1e639aac5fabce5881e2bfdda9950a8..1b2ff89654ebbdb0068eae69438af7d2697faff8 100644 (file)
--- a/app/controllers/user_blocks_controller.rb
+++ b/app/controllers/user_blocks_controller.rb
@@ -19,7 +19,7 @@ class UserBlocksController < ApplicationController
   end
 
   def show
   end
 
   def show

-    if @user and @user.id == @user_block.user_id
+    if @user && @user.id == @user_block.user_id

       @user_block.needs_view = false
       @user_block.save!
     end
       @user_block.needs_view = false
       @user_block.save!
     end


@@ -34,15 +34,15 @@ class UserBlocksController < ApplicationController
   end
 
   def create
   end
 
   def create

-    if @valid_params 
+    if @valid_params

       @user_block = UserBlock.new(
         :user_id => @this_user.id,
         :creator_id => @user.id,
         :reason => params[:user_block][:reason],
       @user_block = UserBlock.new(
         :user_id => @this_user.id,
         :creator_id => @user.id,
         :reason => params[:user_block][:reason],

-        :ends_at => Time.now.getutc() + @block_period.hours,
+        :ends_at => Time.now.getutc + @block_period.hours,

         :needs_view => params[:user_block][:needs_view]
       )
         :needs_view => params[:user_block][:needs_view]
       )

-    
+

       if @user_block.save
         flash[:notice] = t('user_block.create.flash', :name => @this_user.display_name)
         redirect_to @user_block
       if @user_block.save
         flash[:notice] = t('user_block.create.flash', :name => @this_user.display_name)
         redirect_to @user_block


@@ -54,15 +54,15 @@ class UserBlocksController < ApplicationController
     end
   end
 
     end
   end
 

-  def update  
-    if @valid_params 
+  def update
+    if @valid_params

       if @user_block.creator_id != @user.id
         flash[:error] = t('user_block.update.only_creator_can_edit')
         redirect_to :action => "edit"
       elsif @user_block.update_attributes(
       if @user_block.creator_id != @user.id
         flash[:error] = t('user_block.update.only_creator_can_edit')
         redirect_to :action => "edit"
       elsif @user_block.update_attributes(

-              :ends_at => Time.now.getutc() + @block_period.hours,
-              :reason => params[:user_block][:reason],
-              :needs_view => params[:user_block][:needs_view]
+        :ends_at => Time.now.getutc + @block_period.hours,
+        :reason => params[:user_block][:reason],
+        :needs_view => params[:user_block][:needs_view]

             )
         flash[:notice] = t('user_block.update.success')
         redirect_to(@user_block)
             )
         flash[:notice] = t('user_block.update.success')
         redirect_to(@user_block)


@@ -79,7 +79,7 @@ class UserBlocksController < ApplicationController
   def revoke
     if params[:confirm]
       if @user_block.revoke! @user
   def revoke
     if params[:confirm]
       if @user_block.revoke! @user

-        flash[:notice] = t'user_block.revoke.flash'
+        flash[:notice] = t 'user_block.revoke.flash'

         redirect_to(@user_block)
       end
     end
         redirect_to(@user_block)
       end
     end


@@ -90,7 +90,7 @@ class UserBlocksController < ApplicationController
   def blocks_on
     @user_blocks_pages, @user_blocks = paginate(:user_blocks,
                                                 :include => [:user, :creator, :revoker],
   def blocks_on
     @user_blocks_pages, @user_blocks = paginate(:user_blocks,
                                                 :include => [:user, :creator, :revoker],

-                                                :conditions => {:user_id => @this_user.id},
+                                                :conditions => { :user_id => @this_user.id },

                                                 :order => "user_blocks.ends_at DESC",
                                                 :per_page => 20)
   end
                                                 :order => "user_blocks.ends_at DESC",
                                                 :per_page => 20)
   end


@@ -100,12 +100,13 @@ class UserBlocksController < ApplicationController
   def blocks_by
     @user_blocks_pages, @user_blocks = paginate(:user_blocks,
                                                 :include => [:user, :creator, :revoker],
   def blocks_by
     @user_blocks_pages, @user_blocks = paginate(:user_blocks,
                                                 :include => [:user, :creator, :revoker],

-                                                :conditions => {:creator_id => @this_user.id},
+                                                :conditions => { :creator_id => @this_user.id },

                                                 :order => "user_blocks.ends_at DESC",
                                                 :per_page => 20)
   end
 
   private
                                                 :order => "user_blocks.ends_at DESC",
                                                 :per_page => 20)
   end
 
   private

+

   ##
   # ensure that there is a "user_block" instance variable
   def lookup_user_block
   ##
   # ensure that there is a "user_block" instance variable
   def lookup_user_block


@@ -125,13 +126,12 @@ class UserBlocksController < ApplicationController
 
     if !UserBlock::PERIODS.include?(@block_period)
       flash[:error] = t('user_block.filter.block_period')
 
     if !UserBlock::PERIODS.include?(@block_period)
       flash[:error] = t('user_block.filter.block_period')

-      
-    elsif @user_block and !@user_block.active?
+
+    elsif @user_block && !@user_block.active?

       flash[:error] = t('user_block.filter.block_expired')
       flash[:error] = t('user_block.filter.block_expired')

-      
+

     else
       @valid_params = true
     end
   end
     else
       @valid_params = true
     end
   end

-

 end
 end