Use user factory for user_roles_controller tests.

[rails.git] / test / controllers / user_roles_controller_test.rb

diff --git a/test/controllers/user_roles_controller_test.rb b/test/controllers/user_roles_controller_test.rb
index 1d005824d2ea840daa9615b9ff46b251cb46d438..ef1a57cbe92b2c3f114bb3e106a62f3e2e83f5d8 100644 (file)
--- a/test/controllers/user_roles_controller_test.rb
+++ b/test/controllers/user_roles_controller_test.rb
@@ -1,8 +1,6 @@
-require 'test_helper'
+require "test_helper"

 
 class UserRolesControllerTest < ActionController::TestCase
 
 class UserRolesControllerTest < ActionController::TestCase

-  fixtures :users, :user_roles
-

   ##
   # test all routes which lead to this controller
   def test_routes
   ##
   # test all routes which lead to this controller
   def test_routes


@@ -19,23 +17,31 @@ class UserRolesControllerTest < ActionController::TestCase
   ##
   # test the grant action
   def test_grant
   ##
   # test the grant action
   def test_grant

+    target_user = create(:user)
+    normal_user = create(:user)
+    administrator_user = create(:administrator_user)
+    # Create a super user which has all known roles
+    super_user = create(:user)
+    UserRole::ALL_ROLES.each do |role|
+      create(:user_role, :user => super_user, :granter => administrator_user, :role => role)
+    end
+

     # Granting should fail when not logged in
     # Granting should fail when not logged in

-    post :grant, :display_name => users(:normal_user).display_name, :role => "moderator"
+    post :grant, :display_name => target_user.display_name, :role => "moderator"

     assert_response :forbidden
 
     # Login as an unprivileged user
     assert_response :forbidden
 
     # Login as an unprivileged user

-    session[:user] = users(:public_user).id
+    session[:user] = normal_user.id

 
     # Granting should still fail
 
     # Granting should still fail

-    post :grant, :display_name => users(:normal_user).display_name, :role => "moderator"
-    assert_redirected_to user_path(users(:normal_user).display_name)
+    post :grant, :display_name => target_user.display_name, :role => "moderator"
+    assert_redirected_to user_path(target_user.display_name)

     assert_equal "Only administrators can perform user role management, and you are not an administrator.", flash[:error]
 
     # Login as an administrator
     assert_equal "Only administrators can perform user role management, and you are not an administrator.", flash[:error]
 
     # Login as an administrator

-    session[:user] = users(:administrator_user).id
+    session[:user] = administrator_user.id

 
     UserRole::ALL_ROLES.each do |role|
 
     UserRole::ALL_ROLES.each do |role|

-

       # Granting a role to a non-existent user should fail
       assert_difference "UserRole.count", 0 do
         post :grant, :display_name => "non_existent_user", :role => role
       # Granting a role to a non-existent user should fail
       assert_difference "UserRole.count", 0 do
         post :grant, :display_name => "non_existent_user", :role => role


@@ -44,56 +50,63 @@ class UserRolesControllerTest < ActionController::TestCase
       assert_template "user/no_such_user"
       assert_select "h1", "The user non_existent_user does not exist"
 
       assert_template "user/no_such_user"
       assert_select "h1", "The user non_existent_user does not exist"
 

-      # Granting a role from a user that already has it should fail
+      # Granting a role to a user that already has it should fail

       assert_no_difference "UserRole.count" do
       assert_no_difference "UserRole.count" do

-        post :grant, :display_name => users(:super_user).display_name, :role => role
+        post :grant, :display_name => super_user.display_name, :role => role

       end
       end

-      assert_redirected_to user_path(users(:super_user).display_name)
+      assert_redirected_to user_path(super_user.display_name)

       assert_equal "The user already has role #{role}.", flash[:error]
 
       # Granting a role to a user that doesn't have it should work...
       assert_difference "UserRole.count", 1 do
       assert_equal "The user already has role #{role}.", flash[:error]
 
       # Granting a role to a user that doesn't have it should work...
       assert_difference "UserRole.count", 1 do

-        post :grant, :display_name => users(:normal_user).display_name, :role => role
+        post :grant, :display_name => target_user.display_name, :role => role

       end
       end

-      assert_redirected_to user_path(users(:normal_user).display_name)
+      assert_redirected_to user_path(target_user.display_name)

 
       # ...but trying a second time should fail
       assert_no_difference "UserRole.count" do
 
       # ...but trying a second time should fail
       assert_no_difference "UserRole.count" do

-        post :grant, :display_name => users(:normal_user).display_name, :role => role
+        post :grant, :display_name => target_user.display_name, :role => role

       end
       end

-      assert_redirected_to user_path(users(:normal_user).display_name)
+      assert_redirected_to user_path(target_user.display_name)

       assert_equal "The user already has role #{role}.", flash[:error]
       assert_equal "The user already has role #{role}.", flash[:error]

-

     end
 
     # Granting a non-existent role should fail
     assert_difference "UserRole.count", 0 do
     end
 
     # Granting a non-existent role should fail
     assert_difference "UserRole.count", 0 do

-      post :grant, :display_name => users(:normal_user).display_name, :role => "no_such_role"
+      post :grant, :display_name => target_user.display_name, :role => "no_such_role"

     end
     end

-    assert_redirected_to user_path(users(:normal_user).display_name)
+    assert_redirected_to user_path(target_user.display_name)

     assert_equal "The string `no_such_role' is not a valid role.", flash[:error]
   end
 
   ##
   # test the revoke action
   def test_revoke
     assert_equal "The string `no_such_role' is not a valid role.", flash[:error]
   end
 
   ##
   # test the revoke action
   def test_revoke

+    target_user = create(:user)
+    normal_user = create(:user)
+    administrator_user = create(:administrator_user)
+    # Create a super user which has all known roles
+    super_user = create(:user)
+    UserRole::ALL_ROLES.each do |role|
+      create(:user_role, :user => super_user, :granter => administrator_user, :role => role)
+    end
+

     # Revoking should fail when not logged in
     # Revoking should fail when not logged in

-    post :revoke, :display_name => users(:normal_user).display_name, :role => "moderator"
+    post :revoke, :display_name => target_user.display_name, :role => "moderator"

     assert_response :forbidden
 
     # Login as an unprivileged user
     assert_response :forbidden
 
     # Login as an unprivileged user

-    session[:user] = users(:public_user).id
+    session[:user] = normal_user.id

 
     # Revoking should still fail
 
     # Revoking should still fail

-    post :revoke, :display_name => users(:normal_user).display_name, :role => "moderator"
-    assert_redirected_to user_path(users(:normal_user).display_name)
+    post :revoke, :display_name => target_user.display_name, :role => "moderator"
+    assert_redirected_to user_path(target_user.display_name)

     assert_equal "Only administrators can perform user role management, and you are not an administrator.", flash[:error]
 
     # Login as an administrator
     assert_equal "Only administrators can perform user role management, and you are not an administrator.", flash[:error]
 
     # Login as an administrator

-    session[:user] = users(:administrator_user).id
+    session[:user] = administrator_user.id

 
     UserRole::ALL_ROLES.each do |role|
 
     UserRole::ALL_ROLES.each do |role|

-

       # Removing a role from a non-existent user should fail
       assert_difference "UserRole.count", 0 do
         post :revoke, :display_name => "non_existent_user", :role => role
       # Removing a role from a non-existent user should fail
       assert_difference "UserRole.count", 0 do
         post :revoke, :display_name => "non_existent_user", :role => role


@@ -104,31 +117,30 @@ class UserRolesControllerTest < ActionController::TestCase
 
       # Removing a role from a user that doesn't have it should fail
       assert_no_difference "UserRole.count" do
 
       # Removing a role from a user that doesn't have it should fail
       assert_no_difference "UserRole.count" do

-        post :revoke, :display_name => users(:normal_user).display_name, :role => role
+        post :revoke, :display_name => target_user.display_name, :role => role

       end
       end

-      assert_redirected_to user_path(users(:normal_user).display_name)
+      assert_redirected_to user_path(target_user.display_name)

       assert_equal "The user does not have role #{role}.", flash[:error]
 
       assert_equal "The user does not have role #{role}.", flash[:error]
 

-      # Removing a role' from a user that has it should work...
+      # Removing a role from a user that has it should work...

       assert_difference "UserRole.count", -1 do
       assert_difference "UserRole.count", -1 do

-        post :revoke, :display_name => users(:super_user).display_name, :role => role
+        post :revoke, :display_name => super_user.display_name, :role => role

       end
       end

-      assert_redirected_to user_path(users(:super_user).display_name)
+      assert_redirected_to user_path(super_user.display_name)

 
       # ...but trying a second time should fail
       assert_no_difference "UserRole.count" do
 
       # ...but trying a second time should fail
       assert_no_difference "UserRole.count" do

-        post :revoke, :display_name => users(:super_user).display_name, :role => role
+        post :revoke, :display_name => super_user.display_name, :role => role

       end
       end

-      assert_redirected_to user_path(users(:super_user).display_name)
+      assert_redirected_to user_path(super_user.display_name)

       assert_equal "The user does not have role #{role}.", flash[:error]
       assert_equal "The user does not have role #{role}.", flash[:error]

-

     end
 
     # Revoking a non-existent role should fail
     assert_difference "UserRole.count", 0 do
     end
 
     # Revoking a non-existent role should fail
     assert_difference "UserRole.count", 0 do

-      post :revoke, :display_name => users(:normal_user).display_name, :role => "no_such_role"
+      post :revoke, :display_name => target_user.display_name, :role => "no_such_role"

     end
     end

-    assert_redirected_to user_path(users(:normal_user).display_name)
+    assert_redirected_to user_path(target_user.display_name)

     assert_equal "The string `no_such_role' is not a valid role.", flash[:error]
   end
 end
     assert_equal "The string `no_such_role' is not a valid role.", flash[:error]
   end
 end