Use user factories for some changeset_controller tests.

[rails.git] / test / controllers / changeset_controller_test.rb

diff --git a/test/controllers/changeset_controller_test.rb b/test/controllers/changeset_controller_test.rb
index fc4f4b681000353636d9f213c3968ad0acef70f0..9d39a8555c56b41b8525f30257cc0bd38bea847a 100644 (file)
--- a/test/controllers/changeset_controller_test.rb
+++ b/test/controllers/changeset_controller_test.rb
@@ -1,5 +1,5 @@
-require 'test_helper'
-require 'changeset_controller'
+require "test_helper"
+require "changeset_controller"

 
 class ChangesetControllerTest < ActionController::TestCase
   api_fixtures
 
 class ChangesetControllerTest < ActionController::TestCase
   api_fixtures


@@ -27,6 +27,14 @@ class ChangesetControllerTest < ActionController::TestCase
       { :path => "/api/0.6/changeset/1", :method => :get },
       { :controller => "changeset", :action => "read", :id => "1" }
     )
       { :path => "/api/0.6/changeset/1", :method => :get },
       { :controller => "changeset", :action => "read", :id => "1" }
     )

+    assert_routing(
+      { :path => "/api/0.6/changeset/1/subscribe", :method => :post },
+      { :controller => "changeset", :action => "subscribe", :id => "1" }
+    )
+    assert_routing(
+      { :path => "/api/0.6/changeset/1/unsubscribe", :method => :post },
+      { :controller => "changeset", :action => "unsubscribe", :id => "1" }
+    )

     assert_routing(
       { :path => "/api/0.6/changeset/1", :method => :put },
       { :controller => "changeset", :action => "update", :id => "1" }
     assert_routing(
       { :path => "/api/0.6/changeset/1", :method => :put },
       { :controller => "changeset", :action => "update", :id => "1" }


@@ -35,10 +43,26 @@ class ChangesetControllerTest < ActionController::TestCase
       { :path => "/api/0.6/changeset/1/close", :method => :put },
       { :controller => "changeset", :action => "close", :id => "1" }
     )
       { :path => "/api/0.6/changeset/1/close", :method => :put },
       { :controller => "changeset", :action => "close", :id => "1" }
     )

+    assert_routing(
+      { :path => "/api/0.6/changeset/1/comment", :method => :post },
+      { :controller => "changeset", :action => "comment", :id => "1" }
+    )
+    assert_routing(
+      { :path => "/api/0.6/changeset/comment/1/hide", :method => :post },
+      { :controller => "changeset", :action => "hide_comment", :id => "1" }
+    )
+    assert_routing(
+      { :path => "/api/0.6/changeset/comment/1/unhide", :method => :post },
+      { :controller => "changeset", :action => "unhide_comment", :id => "1" }
+    )

     assert_routing(
       { :path => "/api/0.6/changesets", :method => :get },
       { :controller => "changeset", :action => "query" }
     )
     assert_routing(
       { :path => "/api/0.6/changesets", :method => :get },
       { :controller => "changeset", :action => "query" }
     )

+    assert_routing(
+      { :path => "/changeset/1/comments/feed", :method => :get },
+      { :controller => "changeset", :action => "comments_feed", :id => "1", :format => "rss" }
+    )

     assert_routing(
       { :path => "/user/name/history", :method => :get },
       { :controller => "changeset", :action => "list", :display_name => "name" }
     assert_routing(
       { :path => "/user/name/history", :method => :get },
       { :controller => "changeset", :action => "list", :display_name => "name" }


@@ -49,11 +73,11 @@ class ChangesetControllerTest < ActionController::TestCase
     )
     assert_routing(
       { :path => "/history/friends", :method => :get },
     )
     assert_routing(
       { :path => "/history/friends", :method => :get },

-      { :controller => "changeset", :action => "list", :friends => true }
+      { :controller => "changeset", :action => "list", :friends => true, :format => :html }

     )
     assert_routing(
       { :path => "/history/nearby", :method => :get },
     )
     assert_routing(
       { :path => "/history/nearby", :method => :get },

-      { :controller => "changeset", :action => "list", :nearby => true }
+      { :controller => "changeset", :action => "list", :nearby => true, :format => :html }

     )
     assert_routing(
       { :path => "/history", :method => :get },
     )
     assert_routing(
       { :path => "/history", :method => :get },


@@ -63,6 +87,10 @@ class ChangesetControllerTest < ActionController::TestCase
       { :path => "/history/feed", :method => :get },
       { :controller => "changeset", :action => "feed", :format => :atom }
     )
       { :path => "/history/feed", :method => :get },
       { :controller => "changeset", :action => "feed", :format => :atom }
     )

+    assert_routing(
+      { :path => "/history/comments/feed", :method => :get },
+      { :controller => "changeset", :action => "comments_feed", :format => "rss" }
+    )

   end
 
   # -----------------------
   end
 
   # -----------------------


@@ -70,20 +98,19 @@ class ChangesetControllerTest < ActionController::TestCase
   # -----------------------
 
   def test_create
   # -----------------------
 
   def test_create

-    basic_authorization users(:normal_user).email, "test"
+    basic_authorization create(:user, :data_public => false).email, "test"

     # Create the first user's changeset
     content "<osm><changeset>" +
     # Create the first user's changeset
     content "<osm><changeset>" +

-      "<tag k='created_by' v='osm test suite checking changesets'/>" +
-      "</changeset></osm>"
+            "<tag k='created_by' v='osm test suite checking changesets'/>" +
+            "</changeset></osm>"

     put :create
     assert_require_public_data
 
     put :create
     assert_require_public_data
 

-
-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

     # Create the first user's changeset
     content "<osm><changeset>" +
     # Create the first user's changeset
     content "<osm><changeset>" +

-      "<tag k='created_by' v='osm test suite checking changesets'/>" +
-      "</changeset></osm>"
+            "<tag k='created_by' v='osm test suite checking changesets'/>" +
+            "</changeset></osm>"

     put :create
 
     assert_response :success, "Creation of changeset did not return sucess status"
     put :create
 
     assert_response :success, "Creation of changeset did not return sucess status"


@@ -95,21 +122,24 @@ class ChangesetControllerTest < ActionController::TestCase
     # the difference can either be a rational, or a floating point number
     # of seconds, depending on the code path taken :-(
     if duration.class == Rational
     # the difference can either be a rational, or a floating point number
     # of seconds, depending on the code path taken :-(
     if duration.class == Rational

-      assert_equal Rational(1,24), duration , "initial idle timeout should be an hour (#{cs.created_at} -> #{cs.closed_at})"
+      assert_equal Rational(1, 24), duration, "initial idle timeout should be an hour (#{cs.created_at} -> #{cs.closed_at})"

     else
       # must be number of seconds...
       assert_equal 3600, duration.round, "initial idle timeout should be an hour (#{cs.created_at} -> #{cs.closed_at})"
     end
     else
       # must be number of seconds...
       assert_equal 3600, duration.round, "initial idle timeout should be an hour (#{cs.created_at} -> #{cs.closed_at})"
     end

+
+    # checks if uploader was subscribed
+    assert_equal 1, cs.subscribers.length

   end
 
   def test_create_invalid
   end
 
   def test_create_invalid

-    basic_authorization users(:normal_user).email, "test"
+    basic_authorization create(:user, :data_public => false).email, "test"

     content "<osm><changeset></osm>"
     put :create
     assert_require_public_data
 
     ## Try the public user
     content "<osm><changeset></osm>"
     put :create
     assert_require_public_data
 
     ## Try the public user

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

     content "<osm><changeset></osm>"
     put :create
     assert_response :bad_request, "creating a invalid changeset should fail"
     content "<osm><changeset></osm>"
     put :create
     assert_response :bad_request, "creating a invalid changeset should fail"


@@ -120,24 +150,24 @@ class ChangesetControllerTest < ActionController::TestCase
     put :create
     assert_response :unauthorized, "shouldn't be able to create a changeset with no auth"
 
     put :create
     assert_response :unauthorized, "shouldn't be able to create a changeset with no auth"
 

-    ## Now try to with the non-public user
-    basic_authorization users(:normal_user).email, "test"
+    ## Now try to with a non-public user
+    basic_authorization create(:user, :data_public => false).email, "test"

     put :create
     assert_require_public_data
 
     put :create
     assert_require_public_data
 

-    ## Try the inactive user
-    basic_authorization users(:inactive_user).email, "test"
+    ## Try an inactive user
+    basic_authorization create(:user, :pending).email, "test"

     put :create
     assert_inactive_user
 
     put :create
     assert_inactive_user
 

-    ## Now try to use the public user
-    basic_authorization users(:public_user).email, "test"
+    ## Now try to use a normal user
+    basic_authorization create(:user).email, "test"

     put :create
     assert_response :bad_request, "creating a changeset with no content should fail"
   end
 
   def test_create_wrong_method
     put :create
     assert_response :bad_request, "creating a changeset with no content should fail"
   end
 
   def test_create_wrong_method

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

     get :create
     assert_response :method_not_allowed
     post :create
     get :create
     assert_response :method_not_allowed
     post :create


@@ -149,11 +179,32 @@ class ChangesetControllerTest < ActionController::TestCase
   # document structure.
   def test_read
     changeset_id = changesets(:normal_user_first_change).id
   # document structure.
   def test_read
     changeset_id = changesets(:normal_user_first_change).id

+

     get :read, :id => changeset_id
     assert_response :success, "cannot get first changeset"
 
     get :read, :id => changeset_id
     assert_response :success, "cannot get first changeset"
 

-    assert_select "osm[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1
-    assert_select "osm>changeset[id=#{changeset_id}]", 1
+    assert_select "osm[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
+    assert_select "osm>changeset[id='#{changeset_id}']", 1
+    assert_select "osm>changeset>discussion", 0
+
+    get :read, :id => changeset_id, :include_discussion => true
+    assert_response :success, "cannot get first changeset with comments"
+
+    assert_select "osm[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
+    assert_select "osm>changeset[id='#{changeset_id}']", 1
+    assert_select "osm>changeset>discussion", 1
+    assert_select "osm>changeset>discussion>comment", 0
+
+    changeset_id = changesets(:normal_user_closed_change).id
+    create_list(:changeset_comment, 3, :changeset_id => changeset_id)
+
+    get :read, :id => changeset_id, :include_discussion => true
+    assert_response :success, "cannot get closed changeset with comments"
+
+    assert_select "osm[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1
+    assert_select "osm>changeset[id='#{changeset_id}']", 1
+    assert_select "osm>changeset>discussion", 1
+    assert_select "osm>changeset>discussion>comment", 3

   end
 
   ##
   end
 
   ##


@@ -176,15 +227,13 @@ class ChangesetControllerTest < ActionController::TestCase
     put :close, :id => changesets(:public_user_first_change).id
     assert_response :unauthorized
 
     put :close, :id => changesets(:public_user_first_change).id
     assert_response :unauthorized
 

-

     ## Try using the non-public user
     ## Try using the non-public user

-    basic_authorization users(:normal_user).email, "test"
+    basic_authorization changesets(:normal_user_first_change).user.email, "test"

     put :close, :id => changesets(:normal_user_first_change).id
     assert_require_public_data
 
     put :close, :id => changesets(:normal_user_first_change).id
     assert_require_public_data
 

-

     ## The try with the public user
     ## The try with the public user

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

 
     cs_id = changesets(:public_user_first_change).id
     put :close, :id => cs_id
 
     cs_id = changesets(:public_user_first_change).id
     put :close, :id => cs_id


@@ -199,7 +248,7 @@ class ChangesetControllerTest < ActionController::TestCase
   ##
   # test that a different user can't close another user's changeset
   def test_close_invalid
   ##
   # test that a different user can't close another user's changeset
   def test_close_invalid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

 
     put :close, :id => changesets(:normal_user_first_change).id
     assert_response :conflict
 
     put :close, :id => changesets(:normal_user_first_change).id
     assert_response :conflict


@@ -209,7 +258,7 @@ class ChangesetControllerTest < ActionController::TestCase
   ##
   # test that you can't close using another method
   def test_close_method_invalid
   ##
   # test that you can't close using another method
   def test_close_method_invalid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

 
     cs_id = changesets(:public_user_first_change).id
     get :close, :id => cs_id
 
     cs_id = changesets(:public_user_first_change).id
     get :close, :id => cs_id


@@ -235,7 +284,7 @@ class ChangesetControllerTest < ActionController::TestCase
     end
 
     # Now try with auth
     end
 
     # Now try with auth

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

     cs_ids.each do |id|
       begin
         put :close, :id => id
     cs_ids.each do |id|
       begin
         put :close, :id => id


@@ -278,12 +327,10 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :unauthorized,
     content diff
     post :upload, :id => changeset_id
     assert_response :unauthorized,

-      "shouldnn't be able to upload a simple valid diff to changeset: #{@response.body}"
-
-
+                    "shouldnn't be able to upload a simple valid diff to changeset: #{@response.body}"

 
     ## Now try with a private user
 
     ## Now try with a private user

-    basic_authorization users(:normal_user).email, "test"
+    basic_authorization changesets(:normal_user_first_change).user.email, "test"

     changeset_id = changesets(:normal_user_first_change).id
 
     # simple diff to change a node, way and relation by removing
     changeset_id = changesets(:normal_user_first_change).id
 
     # simple diff to change a node, way and relation by removing


@@ -310,12 +357,10 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :forbidden,
     content diff
     post :upload, :id => changeset_id
     assert_response :forbidden,

-      "can't upload a simple valid diff to changeset: #{@response.body}"
-
-
+                    "can't upload a simple valid diff to changeset: #{@response.body}"

 
     ## Now try with the public user
 
     ## Now try with the public user

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     changeset_id = changesets(:public_user_first_change).id
 
     # simple diff to change a node, way and relation by removing
     changeset_id = changesets(:public_user_first_change).id
 
     # simple diff to change a node, way and relation by removing


@@ -342,7 +387,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "can't upload a simple valid diff to changeset: #{@response.body}"
+                    "can't upload a simple valid diff to changeset: #{@response.body}"

 
     # check that the changes made it into the database
     assert_equal 0, Node.find(1).tags.size, "node 1 should now have no tags"
 
     # check that the changes made it into the database
     assert_equal 0, Node.find(1).tags.size, "node 1 should now have no tags"


@@ -353,7 +398,7 @@ EOF
   ##
   # upload something which creates new objects using placeholders
   def test_upload_create_valid
   ##
   # upload something which creates new objects using placeholders
   def test_upload_create_valid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     cs_id = changesets(:public_user_first_change).id
 
     # simple diff to create a node way and relation using placeholders
     cs_id = changesets(:public_user_first_change).id
 
     # simple diff to create a node way and relation using placeholders


@@ -382,12 +427,12 @@ EOF
     content diff
     post :upload, :id => cs_id
     assert_response :success,
     content diff
     post :upload, :id => cs_id
     assert_response :success,

-      "can't upload a simple valid creation to changeset: #{@response.body}"
+                    "can't upload a simple valid creation to changeset: #{@response.body}"

 
     # check the returned payload
 
     # check the returned payload

-    assert_select "diffResult[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1
+    assert_select "diffResult[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1

     assert_select "diffResult>node", 1
     assert_select "diffResult>node", 1

-    assert_select "diffresult>way", 1
+    assert_select "diffResult>way", 1

     assert_select "diffResult>relation", 1
 
     # inspect the response to find out what the new element IDs are
     assert_select "diffResult>relation", 1
 
     # inspect the response to find out what the new element IDs are


@@ -416,7 +461,7 @@ EOF
   # test a complex delete where we delete elements which rely on eachother
   # in the same transaction.
   def test_upload_delete
   # test a complex delete where we delete elements which rely on eachother
   # in the same transaction.
   def test_upload_delete

-    basic_authorization users(:public_user).display_name, "test"
+    basic_authorization changesets(:public_user_first_change).user.display_name, "test"

 
     diff = XML::Document.new
     diff.root = XML::Node.new "osmChange"
 
     diff = XML::Document.new
     diff.root = XML::Node.new "osmChange"


@@ -429,9 +474,9 @@ EOF
 
     # update the changeset to one that this user owns
     changeset_id = changesets(:public_user_first_change).id
 
     # update the changeset to one that this user owns
     changeset_id = changesets(:public_user_first_change).id

-    ["node", "way", "relation"].each do |type|
+    %w(node way relation).each do |type|

       delete.find("//osmChange/delete/#{type}").each do |n|
       delete.find("//osmChange/delete/#{type}").each do |n|

-        n['changeset'] = changeset_id.to_s
+        n["changeset"] = changeset_id.to_s

       end
     end
 
       end
     end
 


@@ -439,7 +484,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "can't upload a deletion diff to changeset: #{@response.body}"
+                    "can't upload a deletion diff to changeset: #{@response.body}"

 
     # check the response is well-formed
     assert_select "diffResult>node", 1
 
     # check the response is well-formed
     assert_select "diffResult>node", 1


@@ -457,7 +502,7 @@ EOF
   # test uploading a delete with no lat/lon, as they are optional in
   # the osmChange spec.
   def test_upload_nolatlon_delete
   # test uploading a delete with no lat/lon, as they are optional in
   # the osmChange spec.
   def test_upload_nolatlon_delete

-    basic_authorization users(:public_user).display_name, "test"
+    basic_authorization changesets(:public_user_first_change).user.display_name, "test"

 
     node = current_nodes(:public_visible_node)
     cs = changesets(:public_user_first_change)
 
     node = current_nodes(:public_visible_node)
     cs = changesets(:public_user_first_change)


@@ -467,7 +512,7 @@ EOF
     content diff
     post :upload, :id => cs.id
     assert_response :success,
     content diff
     post :upload, :id => cs.id
     assert_response :success,

-      "can't upload a deletion diff to changeset: #{@response.body}"
+                    "can't upload a deletion diff to changeset: #{@response.body}"

 
     # check the response is well-formed
     assert_select "diffResult>node", 1
 
     # check the response is well-formed
     assert_select "diffResult>node", 1


@@ -478,22 +523,21 @@ EOF
 
   def test_repeated_changeset_create
     30.times do
 
   def test_repeated_changeset_create
     30.times do

-      basic_authorization users(:public_user).email, "test"
+      basic_authorization create(:user).email, "test"

 
       # create a temporary changeset
       content "<osm><changeset>" +
 
       # create a temporary changeset
       content "<osm><changeset>" +

-        "<tag k='created_by' v='osm test suite checking changesets'/>" +
-        "</changeset></osm>"
-      assert_difference('Changeset.count', 1) do
+              "<tag k='created_by' v='osm test suite checking changesets'/>" +
+              "</changeset></osm>"
+      assert_difference "Changeset.count", 1 do

         put :create
       end
       assert_response :success
         put :create
       end
       assert_response :success

-      changeset_id = @response.body.to_i

     end
   end
 
   def test_upload_large_changeset
     end
   end
 
   def test_upload_large_changeset

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

 
     # create a changeset
     content "<osm><changeset/></osm>"
 
     # create a changeset
     content "<osm><changeset/></osm>"


@@ -533,21 +577,22 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "can't upload a spatially-large diff to changeset: #{@response.body}"
+                    "can't upload a spatially-large diff to changeset: #{@response.body}"

 
     # check that the changeset bbox is within bounds
     cs = Changeset.find(changeset_id)
     assert cs.min_lon >= -180 * GeoRecord::SCALE, "Minimum longitude (#{cs.min_lon / GeoRecord::SCALE}) should be >= -180 to be valid."
 
     # check that the changeset bbox is within bounds
     cs = Changeset.find(changeset_id)
     assert cs.min_lon >= -180 * GeoRecord::SCALE, "Minimum longitude (#{cs.min_lon / GeoRecord::SCALE}) should be >= -180 to be valid."

-    assert cs.max_lon <=  180 * GeoRecord::SCALE, "Maximum longitude (#{cs.max_lon / GeoRecord::SCALE}) should be <= 180 to be valid."
-    assert cs.min_lat >=  -90 * GeoRecord::SCALE, "Minimum latitude (#{cs.min_lat / GeoRecord::SCALE}) should be >= -90 to be valid."
-    assert cs.max_lat >=   90 * GeoRecord::SCALE, "Maximum latitude (#{cs.max_lat / GeoRecord::SCALE}) should be <= 90 to be valid."
+    assert cs.max_lon <= 180 * GeoRecord::SCALE, "Maximum longitude (#{cs.max_lon / GeoRecord::SCALE}) should be <= 180 to be valid."
+    assert cs.min_lat >= -90 * GeoRecord::SCALE, "Minimum latitude (#{cs.min_lat / GeoRecord::SCALE}) should be >= -90 to be valid."
+    assert cs.max_lat >= 90 * GeoRecord::SCALE, "Maximum latitude (#{cs.max_lat / GeoRecord::SCALE}) should be <= 90 to be valid."

   end
 
   ##
   # test that deleting stuff in a transaction doesn't bypass the checks
   # to ensure that used elements are not deleted.
   def test_upload_delete_invalid
   end
 
   ##
   # test that deleting stuff in a transaction doesn't bypass the checks
   # to ensure that used elements are not deleted.
   def test_upload_delete_invalid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"
+    cs = changesets(:public_user_first_change)

 
     diff = XML::Document.new
     diff.root = XML::Node.new "osmChange"
 
     diff = XML::Document.new
     diff.root = XML::Node.new "osmChange"


@@ -559,9 +604,9 @@ EOF
 
     # upload it
     content diff
 
     # upload it
     content diff

-    post :upload, :id => 2
+    post :upload, :id => cs.id

     assert_response :precondition_failed,
     assert_response :precondition_failed,

-      "shouldn't be able to upload a invalid deletion diff: #{@response.body}"
+                    "shouldn't be able to upload a invalid deletion diff: #{@response.body}"

     assert_equal "Precondition failed: Way 3 is still used by relations 1.", @response.body
 
     # check that nothing was, in fact, deleted
     assert_equal "Precondition failed: Way 3 is still used by relations 1.", @response.body
 
     # check that nothing was, in fact, deleted


@@ -573,7 +618,8 @@ EOF
   ##
   # test that a conditional delete of an in use object works.
   def test_upload_delete_if_unused
   ##
   # test that a conditional delete of an in use object works.
   def test_upload_delete_if_unused

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"
+    cs = changesets(:public_user_first_change)

 
     diff = XML::Document.new
     diff.root = XML::Node.new "osmChange"
 
     diff = XML::Document.new
     diff.root = XML::Node.new "osmChange"


@@ -586,14 +632,14 @@ EOF
 
     # upload it
     content diff
 
     # upload it
     content diff

-    post :upload, :id => 2
+    post :upload, :id => cs.id

     assert_response :success,
     assert_response :success,

-      "can't do a conditional delete of in use objects: #{@response.body}"
+                    "can't do a conditional delete of in use objects: #{@response.body}"

 
     # check the returned payload
 
     # check the returned payload

-    assert_select "diffResult[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1
+    assert_select "diffResult[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1

     assert_select "diffResult>node", 1
     assert_select "diffResult>node", 1

-    assert_select "diffresult>way", 1
+    assert_select "diffResult>way", 1

     assert_select "diffResult>relation", 1
 
     # parse the response
     assert_select "diffResult>relation", 1
 
     # parse the response


@@ -623,7 +669,7 @@ EOF
   ##
   # upload an element with a really long tag value
   def test_upload_invalid_too_long_tag
   ##
   # upload an element with a really long tag value
   def test_upload_invalid_too_long_tag

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     cs_id = changesets(:public_user_first_change).id
 
     # simple diff to create a node way and relation using placeholders
     cs_id = changesets(:public_user_first_change).id
 
     # simple diff to create a node way and relation using placeholders


@@ -631,7 +677,7 @@ EOF
 <osmChange>
  <create>
   <node id='-1' lon='0' lat='0' changeset='#{cs_id}'>
 <osmChange>
  <create>
   <node id='-1' lon='0' lat='0' changeset='#{cs_id}'>

-   <tag k='foo' v='#{"x"*256}'/>
+   <tag k='foo' v='#{'x' * 256}'/>

   </node>
  </create>
 </osmChange>
   </node>
  </create>
 </osmChange>


@@ -641,15 +687,14 @@ EOF
     content diff
     post :upload, :id => cs_id
     assert_response :bad_request,
     content diff
     post :upload, :id => cs_id
     assert_response :bad_request,

-      "shoudln't be able to upload too long a tag to changeset: #{@response.body}"
-
+                    "shoudln't be able to upload too long a tag to changeset: #{@response.body}"

   end
 
   ##
   # upload something which creates new objects and inserts them into
   # existing containers using placeholders.
   def test_upload_complex
   end
 
   ##
   # upload something which creates new objects and inserts them into
   # existing containers using placeholders.
   def test_upload_complex

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     cs_id = changesets(:public_user_first_change).id
 
     # simple diff to create a node way and relation using placeholders
     cs_id = changesets(:public_user_first_change).id
 
     # simple diff to create a node way and relation using placeholders


@@ -679,10 +724,10 @@ EOF
     content diff
     post :upload, :id => cs_id
     assert_response :success,
     content diff
     post :upload, :id => cs_id
     assert_response :success,

-      "can't upload a complex diff to changeset: #{@response.body}"
+                    "can't upload a complex diff to changeset: #{@response.body}"

 
     # check the returned payload
 
     # check the returned payload

-    assert_select "diffResult[version=#{API_VERSION}][generator=\"#{GENERATOR}\"]", 1
+    assert_select "diffResult[version='#{API_VERSION}'][generator='#{GENERATOR}']", 1

     assert_select "diffResult>node", 1
     assert_select "diffResult>way", 1
     assert_select "diffResult>relation", 1
     assert_select "diffResult>node", 1
     assert_select "diffResult>way", 1
     assert_select "diffResult>relation", 1


@@ -694,8 +739,8 @@ EOF
     # check that the changes made it into the database
     assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
     assert_equal [new_node_id, 3], Way.find(1).nds, "way nodes should match"
     # check that the changes made it into the database
     assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
     assert_equal [new_node_id, 3], Way.find(1).nds, "way nodes should match"

-    Relation.find(1).members.each do |type,id,role|
-      if type == 'node'
+    Relation.find(1).members.each do |type, id, _role|
+      if type == "node"

         assert_equal new_node_id, id, "relation should contain new node"
       end
     end
         assert_equal new_node_id, id, "relation should contain new node"
       end
     end


@@ -705,7 +750,7 @@ EOF
   # create a diff which references several changesets, which should cause
   # a rollback and none of the diff gets committed
   def test_upload_invalid_changesets
   # create a diff which references several changesets, which should cause
   # a rollback and none of the diff gets committed
   def test_upload_invalid_changesets

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     cs_id = changesets(:public_user_first_change).id
 
     # simple diff to create a node way and relation using placeholders
     cs_id = changesets(:public_user_first_change).id
 
     # simple diff to create a node way and relation using placeholders


@@ -741,17 +786,18 @@ EOF
     content diff
     post :upload, :id => cs_id
     assert_response :conflict,
     content diff
     post :upload, :id => cs_id
     assert_response :conflict,

-      "uploading a diff with multiple changsets should have failed"
+                    "uploading a diff with multiple changsets should have failed"

 
     # check that objects are unmodified
     assert_nodes_are_equal(node, Node.find(1))
     assert_ways_are_equal(way, Way.find(1))
 
     # check that objects are unmodified
     assert_nodes_are_equal(node, Node.find(1))
     assert_ways_are_equal(way, Way.find(1))

+    assert_relations_are_equal(rel, Relation.find(1))

   end
 
   ##
   # upload multiple versions of the same element in the same diff.
   def test_upload_multiple_valid
   end
 
   ##
   # upload multiple versions of the same element in the same diff.
   def test_upload_multiple_valid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     cs_id = changesets(:public_user_first_change).id
 
     # change the location of a node multiple times, each time referencing
     cs_id = changesets(:public_user_first_change).id
 
     # change the location of a node multiple times, each time referencing


@@ -776,7 +822,7 @@ EOF
     content diff
     post :upload, :id => cs_id
     assert_response :success,
     content diff
     post :upload, :id => cs_id
     assert_response :success,

-      "can't upload multiple versions of an element in a diff: #{@response.body}"
+                    "can't upload multiple versions of an element in a diff: #{@response.body}"

 
     # check the response is well-formed. its counter-intuitive, but the
     # API will return multiple elements with the same ID and different
 
     # check the response is well-formed. its counter-intuitive, but the
     # API will return multiple elements with the same ID and different


@@ -788,7 +834,7 @@ EOF
   # upload multiple versions of the same element in the same diff, but
   # keep the version numbers the same.
   def test_upload_multiple_duplicate
   # upload multiple versions of the same element in the same diff, but
   # keep the version numbers the same.
   def test_upload_multiple_duplicate

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     cs_id = changesets(:public_user_first_change).id
 
     diff = <<EOF
     cs_id = changesets(:public_user_first_change).id
 
     diff = <<EOF


@@ -804,13 +850,13 @@ EOF
     content diff
     post :upload, :id => cs_id
     assert_response :conflict,
     content diff
     post :upload, :id => cs_id
     assert_response :conflict,

-      "shouldn't be able to upload the same element twice in a diff: #{@response.body}"
+                    "shouldn't be able to upload the same element twice in a diff: #{@response.body}"

   end
 
   ##
   # try to upload some elements without specifying the version
   def test_upload_missing_version
   end
 
   ##
   # try to upload some elements without specifying the version
   def test_upload_missing_version

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     cs_id = changesets(:public_user_first_change).id
 
     diff = <<EOF
     cs_id = changesets(:public_user_first_change).id
 
     diff = <<EOF


@@ -825,13 +871,13 @@ EOF
     content diff
     post :upload, :id => cs_id
     assert_response :bad_request,
     content diff
     post :upload, :id => cs_id
     assert_response :bad_request,

-      "shouldn't be able to upload an element without version: #{@response.body}"
+                    "shouldn't be able to upload an element without version: #{@response.body}"

   end
 
   ##
   # try to upload with commands other than create, modify, or delete
   def test_action_upload_invalid
   end
 
   ##
   # try to upload with commands other than create, modify, or delete
   def test_action_upload_invalid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     cs_id = changesets(:public_user_first_change).id
 
     diff = <<EOF
     cs_id = changesets(:public_user_first_change).id
 
     diff = <<EOF


@@ -841,17 +887,17 @@ EOF
   </ping>
 </osmChange>
 EOF
   </ping>
 </osmChange>
 EOF

-  content diff
-  post :upload, :id => cs_id
-  assert_response :bad_request, "Shouldn't be able to upload a diff with the action ping"
-  assert_equal @response.body, "Unknown action ping, choices are create, modify, delete"
+    content diff
+    post :upload, :id => cs_id
+    assert_response :bad_request, "Shouldn't be able to upload a diff with the action ping"
+    assert_equal @response.body, "Unknown action ping, choices are create, modify, delete"

   end
 
   ##
   # upload a valid changeset which has a mixture of whitespace
   # to check a bug reported by ivansanchez (#1565).
   def test_upload_whitespace_valid
   end
 
   ##
   # upload a valid changeset which has a mixture of whitespace
   # to check a bug reported by ivansanchez (#1565).
   def test_upload_whitespace_valid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF
     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF


@@ -872,7 +918,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "can't upload a valid diff with whitespace variations to changeset: #{@response.body}"
+                    "can't upload a valid diff with whitespace variations to changeset: #{@response.body}"

 
     # check the response is well-formed
     assert_select "diffResult>node", 2
 
     # check the response is well-formed
     assert_select "diffResult>node", 2


@@ -887,7 +933,7 @@ EOF
   # upload a valid changeset which has a mixture of whitespace
   # to check a bug reported by ivansanchez.
   def test_upload_reuse_placeholder_valid
   # upload a valid changeset which has a mixture of whitespace
   # to check a bug reported by ivansanchez.
   def test_upload_reuse_placeholder_valid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF
     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF


@@ -910,18 +956,18 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "can't upload a valid diff with re-used placeholders to changeset: #{@response.body}"
+                    "can't upload a valid diff with re-used placeholders to changeset: #{@response.body}"

 
     # check the response is well-formed
     assert_select "diffResult>node", 3
 
     # check the response is well-formed
     assert_select "diffResult>node", 3

-    assert_select "diffResult>node[old_id=-1]", 3
+    assert_select "diffResult>node[old_id='-1']", 3

   end
 
   ##
   # test what happens if a diff upload re-uses placeholder IDs in an
   # illegal way.
   def test_upload_placeholder_invalid
   end
 
   ##
   # test what happens if a diff upload re-uses placeholder IDs in an
   # illegal way.
   def test_upload_placeholder_invalid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF
     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF


@@ -938,14 +984,14 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,

-      "shouldn't be able to re-use placeholder IDs"
+                    "shouldn't be able to re-use placeholder IDs"

   end
 
   ##
   # test that uploading a way referencing invalid placeholders gives a
   # proper error, not a 500.
   def test_upload_placeholder_invalid_way
   end
 
   ##
   # test that uploading a way referencing invalid placeholders gives a
   # proper error, not a 500.
   def test_upload_placeholder_invalid_way

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF
     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF


@@ -968,7 +1014,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,

-      "shouldn't be able to use invalid placeholder IDs"
+                    "shouldn't be able to use invalid placeholder IDs"

     assert_equal "Placeholder node not found for reference -4 in way -1", @response.body
 
     # the same again, but this time use an existing way
     assert_equal "Placeholder node not found for reference -4 in way -1", @response.body
 
     # the same again, but this time use an existing way


@@ -992,7 +1038,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,

-      "shouldn't be able to use invalid placeholder IDs"
+                    "shouldn't be able to use invalid placeholder IDs"

     assert_equal "Placeholder node not found for reference -4 in way 1", @response.body
   end
 
     assert_equal "Placeholder node not found for reference -4 in way 1", @response.body
   end
 


@@ -1000,7 +1046,7 @@ EOF
   # test that uploading a relation referencing invalid placeholders gives a
   # proper error, not a 500.
   def test_upload_placeholder_invalid_relation
   # test that uploading a relation referencing invalid placeholders gives a
   # proper error, not a 500.
   def test_upload_placeholder_invalid_relation

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF
     changeset_id = changesets(:public_user_first_change).id
 
     diff = <<EOF


@@ -1023,7 +1069,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,

-      "shouldn't be able to use invalid placeholder IDs"
+                    "shouldn't be able to use invalid placeholder IDs"

     assert_equal "Placeholder Node not found for reference -4 in relation -1.", @response.body
 
     # the same again, but this time use an existing way
     assert_equal "Placeholder Node not found for reference -4 in relation -1.", @response.body
 
     # the same again, but this time use an existing way


@@ -1047,7 +1093,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,
     content diff
     post :upload, :id => changeset_id
     assert_response :bad_request,

-      "shouldn't be able to use invalid placeholder IDs"
+                    "shouldn't be able to use invalid placeholder IDs"

     assert_equal "Placeholder Way not found for reference -1 in relation 1.", @response.body
   end
 
     assert_equal "Placeholder Way not found for reference -1 in relation 1.", @response.body
   end
 


@@ -1055,11 +1101,11 @@ EOF
   # test what happens if a diff is uploaded containing only a node
   # move.
   def test_upload_node_move
   # test what happens if a diff is uploaded containing only a node
   # move.
   def test_upload_node_move

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

 
     content "<osm><changeset>" +
 
     content "<osm><changeset>" +

-      "<tag k='created_by' v='osm test suite checking changesets'/>" +
-      "</changeset></osm>"
+            "<tag k='created_by' v='osm test suite checking changesets'/>" +
+            "</changeset></osm>"

     put :create
     assert_response :success
     changeset_id = @response.body.to_i
     put :create
     assert_response :success
     changeset_id = @response.body.to_i


@@ -1070,8 +1116,8 @@ EOF
     diff.root = XML::Node.new "osmChange"
     modify = XML::Node.new "modify"
     xml_old_node = old_node.to_xml_node
     diff.root = XML::Node.new "osmChange"
     modify = XML::Node.new "modify"
     xml_old_node = old_node.to_xml_node

-    xml_old_node["lat"] = (2.0).to_s
-    xml_old_node["lon"] = (2.0).to_s
+    xml_old_node["lat"] = 2.0.to_s
+    xml_old_node["lon"] = 2.0.to_s

     xml_old_node["changeset"] = changeset_id.to_s
     modify << xml_old_node
     diff.root << modify
     xml_old_node["changeset"] = changeset_id.to_s
     modify << xml_old_node
     diff.root << modify


@@ -1080,24 +1126,24 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "diff should have uploaded OK"
+                    "diff should have uploaded OK"

 
     # check the bbox
     changeset = Changeset.find(changeset_id)
 
     # check the bbox
     changeset = Changeset.find(changeset_id)

-    assert_equal 1*GeoRecord::SCALE, changeset.min_lon, "min_lon should be 1 degree"
-    assert_equal 2*GeoRecord::SCALE, changeset.max_lon, "max_lon should be 2 degrees"
-    assert_equal 1*GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1 degree"
-    assert_equal 2*GeoRecord::SCALE, changeset.max_lat, "max_lat should be 2 degrees"
+    assert_equal 1 * GeoRecord::SCALE, changeset.min_lon, "min_lon should be 1 degree"
+    assert_equal 2 * GeoRecord::SCALE, changeset.max_lon, "max_lon should be 2 degrees"
+    assert_equal 1 * GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1 degree"
+    assert_equal 2 * GeoRecord::SCALE, changeset.max_lat, "max_lat should be 2 degrees"

   end
 
   ##
   # test what happens if a diff is uploaded adding a node to a way.
   def test_upload_way_extend
   end
 
   ##
   # test what happens if a diff is uploaded adding a node to a way.
   def test_upload_way_extend

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

 
     content "<osm><changeset>" +
 
     content "<osm><changeset>" +

-      "<tag k='created_by' v='osm test suite checking changesets'/>" +
-      "</changeset></osm>"
+            "<tag k='created_by' v='osm test suite checking changesets'/>" +
+            "</changeset></osm>"

     put :create
     assert_response :success
     changeset_id = @response.body.to_i
     put :create
     assert_response :success
     changeset_id = @response.body.to_i


@@ -1119,26 +1165,25 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "diff should have uploaded OK"
+                    "diff should have uploaded OK"

 
     # check the bbox
     changeset = Changeset.find(changeset_id)
 
     # check the bbox
     changeset = Changeset.find(changeset_id)

-    assert_equal 1*GeoRecord::SCALE, changeset.min_lon, "min_lon should be 1 degree"
-    assert_equal 3*GeoRecord::SCALE, changeset.max_lon, "max_lon should be 3 degrees"
-    assert_equal 1*GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1 degree"
-    assert_equal 3*GeoRecord::SCALE, changeset.max_lat, "max_lat should be 3 degrees"
+    assert_equal 1 * GeoRecord::SCALE, changeset.min_lon, "min_lon should be 1 degree"
+    assert_equal 3 * GeoRecord::SCALE, changeset.max_lon, "max_lon should be 3 degrees"
+    assert_equal 1 * GeoRecord::SCALE, changeset.min_lat, "min_lat should be 1 degree"
+    assert_equal 3 * GeoRecord::SCALE, changeset.max_lat, "max_lat should be 3 degrees"

   end
 
   ##
   # test for more issues in #1568
   def test_upload_empty_invalid
   end
 
   ##
   # test for more issues in #1568
   def test_upload_empty_invalid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"

 
 

-    [ "<osmChange/>",
-      "<osmChange></osmChange>",
-      "<osmChange><modify/></osmChange>",
-      "<osmChange><modify></modify></osmChange>"
-    ].each do |diff|
+    ["<osmChange/>",
+     "<osmChange></osmChange>",
+     "<osmChange><modify/></osmChange>",
+     "<osmChange><modify></modify></osmChange>"].each do |diff|

       # upload it
       content diff
       post :upload, :id => changesets(:public_user_first_change).id
       # upload it
       content diff
       post :upload, :id => changesets(:public_user_first_change).id


@@ -1150,7 +1195,8 @@ EOF
   ##
   # test that the X-Error-Format header works to request XML errors
   def test_upload_xml_errors
   ##
   # test that the X-Error-Format header works to request XML errors
   def test_upload_xml_errors

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changesets(:public_user_first_change).user.email, "test"
+    cs = changesets(:public_user_first_change)

 
     # try and delete a node that is in use
     diff = XML::Document.new
 
     # try and delete a node that is in use
     diff = XML::Document.new


@@ -1162,40 +1208,37 @@ EOF
     # upload it
     content diff
     error_format "xml"
     # upload it
     content diff
     error_format "xml"

-    post :upload, :id => 2
+    post :upload, :id => cs.id

     assert_response :success,
     assert_response :success,

-      "failed to return error in XML format"
+                    "failed to return error in XML format"

 
     # check the returned payload
 
     # check the returned payload

-    assert_select "osmError[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1
+    assert_select "osmError[version='#{API_VERSION}'][generator='OpenStreetMap server']", 1

     assert_select "osmError>status", 1
     assert_select "osmError>message", 1
     assert_select "osmError>status", 1
     assert_select "osmError>message", 1

-

   end
 
   ##
   # when we make some simple changes we get the same changes back from the
   # diff download.
   def test_diff_download_simple
   end
 
   ##
   # when we make some simple changes we get the same changes back from the
   # diff download.
   def test_diff_download_simple

-    ## First try with the normal user, which should get a forbidden
-    basic_authorization(users(:normal_user).email, "test")
+    ## First try with a non-public user, which should get a forbidden
+    basic_authorization(create(:user, :data_public => false).email, "test")

 
     # create a temporary changeset
     content "<osm><changeset>" +
 
     # create a temporary changeset
     content "<osm><changeset>" +

-      "<tag k='created_by' v='osm test suite checking changesets'/>" +
-      "</changeset></osm>"
+            "<tag k='created_by' v='osm test suite checking changesets'/>" +
+            "</changeset></osm>"

     put :create
     assert_response :forbidden
 
     put :create
     assert_response :forbidden
 

-
-
-    ## Now try with the public user
-    basic_authorization(users(:public_user).email, "test")
+    ## Now try with a normal user
+    basic_authorization(create(:user).email, "test")

 
     # create a temporary changeset
     content "<osm><changeset>" +
 
     # create a temporary changeset
     content "<osm><changeset>" +

-      "<tag k='created_by' v='osm test suite checking changesets'/>" +
-      "</changeset></osm>"
+            "<tag k='created_by' v='osm test suite checking changesets'/>" +
+            "</changeset></osm>"

     put :create
     assert_response :success
     changeset_id = @response.body.to_i
     put :create
     assert_response :success
     changeset_id = @response.body.to_i


@@ -1220,7 +1263,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "can't upload multiple versions of an element in a diff: #{@response.body}"
+                    "can't upload multiple versions of an element in a diff: #{@response.body}"

 
     get :download, :id => changeset_id
     assert_response :success
 
     get :download, :id => changeset_id
     assert_response :success


@@ -1236,12 +1279,12 @@ EOF
   #
   # NOTE: the error turned out to be something else completely!
   def test_josm_upload
   #
   # NOTE: the error turned out to be something else completely!
   def test_josm_upload

-    basic_authorization(users(:public_user).email, "test")
+    basic_authorization(create(:user).email, "test")

 
     # create a temporary changeset
     content "<osm><changeset>" +
 
     # create a temporary changeset
     content "<osm><changeset>" +

-      "<tag k='created_by' v='osm test suite checking changesets'/>" +
-      "</changeset></osm>"
+            "<tag k='created_by' v='osm test suite checking changesets'/>" +
+            "</changeset></osm>"

     put :create
     assert_response :success
     changeset_id = @response.body.to_i
     put :create
     assert_response :success
     changeset_id = @response.body.to_i


@@ -1279,7 +1322,7 @@ OSMFILE
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "can't upload a diff from JOSM: #{@response.body}"
+                    "can't upload a diff from JOSM: #{@response.body}"

 
     get :download, :id => changeset_id
     assert_response :success
 
     get :download, :id => changeset_id
     assert_response :success


@@ -1295,12 +1338,12 @@ OSMFILE
   # when we make some complex changes we get the same changes back from the
   # diff download.
   def test_diff_download_complex
   # when we make some complex changes we get the same changes back from the
   # diff download.
   def test_diff_download_complex

-    basic_authorization(users(:public_user).email, "test")
+    basic_authorization(create(:user).email, "test")

 
     # create a temporary changeset
     content "<osm><changeset>" +
 
     # create a temporary changeset
     content "<osm><changeset>" +

-      "<tag k='created_by' v='osm test suite checking changesets'/>" +
-      "</changeset></osm>"
+            "<tag k='created_by' v='osm test suite checking changesets'/>" +
+            "</changeset></osm>"

     put :create
     assert_response :success
     changeset_id = @response.body.to_i
     put :create
     assert_response :success
     changeset_id = @response.body.to_i


@@ -1332,7 +1375,7 @@ EOF
     content diff
     post :upload, :id => changeset_id
     assert_response :success,
     content diff
     post :upload, :id => changeset_id
     assert_response :success,

-      "can't upload multiple versions of an element in a diff: #{@response.body}"
+                    "can't upload multiple versions of an element in a diff: #{@response.body}"

 
     get :download, :id => changeset_id
     assert_response :success
 
     get :download, :id => changeset_id
     assert_response :success


@@ -1348,25 +1391,28 @@ EOF
   end
 
   def test_changeset_download
   end
 
   def test_changeset_download

+    tag = create(:old_node_tag, :old_node => nodes(:used_node_2))
+

     get :download, :id => changesets(:normal_user_first_change).id
     get :download, :id => changesets(:normal_user_first_change).id

+

     assert_response :success
     assert_template nil
     assert_response :success
     assert_template nil

-    #print @response.body
-    # FIXME needs more assert_select tests
+    # print @response.body
+    # FIXME: needs more assert_select tests

     assert_select "osmChange[version='#{API_VERSION}'][generator='#{GENERATOR}']" do
       assert_select "create", :count => 5
     assert_select "osmChange[version='#{API_VERSION}'][generator='#{GENERATOR}']" do
       assert_select "create", :count => 5

-      assert_select "create>node[id=#{nodes(:used_node_2).node_id}][visible=#{nodes(:used_node_2).visible?}][version=#{nodes(:used_node_2).version}]" do
-        assert_select "tag[k=#{node_tags(:t3).k}][v=#{node_tags(:t3).v}]"
+      assert_select "create>node[id='#{nodes(:used_node_2).node_id}'][visible='#{nodes(:used_node_2).visible?}'][version='#{nodes(:used_node_2).version}']" do
+        assert_select "tag[k='#{tag.k}'][v='#{tag.v}']"

       end
       end

-      assert_select "create>node[id=#{nodes(:visible_node).node_id}]"
+      assert_select "create>node[id='#{nodes(:visible_node).node_id}']"

     end
   end
 
   ##
   # check that the bounding box of a changeset gets updated correctly
     end
   end
 
   ##
   # check that the bounding box of a changeset gets updated correctly

-  ## FIXME: This should really be moded to a integration test due to the with_controller
+  # FIXME: This should really be moded to a integration test due to the with_controller

   def test_changeset_bbox
   def test_changeset_bbox

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

 
     # create a new changeset
     content "<osm><changeset/></osm>"
 
     # create a new changeset
     content "<osm><changeset/></osm>"


@@ -1384,10 +1430,10 @@ EOF
     # get the bounding box back from the changeset
     get :read, :id => changeset_id
     assert_response :success, "Couldn't read back changeset."
     # get the bounding box back from the changeset
     get :read, :id => changeset_id
     assert_response :success, "Couldn't read back changeset."

-    assert_select "osm>changeset[min_lon=1.0]", 1
-    assert_select "osm>changeset[max_lon=1.0]", 1
-    assert_select "osm>changeset[min_lat=2.0]", 1
-    assert_select "osm>changeset[max_lat=2.0]", 1
+    assert_select "osm>changeset[min_lon='1.0']", 1
+    assert_select "osm>changeset[max_lon='1.0']", 1
+    assert_select "osm>changeset[min_lat='2.0']", 1
+    assert_select "osm>changeset[max_lat='2.0']", 1

 
     # add another node to it
     with_controller(NodeController.new) do
 
     # add another node to it
     with_controller(NodeController.new) do


@@ -1399,10 +1445,10 @@ EOF
     # get the bounding box back from the changeset
     get :read, :id => changeset_id
     assert_response :success, "Couldn't read back changeset for the second time."
     # get the bounding box back from the changeset
     get :read, :id => changeset_id
     assert_response :success, "Couldn't read back changeset for the second time."

-    assert_select "osm>changeset[min_lon=1.0]", 1
-    assert_select "osm>changeset[max_lon=2.0]", 1
-    assert_select "osm>changeset[min_lat=1.0]", 1
-    assert_select "osm>changeset[max_lat=2.0]", 1
+    assert_select "osm>changeset[min_lon='1.0']", 1
+    assert_select "osm>changeset[max_lon='2.0']", 1
+    assert_select "osm>changeset[min_lat='1.0']", 1
+    assert_select "osm>changeset[max_lat='2.0']", 1

 
     # add (delete) a way to it, which contains a point at (3,3)
     with_controller(WayController.new) do
 
     # add (delete) a way to it, which contains a point at (3,3)
     with_controller(WayController.new) do


@@ -1416,16 +1462,16 @@ EOF
     get :read, :id => changeset_id
     assert_response :success, "Couldn't read back changeset for the third time."
     # note that the 3.1 here is because of the bbox overexpansion
     get :read, :id => changeset_id
     assert_response :success, "Couldn't read back changeset for the third time."
     # note that the 3.1 here is because of the bbox overexpansion

-    assert_select "osm>changeset[min_lon=1.0]", 1
-    assert_select "osm>changeset[max_lon=3.1]", 1
-    assert_select "osm>changeset[min_lat=1.0]", 1
-    assert_select "osm>changeset[max_lat=3.1]", 1
+    assert_select "osm>changeset[min_lon='1.0']", 1
+    assert_select "osm>changeset[max_lon='3.1']", 1
+    assert_select "osm>changeset[min_lat='1.0']", 1
+    assert_select "osm>changeset[max_lat='3.1']", 1

   end
 
   ##
   # test that the changeset :include method works as it should
   def test_changeset_include
   end
 
   ##
   # test that the changeset :include method works as it should
   def test_changeset_include

-    basic_authorization users(:public_user).display_name, "test"
+    basic_authorization create(:user).display_name, "test"

 
     # create a new changeset
     content "<osm><changeset/></osm>"
 
     # create a new changeset
     content "<osm><changeset/></osm>"


@@ -1436,18 +1482,18 @@ EOF
     # NOTE: the include method doesn't over-expand, like inserting
     # a real method does. this is because we expect the client to
     # know what it is doing!
     # NOTE: the include method doesn't over-expand, like inserting
     # a real method does. this is because we expect the client to
     # know what it is doing!

-    check_after_include(changeset_id,  1,  1, [ 1,  1,  1,  1])
-    check_after_include(changeset_id,  3,  3, [ 1,  1,  3,  3])
-    check_after_include(changeset_id,  4,  2, [ 1,  1,  4,  3])
-    check_after_include(changeset_id,  2,  2, [ 1,  1,  4,  3])
-    check_after_include(changeset_id, -1, -1, [-1, -1,  4,  3])
-    check_after_include(changeset_id, -2,  5, [-2, -1,  4,  5])
+    check_after_include(changeset_id, 1, 1, [1, 1, 1, 1])
+    check_after_include(changeset_id, 3, 3, [1, 1, 3, 3])
+    check_after_include(changeset_id, 4, 2, [1, 1, 4, 3])
+    check_after_include(changeset_id, 2, 2, [1, 1, 4, 3])
+    check_after_include(changeset_id, -1, -1, [-1, -1, 4, 3])
+    check_after_include(changeset_id, -2, 5, [-2, -1, 4, 5])

   end
 
   ##
   # test that a not found, wrong method with the expand bbox works as expected
   def test_changeset_expand_bbox_error
   end
 
   ##
   # test that a not found, wrong method with the expand bbox works as expected
   def test_changeset_expand_bbox_error

-    basic_authorization users(:public_user).display_name, "test"
+    basic_authorization create(:user).display_name, "test"

 
     # create a new changeset
     content "<osm><changeset/></osm>"
 
     # create a new changeset
     content "<osm><changeset/></osm>"


@@ -1455,8 +1501,8 @@ EOF
     assert_response :success, "Creating of changeset failed."
     changeset_id = @response.body.to_i
 
     assert_response :success, "Creating of changeset failed."
     changeset_id = @response.body.to_i
 

-    lon=58.2
-    lat=-0.45
+    lon = 58.2
+    lat = -0.45

 
     # Try and put
     content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"
 
     # Try and put
     content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"


@@ -1470,9 +1516,8 @@ EOF
 
     # Try to use a hopefully missing changeset
     content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"
 
     # Try to use a hopefully missing changeset
     content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"

-    post :expand_bbox, :id => changeset_id+13245
+    post :expand_bbox, :id => changeset_id + 13245

     assert_response :not_found, "shouldn't be able to do a bbox expand on a nonexistant changeset"
     assert_response :not_found, "shouldn't be able to do a bbox expand on a nonexistant changeset"

-

   end
 
   ##
   end
 
   ##


@@ -1480,7 +1525,7 @@ EOF
   def test_query
     get :query, :bbox => "-10,-10, 10, 10"
     assert_response :success, "can't get changesets in bbox"
   def test_query
     get :query, :bbox => "-10,-10, 10, 10"
     assert_response :success, "can't get changesets in bbox"

-    assert_changesets [1,4,6]
+    assert_changesets [1, 4, 6]

 
     get :query, :bbox => "4.5,4.5,4.6,4.6"
     assert_response :success, "can't get changesets in bbox"
 
     get :query, :bbox => "4.5,4.5,4.6,4.6"
     assert_response :success, "can't get changesets in bbox"


@@ -1502,11 +1547,11 @@ EOF
     basic_authorization "test@openstreetmap.org", "test"
     get :query, :user => users(:normal_user).id
     assert_response :success, "can't get changesets by user ID"
     basic_authorization "test@openstreetmap.org", "test"
     get :query, :user => users(:normal_user).id
     assert_response :success, "can't get changesets by user ID"

-    assert_changesets [1,3,6]
+    assert_changesets [1, 3, 6, 8]

 
     get :query, :display_name => users(:normal_user).display_name
     assert_response :success, "can't get changesets by user name"
 
     get :query, :display_name => users(:normal_user).display_name
     assert_response :success, "can't get changesets by user name"

-    assert_changesets [1,3,6]
+    assert_changesets [1, 3, 6, 8]

 
     # check that the correct error is given when we provide both UID and name
     get :query, :user => users(:normal_user).id, :display_name => users(:normal_user).display_name
 
     # check that the correct error is given when we provide both UID and name
     get :query, :user => users(:normal_user).id, :display_name => users(:normal_user).display_name


@@ -1516,39 +1561,39 @@ EOF
     assert_response :success, "can't get changesets by user and open"
     assert_changesets [1]
 
     assert_response :success, "can't get changesets by user and open"
     assert_changesets [1]
 

-    get :query, :time => '2007-12-31'
+    get :query, :time => "2007-12-31"

     assert_response :success, "can't get changesets by time-since"
     assert_response :success, "can't get changesets by time-since"

-    assert_changesets [1,2,4,5,6]
+    assert_changesets [1, 2, 4, 5, 6]

 
 

-    get :query, :time => '2008-01-01T12:34Z'
+    get :query, :time => "2008-01-01T12:34Z"

     assert_response :success, "can't get changesets by time-since with hour"
     assert_response :success, "can't get changesets by time-since with hour"

-    assert_changesets [1,2,4,5,6]
+    assert_changesets [1, 2, 4, 5, 6]

 
 

-    get :query, :time => '2007-12-31T23:59Z,2008-01-01T00:01Z'
+    get :query, :time => "2007-12-31T23:59Z,2008-01-01T00:01Z"

     assert_response :success, "can't get changesets by time-range"
     assert_response :success, "can't get changesets by time-range"

-    assert_changesets [1,5,6]
+    assert_changesets [1, 5, 6]

 
 

-    get :query, :open => 'true'
+    get :query, :open => "true"

     assert_response :success, "can't get changesets by open-ness"
     assert_response :success, "can't get changesets by open-ness"

-    assert_changesets [1,2,4]
+    assert_changesets [1, 2, 4]

 
 

-    get :query, :closed => 'true'
+    get :query, :closed => "true"

     assert_response :success, "can't get changesets by closed-ness"
     assert_response :success, "can't get changesets by closed-ness"

-    assert_changesets [3,5,6,7]
+    assert_changesets [3, 5, 6, 7, 8, 9]

 
 

-    get :query, :closed => 'true', :user => users(:normal_user).id
+    get :query, :closed => "true", :user => users(:normal_user).id

     assert_response :success, "can't get changesets by closed-ness and user"
     assert_response :success, "can't get changesets by closed-ness and user"

-    assert_changesets [3,6]
+    assert_changesets [3, 6, 8]

 
 

-    get :query, :closed => 'true', :user => users(:public_user).id
+    get :query, :closed => "true", :user => users(:public_user).id

     assert_response :success, "can't get changesets by closed-ness and user"
     assert_changesets [7]
 
     assert_response :success, "can't get changesets by closed-ness and user"
     assert_changesets [7]
 

-    get :query, :changesets => '1,2,3'
+    get :query, :changesets => "1,2,3"

     assert_response :success, "can't get changesets by id (as comma-separated string)"
     assert_response :success, "can't get changesets by id (as comma-separated string)"

-    assert_changesets [1,2,3]
+    assert_changesets [1, 2, 3]

 
 

-    get :query, :changesets => ''
+    get :query, :changesets => ""

     assert_response :bad_request, "should be a bad request since changesets is empty"
   end
 
     assert_response :bad_request, "should be a bad request since changesets is empty"
   end
 


@@ -1556,29 +1601,26 @@ EOF
   # check that errors are returned if garbage is inserted
   # into query strings
   def test_query_invalid
   # check that errors are returned if garbage is inserted
   # into query strings
   def test_query_invalid

-    [ "abracadabra!",
-      "1,2,3,F",
-      ";drop table users;"
-      ].each do |bbox|
+    ["abracadabra!",
+     "1,2,3,F",
+     ";drop table users;"].each do |bbox|

       get :query, :bbox => bbox
       assert_response :bad_request, "'#{bbox}' isn't a bbox"
     end
 
       get :query, :bbox => bbox
       assert_response :bad_request, "'#{bbox}' isn't a bbox"
     end
 

-    [ "now()",
-      "00-00-00",
-      ";drop table users;",
-      ",",
-      "-,-"
-      ].each do |time|
+    ["now()",
+     "00-00-00",
+     ";drop table users;",
+     ",",
+     "-,-"].each do |time|

       get :query, :time => time
       assert_response :bad_request, "'#{time}' isn't a valid time range"
     end
 
       get :query, :time => time
       assert_response :bad_request, "'#{time}' isn't a valid time range"
     end
 

-    [ "me",
-      "foobar",
-      "-1",
-      "0"
-      ].each do |uid|
+    ["me",
+     "foobar",
+     "-1",
+     "0"].each do |uid|

       get :query, :user => uid
       assert_response :bad_request, "'#{uid}' isn't a valid user ID"
     end
       get :query, :user => uid
       assert_response :bad_request, "'#{uid}' isn't a valid user ID"
     end


@@ -1587,12 +1629,12 @@ EOF
   ##
   # check updating tags on a changeset
   def test_changeset_update
   ##
   # check updating tags on a changeset
   def test_changeset_update

-    ## First try with the non-public user
+    ## First try with a non-public user

     changeset = changesets(:normal_user_first_change)
     new_changeset = changeset.to_xml
     new_tag = XML::Node.new "tag"
     changeset = changesets(:normal_user_first_change)
     new_changeset = changeset.to_xml
     new_tag = XML::Node.new "tag"

-    new_tag['k'] = "tagtesting"
-    new_tag['v'] = "valuetesting"
+    new_tag["k"] = "tagtesting"
+    new_tag["v"] = "valuetesting"

     new_changeset.find("//osm/changeset").first << new_tag
     content new_changeset
 
     new_changeset.find("//osm/changeset").first << new_tag
     content new_changeset
 


@@ -1601,22 +1643,22 @@ EOF
     assert_response :unauthorized
 
     # try with the wrong authorization
     assert_response :unauthorized
 
     # try with the wrong authorization

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

     put :update, :id => changeset.id
     assert_response :conflict
 
     # now this should get an unauthorized
     put :update, :id => changeset.id
     assert_response :conflict
 
     # now this should get an unauthorized

-    basic_authorization users(:normal_user).email, "test"
+    basic_authorization changeset.user.email, "test"

     put :update, :id => changeset.id
     assert_require_public_data "user with their data non-public, shouldn't be able to edit their changeset"
 
     put :update, :id => changeset.id
     assert_require_public_data "user with their data non-public, shouldn't be able to edit their changeset"
 

-

     ## Now try with the public user
     changeset = changesets(:public_user_first_change)
     ## Now try with the public user
     changeset = changesets(:public_user_first_change)

+    create(:changeset_tag, :changeset => changeset)

     new_changeset = changeset.to_xml
     new_tag = XML::Node.new "tag"
     new_changeset = changeset.to_xml
     new_tag = XML::Node.new "tag"

-    new_tag['k'] = "tagtesting"
-    new_tag['v'] = "valuetesting"
+    new_tag["k"] = "tagtesting"
+    new_tag["v"] = "valuetesting"

     new_changeset.find("//osm/changeset").first << new_tag
     content new_changeset
 
     new_changeset.find("//osm/changeset").first << new_tag
     content new_changeset
 


@@ -1626,31 +1668,31 @@ EOF
     assert_response :unauthorized
 
     # try with the wrong authorization
     assert_response :unauthorized
 
     # try with the wrong authorization

-    basic_authorization users(:second_public_user).email, "test"
+    basic_authorization create(:user).email, "test"

     put :update, :id => changeset.id
     assert_response :conflict
 
     # now this should work...
     put :update, :id => changeset.id
     assert_response :conflict
 
     # now this should work...

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization changeset.user.email, "test"

     put :update, :id => changeset.id
     assert_response :success
 
     put :update, :id => changeset.id
     assert_response :success
 

-    assert_select "osm>changeset[id=#{changeset.id}]", 1
+    assert_select "osm>changeset[id='#{changeset.id}']", 1

     assert_select "osm>changeset>tag", 2
     assert_select "osm>changeset>tag", 2

-    assert_select "osm>changeset>tag[k=tagtesting][v=valuetesting]", 1
+    assert_select "osm>changeset>tag[k='tagtesting'][v='valuetesting']", 1

   end
 
   ##
   # check that a user different from the one who opened the changeset
   # can't modify it.
   def test_changeset_update_invalid
   end
 
   ##
   # check that a user different from the one who opened the changeset
   # can't modify it.
   def test_changeset_update_invalid

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

 
     changeset = changesets(:normal_user_first_change)
     new_changeset = changeset.to_xml
     new_tag = XML::Node.new "tag"
 
     changeset = changesets(:normal_user_first_change)
     new_changeset = changeset.to_xml
     new_tag = XML::Node.new "tag"

-    new_tag['k'] = "testing"
-    new_tag['v'] = "testing"
+    new_tag["k"] = "testing"
+    new_tag["v"] = "testing"

     new_changeset.find("//osm/changeset").first << new_tag
 
     content new_changeset
     new_changeset.find("//osm/changeset").first << new_tag
 
     content new_changeset


@@ -1662,7 +1704,7 @@ EOF
   # check that a changeset can contain a certain max number of changes.
   ## FIXME should be changed to an integration test due to the with_controller
   def test_changeset_limits
   # check that a changeset can contain a certain max number of changes.
   ## FIXME should be changed to an integration test due to the with_controller
   def test_changeset_limits

-    basic_authorization users(:public_user).email, "test"
+    basic_authorization create(:user).email, "test"

 
     # open a new changeset
     content "<osm><changeset/></osm>"
 
     # open a new changeset
     content "<osm><changeset/></osm>"


@@ -1692,9 +1734,9 @@ EOF
 
       # loop until we fill the changeset with nodes
       offset.times do |i|
 
       # loop until we fill the changeset with nodes
       offset.times do |i|

-        node_xml['lat'] = rand.to_s
-        node_xml['lon'] = rand.to_s
-        node_xml['version'] = (i+1).to_s
+        node_xml["lat"] = rand.to_s
+        node_xml["lon"] = rand.to_s
+        node_xml["version"] = (i + 1).to_s

 
         content node_doc
         put :update, :id => node_id
 
         content node_doc
         put :update, :id => node_id


@@ -1702,9 +1744,9 @@ EOF
       end
 
       # trying again should fail
       end
 
       # trying again should fail

-      node_xml['lat'] = rand.to_s
-      node_xml['lon'] = rand.to_s
-      node_xml['version'] = offset.to_s
+      node_xml["lat"] = rand.to_s
+      node_xml["lon"] = rand.to_s
+      node_xml["version"] = offset.to_s

 
       content node_doc
       put :update, :id => node_id
 
       content node_doc
       put :update, :id => node_id


@@ -1721,109 +1763,207 @@ EOF
   end
 
   ##
   end
 
   ##

-  # This should display the last 20 changesets closed.
+  # This should display the last 20 changesets closed

   def test_list
   def test_list

-    get :list, {:format => "html"}
+    get :list, :format => "html"

     assert_response :success
     assert_template "history"
     assert_template :layout => "map"
     assert_select "h2", :text => "Changesets", :count => 1
 
     assert_response :success
     assert_template "history"
     assert_template :layout => "map"
     assert_select "h2", :text => "Changesets", :count => 1
 

-    get :list, {:format => "html", :list => '1', :bbox => '-180,-90,90,180'}
+    xhr :get, :list, :format => "html", :list => "1"

     assert_response :success
     assert_template "list"
 
     assert_response :success
     assert_template "list"
 

-    changesets = Changeset.
-        where("num_changes > 0 and min_lon is not null").
-        order(:created_at => :desc).
-        limit(20)
-    assert changesets.size <= 20
-
-    # Now check that all 20 (or however many were returned) changesets are in the html
-    assert_select "li", :count => changesets.size
-    changesets.each do |changeset|
-      # FIXME this test needs rewriting - test for table contents
-    end
+    check_list_result(Changeset.all)

   end
 
   ##
   end
 
   ##

-  # This should display the last 20 changesets closed.
+  # This should display the last 20 changesets closed

   def test_list_xhr
   def test_list_xhr

-    xhr :get, :list, {:format => "html"}
+    xhr :get, :list, :format => "html"

     assert_response :success
     assert_template "history"
     assert_template :layout => "xhr"
     assert_select "h2", :text => "Changesets", :count => 1
 
     assert_response :success
     assert_template "history"
     assert_template :layout => "xhr"
     assert_select "h2", :text => "Changesets", :count => 1
 

-    get :list, {:format => "html", :list => '1', :bbox => '-180,-90,90,180'}
+    xhr :get, :list, :format => "html", :list => "1"

     assert_response :success
     assert_template "list"
 
     assert_response :success
     assert_template "list"
 

-    changesets = Changeset.
-        where("num_changes > 0 and min_lon is not null").
-        order(:created_at => :desc).
-        limit(20)
-    assert changesets.size <= 20
+    check_list_result(Changeset.all)
+  end

 
 

-    # Now check that all 20 (or however many were returned) changesets are in the html
-    assert_select "li", :count => changesets.size
-    changesets.each do |changeset|
-      # FIXME this test needs rewriting - test for table contents
-    end
+  ##
+  # This should display the last 20 changesets closed in a specific area
+  def test_list_bbox
+    get :list, :format => "html", :bbox => "4.5,4.5,5.5,5.5"
+    assert_response :success
+    assert_template "history"
+    assert_template :layout => "map"
+    assert_select "h2", :text => "Changesets", :count => 1
+
+    xhr :get, :list, :format => "html", :bbox => "4.5,4.5,5.5,5.5", :list => "1"
+    assert_response :success
+    assert_template "list"
+
+    check_list_result(Changeset.where("min_lon < 55000000 and max_lon > 45000000 and min_lat < 55000000 and max_lat > 45000000"))

   end
 
   ##
   # Checks the display of the user changesets listing
   def test_list_user
     user = users(:public_user)
   end
 
   ##
   # Checks the display of the user changesets listing
   def test_list_user
     user = users(:public_user)

-    get :list, {:format => "html", :display_name => user.display_name}
+
+    get :list, :format => "html", :display_name => user.display_name

     assert_response :success
     assert_template "history"
     assert_response :success
     assert_template "history"

-    ## FIXME need to add more checks to see which if edits are actually shown if your data is public
+
+    xhr :get, :list, :format => "html", :display_name => user.display_name, :list => "1"
+    assert_response :success
+    assert_template "list"
+
+    check_list_result(user.changesets)
+  end
+
+  ##
+  # Checks the display of the user changesets listing for a private user
+  def test_list_private_user
+    user = users(:normal_user)
+
+    get :list, :format => "html", :display_name => user.display_name
+    assert_response :success
+    assert_template "history"
+
+    xhr :get, :list, :format => "html", :display_name => user.display_name, :list => "1"
+    assert_response :success
+    assert_template "list"
+
+    check_list_result(Changeset.none)

   end
 
   ##
   # Check the not found of the list user changesets
   def test_list_user_not_found
   end
 
   ##
   # Check the not found of the list user changesets
   def test_list_user_not_found

-    get :list, {:format => "html", :display_name => "Some random user"}
+    get :list, :format => "html", :display_name => "Some random user"

     assert_response :not_found
     assert_response :not_found

-    assert_template 'user/no_such_user'
+    assert_template "user/no_such_user"
+
+    xhr :get, :list, :format => "html", :display_name => "Some random user", :list => "1"
+    assert_response :not_found
+    assert_template "user/no_such_user"
+  end
+
+  ##
+  # Checks the display of the friends changesets listing
+  def test_list_friends
+    user = users(:normal_user)
+
+    get :list, :friends => true
+    assert_response :redirect
+    assert_redirected_to :controller => :user, :action => :login, :referer => friend_changesets_path
+
+    session[:user] = user.id
+
+    get :list, :friends => true
+    assert_response :success
+    assert_template "history"
+
+    xhr :get, :list, :friends => true, :list => "1"
+    assert_response :success
+    assert_template "list"
+
+    check_list_result(Changeset.where(:user => user.friend_users.identifiable))
+  end
+
+  ##
+  # Checks the display of the nearby user changesets listing
+  def test_list_nearby
+    user = users(:normal_user)
+
+    get :list, :nearby => true
+    assert_response :redirect
+    assert_redirected_to :controller => :user, :action => :login, :referer => nearby_changesets_path
+
+    session[:user] = user.id
+
+    get :list, :nearby => true
+    assert_response :success
+    assert_template "history"
+
+    xhr :get, :list, :nearby => true, :list => "1"
+    assert_response :success
+    assert_template "list"
+
+    check_list_result(Changeset.where(:user => user.nearby))

   end
 
   ##
   end
 
   ##

-  # This should display the last 20 changesets closed.
+  # Check that we can't request later pages of the changesets list
+  def test_list_max_id
+    xhr :get, :list, :format => "html", :max_id => 4
+    assert_response :success
+    assert_template "history"
+    assert_template :layout => "xhr"
+    assert_select "h2", :text => "Changesets", :count => 1
+
+    xhr :get, :list, :format => "html", :list => "1", :max_id => 4
+    assert_response :success
+    assert_template "list"
+
+    check_list_result(Changeset.where("id <= 4"))
+  end
+
+  ##
+  # This should display the last 20 changesets closed

   def test_feed
   def test_feed

-    changesets = Changeset.where("num_changes > 0").order(:created_at => :desc).limit(20)
-    assert changesets.size <= 20
-    get :feed, {:format => "atom"}
+    get :feed, :format => :atom

     assert_response :success
     assert_template "list"
     assert_response :success
     assert_template "list"

-    # Now check that all 20 (or however many were returned) changesets are in the html
-    assert_select "feed", :count => 1
-    assert_select "entry", :count => changesets.size
-    changesets.each do |changeset|
-      # FIXME this test needs rewriting - test for feed contents
-    end
+    assert_equal "application/atom+xml", response.content_type
+
+    check_feed_result(Changeset.all)
+  end
+
+  ##
+  # This should display the last 20 changesets closed in a specific area
+  def test_feed_bbox
+    get :feed, :format => :atom, :bbox => "4.5,4.5,5.5,5.5"
+    assert_response :success
+    assert_template "list"
+    assert_equal "application/atom+xml", response.content_type
+
+    check_feed_result(Changeset.where("min_lon < 55000000 and max_lon > 45000000 and min_lat < 55000000 and max_lat > 45000000"))

   end
 
   ##
   # Checks the display of the user changesets feed
   def test_feed_user
     user = users(:public_user)
   end
 
   ##
   # Checks the display of the user changesets feed
   def test_feed_user
     user = users(:public_user)

-    get :feed, {:format => "atom", :display_name => user.display_name}
+
+    get :feed, :format => :atom, :display_name => user.display_name

     assert_response :success
     assert_template "list"
     assert_equal "application/atom+xml", response.content_type
     assert_response :success
     assert_template "list"
     assert_equal "application/atom+xml", response.content_type

-    ## FIXME need to add more checks to see which if edits are actually shown if your data is public
+
+    check_feed_result(user.changesets)

   end
 
   ##
   # Check the not found of the user changesets feed
   def test_feed_user_not_found
   end
 
   ##
   # Check the not found of the user changesets feed
   def test_feed_user_not_found

-    get :feed, {:format => "atom", :display_name => "Some random user"}
+    get :feed, :format => "atom", :display_name => "Some random user"

     assert_response :not_found
   end
 
     assert_response :not_found
   end
 

+  ##
+  # Check that we can't request later pages of the changesets feed
+  def test_feed_max_id
+    get :feed, :format => "atom", :max_id => 100
+    assert_response :redirect
+    assert_redirected_to :action => :feed
+  end
+

   ##
   # check that the changeset download for a changeset with a redacted
   # element in it doesn't contain that element.
   ##
   # check that the changeset download for a changeset with a redacted
   # element in it doesn't contain that element.


@@ -1836,13 +1976,315 @@ EOF
     assert_select "osmChange", 1
     # this changeset contains node 17 in versions 1 & 2, but 1 should
     # be hidden.
     assert_select "osmChange", 1
     # this changeset contains node 17 in versions 1 & 2, but 1 should
     # be hidden.

-    assert_select "osmChange node[id=17]", 1
-    assert_select "osmChange node[id=17][version=1]", 0
+    assert_select "osmChange node[id='17']", 1
+    assert_select "osmChange node[id='17'][version='1']", 0
+  end
+
+  ##
+  # create comment success
+  def test_create_comment_success
+    basic_authorization(users(:public_user).email, "test")
+
+    assert_difference "ChangesetComment.count", 1 do
+      assert_no_difference "ActionMailer::Base.deliveries.size" do
+        post :comment, :id => changesets(:normal_user_closed_change).id, :text => "This is a comment"
+      end
+    end
+    assert_response :success
+
+    changeset = changesets(:normal_user_subscribed_change)
+    changeset.subscribers.push(users(:normal_user))
+    changeset.subscribers.push(users(:public_user))
+    changeset.subscribers.push(users(:suspended_user))
+    changeset.subscribers.push(users(:deleted_user))
+
+    assert_difference "ChangesetComment.count", 1 do
+      assert_difference "ActionMailer::Base.deliveries.size", 1 do
+        post :comment, :id => changeset.id, :text => "This is a comment"
+      end
+    end
+    assert_response :success
+
+    email = ActionMailer::Base.deliveries.first
+    assert_equal 1, email.to.length
+    assert_equal "[OpenStreetMap] test2 has commented on one of your changesets", email.subject
+    assert_equal "test@openstreetmap.org", email.to.first
+
+    ActionMailer::Base.deliveries.clear
+
+    basic_authorization(users(:second_public_user).email, "test")
+
+    assert_difference "ChangesetComment.count", 1 do
+      assert_difference "ActionMailer::Base.deliveries.size", 2 do
+        post :comment, :id => changeset.id, :text => "This is a comment"
+      end
+    end
+    assert_response :success
+
+    email = ActionMailer::Base.deliveries.find { |e| e.to.first == "test@openstreetmap.org" }
+    assert_not_nil email
+    assert_equal 1, email.to.length
+    assert_equal "[OpenStreetMap] pulibc_test2 has commented on one of your changesets", email.subject
+
+    email = ActionMailer::Base.deliveries.find { |e| e.to.first == "test@example.com" }
+    assert_not_nil email
+    assert_equal 1, email.to.length
+    assert_equal "[OpenStreetMap] pulibc_test2 has commented on a changeset you are interested in", email.subject
+
+    ActionMailer::Base.deliveries.clear
+  end
+
+  ##
+  # create comment fail
+  def test_create_comment_fail
+    # unauthorized
+    post :comment, :id => changesets(:normal_user_closed_change).id, :text => "This is a comment"
+    assert_response :unauthorized
+
+    basic_authorization(create(:user).email, "test")
+
+    # bad changeset id
+    assert_no_difference "ChangesetComment.count" do
+      post :comment, :id => 999111, :text => "This is a comment"
+    end
+    assert_response :not_found
+
+    # not closed changeset
+    assert_no_difference "ChangesetComment.count" do
+      post :comment, :id => changesets(:normal_user_first_change).id, :text => "This is a comment"
+    end
+    assert_response :conflict
+
+    # no text
+    assert_no_difference "ChangesetComment.count" do
+      post :comment, :id => changesets(:normal_user_closed_change).id
+    end
+    assert_response :bad_request
+
+    # empty text
+    assert_no_difference "ChangesetComment.count" do
+      post :comment, :id => changesets(:normal_user_closed_change).id, :text => ""
+    end
+    assert_response :bad_request

   end
 
   end
 

-  #------------------------------------------------------------
-  # utility functions
-  #------------------------------------------------------------
+  ##
+  # test subscribe success
+  def test_subscribe_success
+    basic_authorization(create(:user).email, "test")
+    changeset = changesets(:normal_user_closed_change)
+
+    assert_difference "changeset.subscribers.count", 1 do
+      post :subscribe, :id => changeset.id
+    end
+    assert_response :success
+  end
+
+  ##
+  # test subscribe fail
+  def test_subscribe_fail
+    user = create(:user)
+
+    # unauthorized
+    changeset = changesets(:normal_user_closed_change)
+    assert_no_difference "changeset.subscribers.count" do
+      post :subscribe, :id => changeset.id
+    end
+    assert_response :unauthorized
+
+    basic_authorization(user.email, "test")
+
+    # bad changeset id
+    assert_no_difference "changeset.subscribers.count" do
+      post :subscribe, :id => 999111
+    end
+    assert_response :not_found
+
+    # not closed changeset
+    changeset = changesets(:normal_user_first_change)
+    assert_no_difference "changeset.subscribers.count" do
+      post :subscribe, :id => changeset.id
+    end
+    assert_response :conflict
+
+    # trying to subscribe when already subscribed
+    changeset = changesets(:normal_user_subscribed_change)
+    changeset.subscribers.push(user)
+    assert_no_difference "changeset.subscribers.count" do
+      post :subscribe, :id => changeset.id
+    end
+    assert_response :conflict
+  end
+
+  ##
+  # test unsubscribe success
+  def test_unsubscribe_success
+    user = create(:user)
+    basic_authorization(user.email, "test")
+    changeset = changesets(:normal_user_subscribed_change)
+    changeset.subscribers.push(user)
+
+    assert_difference "changeset.subscribers.count", -1 do
+      post :unsubscribe, :id => changeset.id
+    end
+    assert_response :success
+  end
+
+  ##
+  # test unsubscribe fail
+  def test_unsubscribe_fail
+    # unauthorized
+    changeset = changesets(:normal_user_closed_change)
+    assert_no_difference "changeset.subscribers.count" do
+      post :unsubscribe, :id => changeset.id
+    end
+    assert_response :unauthorized
+
+    basic_authorization(create(:user).email, "test")
+
+    # bad changeset id
+    assert_no_difference "changeset.subscribers.count" do
+      post :unsubscribe, :id => 999111
+    end
+    assert_response :not_found
+
+    # not closed changeset
+    changeset = changesets(:normal_user_first_change)
+    assert_no_difference "changeset.subscribers.count" do
+      post :unsubscribe, :id => changeset.id
+    end
+    assert_response :conflict
+
+    # trying to unsubscribe when not subscribed
+    changeset = changesets(:normal_user_closed_change)
+    assert_no_difference "changeset.subscribers.count" do
+      post :unsubscribe, :id => changeset.id
+    end
+    assert_response :not_found
+  end
+
+  ##
+  # test hide comment fail
+  def test_hide_comment_fail
+    # unauthorized
+    comment = create(:changeset_comment)
+    assert_equal true, comment.visible
+
+    post :hide_comment, :id => comment.id
+    assert_response :unauthorized
+    assert_equal true, comment.reload.visible
+
+    basic_authorization(create(:user).email, "test")
+
+    # not a moderator
+    post :hide_comment, :id => comment.id
+    assert_response :forbidden
+    assert_equal true, comment.reload.visible
+
+    basic_authorization(create(:moderator_user).email, "test")
+
+    # bad comment id
+    post :hide_comment, :id => 999111
+    assert_response :not_found
+    assert_equal true, comment.reload.visible
+  end
+
+  ##
+  # test hide comment succes
+  def test_hide_comment_success
+    comment = create(:changeset_comment)
+    assert_equal true, comment.visible
+
+    basic_authorization(create(:moderator_user).email, "test")
+
+    post :hide_comment, :id => comment.id
+    assert_response :success
+    assert_equal false, comment.reload.visible
+  end
+
+  ##
+  # test unhide comment fail
+  def test_unhide_comment_fail
+    # unauthorized
+    comment = create(:changeset_comment, :visible => false)
+    assert_equal false, comment.visible
+
+    post :unhide_comment, :id => comment.id
+    assert_response :unauthorized
+    assert_equal false, comment.reload.visible
+
+    basic_authorization(create(:user).email, "test")
+
+    # not a moderator
+    post :unhide_comment, :id => comment.id
+    assert_response :forbidden
+    assert_equal false, comment.reload.visible
+
+    basic_authorization(create(:moderator_user).email, "test")
+
+    # bad comment id
+    post :unhide_comment, :id => 999111
+    assert_response :not_found
+    assert_equal false, comment.reload.visible
+  end
+
+  ##
+  # test unhide comment succes
+  def test_unhide_comment_success
+    comment = create(:changeset_comment, :visible => false)
+    assert_equal false, comment.visible
+
+    basic_authorization(create(:moderator_user).email, "test")
+
+    post :unhide_comment, :id => comment.id
+    assert_response :success
+    assert_equal true, comment.reload.visible
+  end
+
+  ##
+  # test comments feed
+  def test_comments_feed
+    create_list(:changeset_comment, 3, :changeset_id => changesets(:normal_user_closed_change).id)
+
+    get :comments_feed, :format => "rss"
+    assert_response :success
+    assert_equal "application/rss+xml", @response.content_type
+    assert_select "rss", :count => 1 do
+      assert_select "channel", :count => 1 do
+        assert_select "item", :count => 3
+      end
+    end
+
+    get :comments_feed, :format => "rss", :limit => 2
+    assert_response :success
+    assert_equal "application/rss+xml", @response.content_type
+    assert_select "rss", :count => 1 do
+      assert_select "channel", :count => 1 do
+        assert_select "item", :count => 2
+      end
+    end
+
+    get :comments_feed, :id => changesets(:normal_user_closed_change), :format => "rss"
+    assert_response :success
+    assert_equal "application/rss+xml", @response.content_type
+    assert_select "rss", :count => 1 do
+      assert_select "channel", :count => 1 do
+        assert_select "item", :count => 3
+      end
+    end
+  end
+
+  ##
+  # test comments feed
+  def test_comments_feed_bad_limit
+    get :comments_feed, :format => "rss", :limit => 0
+    assert_response :bad_request
+
+    get :comments_feed, :format => "rss", :limit => 100001
+    assert_response :bad_request
+  end
+
+  private

 
   ##
   # boilerplate for checking that certain changesets exist in the
 
   ##
   # boilerplate for checking that certain changesets exist in the


@@ -1850,7 +2292,7 @@ EOF
   def assert_changesets(ids)
     assert_select "osm>changeset", ids.size
     ids.each do |id|
   def assert_changesets(ids)
     assert_select "osm>changeset", ids.size
     ids.each do |id|

-      assert_select "osm>changeset[id=#{id}]", 1
+      assert_select "osm>changeset[id='#{id}']", 1

     end
   end
 
     end
   end
 


@@ -1863,28 +2305,62 @@ EOF
 
     # check exactly one changeset
     assert_select "osm>changeset", 1
 
     # check exactly one changeset
     assert_select "osm>changeset", 1

-    assert_select "osm>changeset[id=#{changeset_id}]", 1
+    assert_select "osm>changeset[id='#{changeset_id}']", 1

 
     # check the bbox
     doc = XML::Parser.string(@response.body).parse
     changeset = doc.find("//osm/changeset").first
 
     # check the bbox
     doc = XML::Parser.string(@response.body).parse
     changeset = doc.find("//osm/changeset").first

-    assert_equal bbox[0], changeset['min_lon'].to_f, "min lon"
-    assert_equal bbox[1], changeset['min_lat'].to_f, "min lat"
-    assert_equal bbox[2], changeset['max_lon'].to_f, "max lon"
-    assert_equal bbox[3], changeset['max_lat'].to_f, "max lat"
+    assert_equal bbox[0], changeset["min_lon"].to_f, "min lon"
+    assert_equal bbox[1], changeset["min_lat"].to_f, "min lat"
+    assert_equal bbox[2], changeset["max_lon"].to_f, "max lon"
+    assert_equal bbox[3], changeset["max_lat"].to_f, "max lat"

   end
 
   ##
   # update the changeset_id of a way element
   def update_changeset(xml, changeset_id)
   end
 
   ##
   # update the changeset_id of a way element
   def update_changeset(xml, changeset_id)

-    xml_attr_rewrite(xml, 'changeset', changeset_id)
+    xml_attr_rewrite(xml, "changeset", changeset_id)

   end
 
   ##
   # update an attribute in a way element
   def xml_attr_rewrite(xml, name, value)
     xml.find("//osm/way").first[name] = value.to_s
   end
 
   ##
   # update an attribute in a way element
   def xml_attr_rewrite(xml, name, value)
     xml.find("//osm/way").first[name] = value.to_s

-    return xml
+    xml

   end
 
   end
 

+  ##
+  # check the result of a list
+  def check_list_result(changesets)
+    changesets = changesets.where("num_changes > 0")
+                           .order(:created_at => :desc)
+                           .limit(20)
+    assert changesets.size <= 20
+
+    assert_select "ol.changesets", :count => [changesets.size, 1].min do
+      assert_select "li", :count => changesets.size
+
+      changesets.each do |changeset|
+        assert_select "li#changeset_#{changeset.id}", :count => 1
+      end
+    end
+  end
+
+  ##
+  # check the result of a feed
+  def check_feed_result(changesets)
+    changesets = changesets.where("num_changes > 0")
+                           .order(:created_at => :desc)
+                           .limit(20)
+    assert changesets.size <= 20
+
+    assert_select "feed", :count => [changesets.size, 1].min do
+      assert_select "> title", :count => 1, :text => /^Changesets/
+      assert_select "> entry", :count => changesets.size
+
+      changesets.each do |changeset|
+        assert_select "> entry > id", changeset_url(:id => changeset.id)
+      end
+    end
+  end

 end
 end