##
# test the index action
def test_index
+ revoked_block = create(:user_block, :revoked)
+
+ get user_blocks_path
+ assert_response :success
+ assert_select "table#block_list tbody tr", :count => 1 do
+ assert_select "a[href='#{user_path revoked_block.user}']", :text => revoked_block.user.display_name
+ assert_select "a[href='#{user_path revoked_block.creator}']", :text => revoked_block.creator.display_name
+ assert_select "a[href='#{user_path revoked_block.revoker}']", :text => revoked_block.revoker.display_name
+ end
+
active_block = create(:user_block)
expired_block = create(:user_block, :expired)
- revoked_block = create(:user_block, :revoked)
get user_blocks_path
assert_response :success
- assert_select "table#block_list", :count => 1 do
- assert_select "tr", 4
+ assert_select "table#block_list tbody", :count => 1 do
+ assert_select "tr", 3
assert_select "a[href='#{user_block_path(active_block)}']", 1
assert_select "a[href='#{user_block_path(expired_block)}']", 1
assert_select "a[href='#{user_block_path(revoked_block)}']", 1
##
# test the index action with multiple pages
def test_index_paged
- create_list(:user_block, 50)
+ user_blocks = create_list(:user_block, 50).reverse
+ next_path = user_blocks_path
- get user_blocks_path
+ get next_path
assert_response :success
- assert_select "table#block_list tbody", :count => 1 do
- assert_select "tr", :count => 20
- end
+ check_user_blocks_table user_blocks[0...20]
+ check_no_page_link "Newer Blocks"
+ next_path = check_page_link "Older Blocks"
- get user_blocks_path(:page => 2)
+ get next_path
assert_response :success
- assert_select "table#block_list tbody", :count => 1 do
- assert_select "tr", :count => 20
+ check_user_blocks_table user_blocks[20...40]
+ check_page_link "Newer Blocks"
+ next_path = check_page_link "Older Blocks"
+
+ get next_path
+ assert_response :success
+ check_user_blocks_table user_blocks[40...50]
+ check_page_link "Newer Blocks"
+ check_no_page_link "Older Blocks"
+ end
+
+ ##
+ # test the index action with invalid pages
+ def test_index_invalid_paged
+ %w[-1 0 fred].each do |id|
+ get user_blocks_path(:before => id)
+ assert_redirected_to :controller => :errors, :action => :bad_request
+
+ get user_blocks_path(:after => id)
+ assert_redirected_to :controller => :errors, :action => :bad_request
end
end
# Viewing an expired block should work
get user_block_path(:id => expired_block)
assert_response :success
+ assert_select "h1 a[href='#{user_path expired_block.user}']", :text => expired_block.user.display_name
+ assert_select "h1 a[href='#{user_path expired_block.creator}']", :text => expired_block.creator.display_name
# Viewing a revoked block should work
get user_block_path(:id => revoked_block)
assert_response :success
+ assert_select "h1 a[href='#{user_path revoked_block.user}']", :text => revoked_block.user.display_name
+ assert_select "h1 a[href='#{user_path revoked_block.creator}']", :text => revoked_block.creator.display_name
+ assert_select "a[href='#{user_path revoked_block.revoker}']", :text => revoked_block.revoker.display_name
# Viewing an active block should work, but shouldn't mark it as seen
get user_block_path(:id => active_block)
assert_response :success
+ assert_select "h1 a[href='#{user_path active_block.user}']", :text => active_block.user.display_name
+ assert_select "h1 a[href='#{user_path active_block.creator}']", :text => active_block.creator.display_name
assert UserBlock.find(active_block.id).needs_view
# Login as the blocked user
assert_not UserBlock.find(active_block.id).needs_view
end
+ ##
+ # test edit/revoke link for active blocks
+ def test_active_block_buttons
+ creator_user = create(:moderator_user)
+ other_moderator_user = create(:moderator_user)
+ block = create(:user_block, :creator => creator_user)
+
+ session_for(other_moderator_user)
+ check_block_buttons block, :revoke => 1
+
+ session_for(creator_user)
+ check_block_buttons block, :edit => 1, :revoke => 1
+ end
+
+ ##
+ # test the edit link for expired blocks
+ def test_expired_block_buttons
+ creator_user = create(:moderator_user)
+ other_moderator_user = create(:moderator_user)
+ block = create(:user_block, :expired, :creator => creator_user)
+
+ session_for(other_moderator_user)
+ check_block_buttons block
+
+ session_for(creator_user)
+ check_block_buttons block, :edit => 1
+ end
+
+ ##
+ # test the edit link for revoked blocks
+ def test_revoked_block_buttons
+ creator_user = create(:moderator_user)
+ revoker_user = create(:moderator_user)
+ other_moderator_user = create(:moderator_user)
+ block = create(:user_block, :revoked, :creator => creator_user, :revoker => revoker_user)
+
+ session_for(other_moderator_user)
+ check_block_buttons block
+
+ session_for(creator_user)
+ check_block_buttons block, :edit => 1
+
+ session_for(revoker_user)
+ check_block_buttons block, :edit => 1
+ end
+
##
# test the new action
def test_new
# Check that the block creation page loads for moderators
get new_user_block_path(target_user)
assert_response :success
+ assert_select "h1 a[href='#{user_path target_user}']", :text => target_user.display_name
assert_select "form#new_user_block", :count => 1 do
assert_select "textarea#user_block_reason", :count => 1
assert_select "select#user_block_period", :count => 1
# Check that the block edit page loads for moderators
get edit_user_block_path(:id => active_block)
assert_response :success
+ assert_select "h1 a[href='#{user_path active_block.user}']", :text => active_block.user.display_name
assert_select "form#edit_user_block_#{active_block.id}", :count => 1 do
assert_select "textarea#user_block_reason", :count => 1
assert_select "select#user_block_period", :count => 1
assert_select "p", "Sorry, the user block with ID 99999 could not be found."
end
+ ##
+ # test the edit action when the remaining block duration doesn't match the available select options
+ def test_edit_duration
+ moderator_user = create(:moderator_user)
+
+ freeze_time do
+ active_block = create(:user_block, :creator => moderator_user, :ends_at => Time.now.utc + 96.hours)
+
+ session_for(moderator_user)
+ get edit_user_block_path(active_block)
+
+ assert_select "form#edit_user_block_#{active_block.id}", :count => 1 do
+ assert_select "select#user_block_period", :count => 1 do
+ assert_select "option[value='96'][selected]", :count => 1
+ end
+ end
+
+ travel 2.hours
+ get edit_user_block_path(active_block)
+
+ assert_select "form#edit_user_block_#{active_block.id}", :count => 1 do
+ assert_select "select#user_block_period", :count => 1 do
+ assert_select "option[value='96'][selected]", :count => 1
+ end
+ end
+ end
+ end
+
##
# test the create action
def test_create
:user_block_period => "12",
:user_block => { :needs_view => false, :reason => "Vandalism" })
end
- id = UserBlock.order(:id).ids.last
- assert_redirected_to user_block_path(:id => id)
+ b = UserBlock.last
+ assert_redirected_to user_block_path(:id => b.id)
assert_equal "Created a block on user #{target_user.display_name}.", flash[:notice]
- b = UserBlock.find(id)
assert_in_delta Time.now.utc, b.created_at, 1
assert_in_delta Time.now.utc, b.updated_at, 1
assert_in_delta Time.now.utc + 12.hours, b.ends_at, 1
:user_block_period => "336",
:user_block => { :needs_view => false, :reason => "Vandalism" })
- block = UserBlock.order(:id).last
+ block = UserBlock.last
assert_equal 1209600, block.ends_at - block.created_at
end
assert_select "p", "Sorry, the user block with ID 99999 could not be found."
end
+ ##
+ # test the update action on expired blocks
+ def test_update_expired
+ creator_user = create(:moderator_user)
+ other_moderator_user = create(:moderator_user)
+ block = create(:user_block, :expired, :creator => creator_user, :reason => "Original Reason")
+
+ session_for(other_moderator_user)
+ put user_block_path(block,
+ :user_block_period => "0",
+ :user_block => { :needs_view => false, :reason => "Updated Reason" })
+ assert_redirected_to edit_user_block_path(block)
+ assert_equal "Only the moderator who created this block can edit it.", flash[:error]
+ block.reload
+ assert_not block.active?
+ assert_equal "Original Reason", block.reason
+
+ session_for(creator_user)
+ check_block_updates(block)
+ end
+
+ ##
+ # test the update action on revoked blocks
+ def test_update_revoked
+ creator_user = create(:moderator_user)
+ revoker_user = create(:moderator_user)
+ other_moderator_user = create(:moderator_user)
+ block = create(:user_block, :revoked, :creator => creator_user, :revoker => revoker_user, :reason => "Original Reason")
+
+ session_for(other_moderator_user)
+ put user_block_path(block,
+ :user_block_period => "0",
+ :user_block => { :needs_view => false, :reason => "Updated Reason" })
+ assert_redirected_to edit_user_block_path(block)
+ assert_equal "Only the moderators who created or revoked this block can edit it.", flash[:error]
+ block.reload
+ assert_not_predicate block, :active?
+ assert_equal "Original Reason", block.reason
+
+ session_for(creator_user)
+ check_block_updates(block)
+
+ session_for(revoker_user)
+ check_block_updates(block)
+ end
+
##
# test the revoke action
def test_revoke
get revoke_user_block_path(:id => active_block)
assert_response :success
assert_template "revoke"
+ assert_select "h1 a[href='#{user_path active_block.user}']", :text => active_block.user.display_name
assert_select "form", :count => 1 do
assert_select "input#confirm[type='checkbox']", :count => 1
assert_select "input[type='submit'][value='Revoke!']", :count => 1
# Check that the revoke all blocks page loads for moderators
get revoke_all_user_blocks_path(blocked_user)
assert_response :success
+ assert_select "h1 a[href='#{user_path blocked_user}']", :text => blocked_user.display_name
end
##
# Check the list of blocks for a user that is currently blocked
get user_blocks_on_path(blocked_user)
assert_response :success
- assert_select "table#block_list", :count => 1 do
- assert_select "tr", 3
+ assert_select "h1 a[href='#{user_path blocked_user}']", :text => blocked_user.display_name
+ assert_select "table#block_list tbody", :count => 1 do
+ assert_select "tr", 2
assert_select "a[href='#{user_block_path(active_block)}']", 1
assert_select "a[href='#{user_block_path(revoked_block)}']", 1
end
# Check the list of blocks for a user that has previously been blocked
get user_blocks_on_path(unblocked_user)
assert_response :success
- assert_select "table#block_list", :count => 1 do
- assert_select "tr", 2
+ assert_select "h1 a[href='#{user_path unblocked_user}']", :text => unblocked_user.display_name
+ assert_select "table#block_list tbody", :count => 1 do
+ assert_select "tr", 1
assert_select "a[href='#{user_block_path(expired_block)}']", 1
end
end
# test the blocks_on action with multiple pages
def test_blocks_on_paged
user = create(:user)
- create_list(:user_block, 50, :user => user)
+ user_blocks = create_list(:user_block, 50, :user => user).reverse
+ next_path = user_blocks_on_path(user)
- get user_blocks_on_path(user)
+ get next_path
assert_response :success
- assert_select "table#block_list tbody", :count => 1 do
- assert_select "tr", :count => 20
- end
+ check_user_blocks_table user_blocks[0...20]
+ check_no_page_link "Newer Blocks"
+ next_path = check_page_link "Older Blocks"
- get user_blocks_on_path(user, :page => 2)
+ get next_path
assert_response :success
- assert_select "table#block_list tbody", :count => 1 do
- assert_select "tr", :count => 20
+ check_user_blocks_table user_blocks[20...40]
+ check_page_link "Newer Blocks"
+ next_path = check_page_link "Older Blocks"
+
+ get next_path
+ assert_response :success
+ check_user_blocks_table user_blocks[40...50]
+ check_page_link "Newer Blocks"
+ check_no_page_link "Older Blocks"
+ end
+
+ ##
+ # test the blocks_on action with invalid pages
+ def test_blocks_on_invalid_paged
+ user = create(:user)
+
+ %w[-1 0 fred].each do |id|
+ get user_blocks_on_path(user, :before => id)
+ assert_redirected_to :controller => :errors, :action => :bad_request
+
+ get user_blocks_on_path(user, :after => id)
+ assert_redirected_to :controller => :errors, :action => :bad_request
end
end
# Check the list of blocks given by one moderator
get user_blocks_by_path(moderator_user)
assert_response :success
- assert_select "table#block_list", :count => 1 do
- assert_select "tr", 2
+ assert_select "h1 a[href='#{user_path moderator_user}']", :text => moderator_user.display_name
+ assert_select "table#block_list tbody", :count => 1 do
+ assert_select "tr", 1
assert_select "a[href='#{user_block_path(active_block)}']", 1
end
# Check the list of blocks given by a different moderator
get user_blocks_by_path(second_moderator_user)
assert_response :success
- assert_select "table#block_list", :count => 1 do
- assert_select "tr", 3
+ assert_select "h1 a[href='#{user_path second_moderator_user}']", :text => second_moderator_user.display_name
+ assert_select "table#block_list tbody", :count => 1 do
+ assert_select "tr", 2
assert_select "a[href='#{user_block_path(expired_block)}']", 1
assert_select "a[href='#{user_block_path(revoked_block)}']", 1
end
# test the blocks_by action with multiple pages
def test_blocks_by_paged
user = create(:moderator_user)
- create_list(:user_block, 50, :creator => user)
+ user_blocks = create_list(:user_block, 50, :creator => user).reverse
+ next_path = user_blocks_by_path(user)
- get user_blocks_by_path(user)
+ get next_path
assert_response :success
- assert_select "table#block_list tbody", :count => 1 do
- assert_select "tr", :count => 20
- end
+ check_user_blocks_table user_blocks[0...20]
+ check_no_page_link "Newer Blocks"
+ next_path = check_page_link "Older Blocks"
- get user_blocks_by_path(user, :page => 2)
+ get next_path
assert_response :success
- assert_select "table#block_list tbody", :count => 1 do
- assert_select "tr", :count => 20
+ check_user_blocks_table user_blocks[20...40]
+ check_page_link "Newer Blocks"
+ next_path = check_page_link "Older Blocks"
+
+ get next_path
+ assert_response :success
+ check_user_blocks_table user_blocks[40...50]
+ check_page_link "Newer Blocks"
+ check_no_page_link "Older Blocks"
+ end
+
+ ##
+ # test the blocks_by action with invalid pages
+ def test_blocks_by_invalid_paged
+ user = create(:moderator_user)
+
+ %w[-1 0 fred].each do |id|
+ get user_blocks_by_path(user, :before => id)
+ assert_redirected_to :controller => :errors, :action => :bad_request
+
+ get user_blocks_by_path(user, :after => id)
+ assert_redirected_to :controller => :errors, :action => :bad_request
+ end
+ end
+
+ private
+
+ def check_block_buttons(block, edit: 0, revoke: 0)
+ [user_blocks_path, user_block_path(block)].each do |path|
+ get path
+ assert_response :success
+ assert_select "a[href='#{edit_user_block_path block}']", :count => edit
+ assert_select "a[href='#{revoke_user_block_path block}']", :count => revoke
+ end
+ end
+
+ def check_block_updates(block)
+ put user_block_path(block,
+ :user_block_period => "0",
+ :user_block => { :needs_view => false, :reason => "Updated Reason" })
+ assert_redirected_to user_block_path(block)
+ assert_equal "Block updated.", flash[:notice]
+ block.reload
+ assert_not_predicate block, :active?
+ assert_equal "Updated Reason", block.reason
+
+ put user_block_path(block,
+ :user_block_period => "0",
+ :user_block => { :needs_view => true, :reason => "Updated Reason 2" })
+ assert_redirected_to user_block_path(block)
+ assert_equal "Block updated.", flash[:notice]
+ block.reload
+ assert_predicate block, :active?
+ assert_equal "Updated Reason 2", block.reason
+ end
+
+ def check_user_blocks_table(user_blocks)
+ assert_dom "table#block_list tbody tr" do |rows|
+ assert_equal user_blocks.count, rows.count, "unexpected number of rows in user blocks table"
+ rows.zip(user_blocks).map do |row, user_block|
+ assert_dom row, "a[href='#{user_block_path user_block}']", 1
+ end
+ end
+ end
+
+ def check_no_page_link(name)
+ assert_select "a.page-link", { :text => /#{Regexp.quote(name)}/, :count => 0 }, "unexpected #{name} page link"
+ end
+
+ def check_page_link(name)
+ assert_select "a.page-link", { :text => /#{Regexp.quote(name)}/ }, "missing #{name} page link" do |buttons|
+ return buttons.first.attributes["href"].value
end
end
end
projects / rails.git / blobdiff