Improve handling of HTTP errors in search

[rails.git] / app / helpers / geocoder_helper.rb

diff --git a/app/helpers/geocoder_helper.rb b/app/helpers/geocoder_helper.rb
index 04f437a7c47b4592729f843254a570b0ffa89901..e135917a9240886c22c5dbca7417ab272bd348ac 100644 (file)
--- a/app/helpers/geocoder_helper.rb
+++ b/app/helpers/geocoder_helper.rb
@@ -2,22 +2,23 @@ module GeocoderHelper
   def result_to_html(result)
     html_options = { :class => "set_position", :data => {} }
 
   def result_to_html(result)
     html_options = { :class => "set_position", :data => {} }
 

-    if result[:type] and result[:id]
+    if result[:type] && result[:id]

       url = url_for(:controller => :browse, :action => result[:type], :id => result[:id])
       url = url_for(:controller => :browse, :action => result[:type], :id => result[:id])

-    elsif result[:min_lon] and result[:min_lat] and result[:max_lon] and result[:max_lat]
+    elsif result[:min_lon] && result[:min_lat] && result[:max_lon] && result[:max_lat]

       url = "/?bbox=#{result[:min_lon]},#{result[:min_lat]},#{result[:max_lon]},#{result[:max_lat]}"
     else
       url = "/#map=#{result[:zoom]}/#{result[:lat]}/#{result[:lon]}"
     end
 
       url = "/?bbox=#{result[:min_lon]},#{result[:min_lat]},#{result[:max_lon]},#{result[:max_lat]}"
     else
       url = "/#map=#{result[:zoom]}/#{result[:lat]}/#{result[:lon]}"
     end
 

-    result.each do |key,value|
-      html_options[:data][key.to_s.tr('_', '-')] = value
+    result.each do |key, value|
+      html_options[:data][key.to_s.tr("_", "-")] = value

     end
 
     html = ""
     html << result[:prefix] if result[:prefix]
     end
 
     html = ""
     html << result[:prefix] if result[:prefix]

-    html << " " if result[:prefix] and result[:name]
+    html << " " if result[:prefix] && result[:name]

     html << link_to(result[:name], url, html_options) if result[:name]
     html << link_to(result[:name], url, html_options) if result[:name]

+    html << " " if result[:suffix] && result[:name]

     html << result[:suffix] if result[:suffix]
     html.html_safe
   end
     html << result[:suffix] if result[:suffix]
     html.html_safe
   end