Refactor more controller tests

[rails.git] / test / controllers / api / changesets_controller_test.rb

diff --git a/test/controllers/api/changesets_controller_test.rb b/test/controllers/api/changesets_controller_test.rb
index e8dda0ba16407f1dedc234eedd2488d848a342cc..29b3d5dac4e22c2824949654b31cbf8ae5e58b7c 100644 (file)
--- a/test/controllers/api/changesets_controller_test.rb
+++ b/test/controllers/api/changesets_controller_test.rb
@@ -282,7 +282,7 @@ module Api
 
       # simple diff to change a node, way and relation by removing
       # their tags
 
       # simple diff to change a node, way and relation by removing
       # their tags

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>


@@ -298,7 +298,7 @@ module Api
           </relation>
          </modify>
         </osmChange>
           </relation>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff


@@ -311,7 +311,7 @@ CHANGESET
 
       # simple diff to change a node, way and relation by removing
       # their tags
 
       # simple diff to change a node, way and relation by removing
       # their tags

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>


@@ -327,7 +327,7 @@ CHANGESET
           </relation>
          </modify>
         </osmChange>
           </relation>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff


@@ -340,7 +340,7 @@ CHANGESET
 
       # simple diff to change a node, way and relation by removing
       # their tags
 
       # simple diff to change a node, way and relation by removing
       # their tags

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>


@@ -356,7 +356,7 @@ CHANGESET
           </relation>
          </modify>
         </osmChange>
           </relation>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff


@@ -381,7 +381,7 @@ CHANGESET
       basic_authorization user.email, "test"
 
       # simple diff to create a node way and relation using placeholders
       basic_authorization user.email, "test"
 
       # simple diff to create a node way and relation using placeholders

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>


@@ -400,7 +400,7 @@ CHANGESET
           </relation>
          </create>
         </osmChange>
           </relation>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -454,10 +454,10 @@ CHANGESET
       diff.root = XML::Node.new "osmChange"
       delete = XML::Node.new "delete"
       diff.root << delete
       diff.root = XML::Node.new "osmChange"
       delete = XML::Node.new "delete"
       diff.root << delete

-      delete << super_relation.to_xml_node
-      delete << used_relation.to_xml_node
-      delete << used_way.to_xml_node
-      delete << used_node.to_xml_node
+      delete << xml_node_for_relation(super_relation)
+      delete << xml_node_for_relation(used_relation)
+      delete << xml_node_for_way(used_way)
+      delete << xml_node_for_node(used_node)

 
       # update the changeset to one that this user owns
       %w[node way relation].each do |type|
 
       # update the changeset to one that this user owns
       %w[node way relation].each do |type|


@@ -477,10 +477,10 @@ CHANGESET
       assert_select "diffResult>relation", 2
 
       # check that everything was deleted
       assert_select "diffResult>relation", 2
 
       # check that everything was deleted

-      assert_equal false, Node.find(used_node.id).visible
-      assert_equal false, Way.find(used_way.id).visible
-      assert_equal false, Relation.find(super_relation.id).visible
-      assert_equal false, Relation.find(used_relation.id).visible
+      assert_not Node.find(used_node.id).visible
+      assert_not Way.find(used_way.id).visible
+      assert_not Relation.find(super_relation.id).visible
+      assert_not Relation.find(used_relation.id).visible

     end
 
     ##
     end
 
     ##


@@ -502,7 +502,7 @@ CHANGESET
       assert_select "diffResult>node", 1
 
       # check that everything was deleted
       assert_select "diffResult>node", 1
 
       # check that everything was deleted

-      assert_equal false, Node.find(node.id).visible
+      assert_not Node.find(node.id).visible

     end
 
     def test_repeated_changeset_create
     end
 
     def test_repeated_changeset_create


@@ -529,7 +529,7 @@ CHANGESET
       changeset_id = @response.body.to_i
 
       # upload some widely-spaced nodes, spiralling positive and negative
       changeset_id = @response.body.to_i
 
       # upload some widely-spaced nodes, spiralling positive and negative

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id='-1' lon='-20' lat='-10' changeset='#{changeset_id}'/>
         <osmChange>
          <create>
           <node id='-1' lon='-20' lat='-10' changeset='#{changeset_id}'/>


@@ -552,7 +552,7 @@ CHANGESET
           <node id='-18' lon='179.9'  lat='89.9' changeset='#{changeset_id}'/>
          </create>
         </osmChange>
           <node id='-18' lon='179.9'  lat='89.9' changeset='#{changeset_id}'/>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it, which used to cause an error like "PGError: ERROR:
       # integer out of range" (bug #2152). but shouldn't any more.
 
       # upload it, which used to cause an error like "PGError: ERROR:
       # integer out of range" (bug #2152). but shouldn't any more.


@@ -586,9 +586,9 @@ CHANGESET
       diff.root = XML::Node.new "osmChange"
       delete = XML::Node.new "delete"
       diff.root << delete
       diff.root = XML::Node.new "osmChange"
       delete = XML::Node.new "delete"
       diff.root << delete

-      delete << other_relation.to_xml_node
-      delete << used_way.to_xml_node
-      delete << used_node.to_xml_node
+      delete << xml_node_for_relation(other_relation)
+      delete << xml_node_for_way(used_way)
+      delete << xml_node_for_node(used_node)

 
       # update the changeset to one that this user owns
       %w[node way relation].each do |type|
 
       # update the changeset to one that this user owns
       %w[node way relation].each do |type|


@@ -604,10 +604,10 @@ CHANGESET
       assert_equal "Precondition failed: Way #{used_way.id} is still used by relations #{relation.id}.", @response.body
 
       # check that nothing was, in fact, deleted
       assert_equal "Precondition failed: Way #{used_way.id} is still used by relations #{relation.id}.", @response.body
 
       # check that nothing was, in fact, deleted

-      assert_equal true, Node.find(used_node.id).visible
-      assert_equal true, Way.find(used_way.id).visible
-      assert_equal true, Relation.find(relation.id).visible
-      assert_equal true, Relation.find(other_relation.id).visible
+      assert Node.find(used_node.id).visible
+      assert Way.find(used_way.id).visible
+      assert Relation.find(relation.id).visible
+      assert Relation.find(other_relation.id).visible

     end
 
     ##
     end
 
     ##


@@ -629,9 +629,9 @@ CHANGESET
       delete = XML::Node.new "delete"
       diff.root << delete
       delete["if-unused"] = ""
       delete = XML::Node.new "delete"
       diff.root << delete
       delete["if-unused"] = ""

-      delete << used_relation.to_xml_node
-      delete << used_way.to_xml_node
-      delete << used_node.to_xml_node
+      delete << xml_node_for_relation(used_relation)
+      delete << xml_node_for_way(used_way)
+      delete << xml_node_for_node(used_node)

 
       # update the changeset to one that this user owns
       %w[node way relation].each do |type|
 
       # update the changeset to one that this user owns
       %w[node way relation].each do |type|


@@ -670,9 +670,9 @@ CHANGESET
       assert_equal used_relation.version, doc.find("//diffResult/relation").first["new_version"].to_i
 
       # check that nothing was, in fact, deleted
       assert_equal used_relation.version, doc.find("//diffResult/relation").first["new_version"].to_i
 
       # check that nothing was, in fact, deleted

-      assert_equal true, Node.find(used_node.id).visible
-      assert_equal true, Way.find(used_way.id).visible
-      assert_equal true, Relation.find(used_relation.id).visible
+      assert Node.find(used_node.id).visible
+      assert Way.find(used_way.id).visible
+      assert Relation.find(used_relation.id).visible

     end
 
     ##
     end
 
     ##


@@ -683,7 +683,7 @@ CHANGESET
       basic_authorization changeset.user.email, "test"
 
       # simple diff to create a node way and relation using placeholders
       basic_authorization changeset.user.email, "test"
 
       # simple diff to create a node way and relation using placeholders

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>


@@ -691,7 +691,7 @@ CHANGESET
           </node>
          </create>
         </osmChange>
           </node>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -713,7 +713,7 @@ CHANGESET
       basic_authorization changeset.user.email, "test"
 
       # simple diff to create a node way and relation using placeholders
       basic_authorization changeset.user.email, "test"
 
       # simple diff to create a node way and relation using placeholders

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>


@@ -733,7 +733,7 @@ CHANGESET
           </relation>
          </modify>
         </osmChange>
           </relation>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -772,7 +772,7 @@ CHANGESET
       basic_authorization changeset.user.email, "test"
 
       # simple diff to create a node way and relation using placeholders
       basic_authorization changeset.user.email, "test"
 
       # simple diff to create a node way and relation using placeholders

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>


@@ -794,7 +794,7 @@ CHANGESET
           </node>
          </create>
         </osmChange>
           </node>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -817,7 +817,7 @@ CHANGESET
       # change the location of a node multiple times, each time referencing
       # the last version. doesn't this depend on version numbers being
       # sequential?
       # change the location of a node multiple times, each time referencing
       # the last version. doesn't this depend on version numbers being
       # sequential?

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>


@@ -830,7 +830,7 @@ CHANGESET
           <node id='#{node.id}' lon='9' lat='9' changeset='#{changeset.id}' version='8'/>
          </modify>
         </osmChange>
           <node id='#{node.id}' lon='9' lat='9' changeset='#{changeset.id}' version='8'/>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -852,14 +852,14 @@ CHANGESET
 
       basic_authorization changeset.user.email, "test"
 
 
       basic_authorization changeset.user.email, "test"
 

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
           <node id='#{node.id}' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
          </modify>
         </osmChange>
         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
           <node id='#{node.id}' lon='1' lat='1' changeset='#{changeset.id}' version='1'/>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -874,13 +874,13 @@ CHANGESET
 
       basic_authorization changeset.user.email, "test"
 
 
       basic_authorization changeset.user.email, "test"
 

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify>
          <node id='1' lon='1' lat='1' changeset='#{changeset.id}'/>
          </modify>
         </osmChange>
         <osmChange>
          <modify>
          <node id='1' lon='1' lat='1' changeset='#{changeset.id}'/>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -895,13 +895,13 @@ CHANGESET
 
       basic_authorization changeset.user.email, "test"
 
 
       basic_authorization changeset.user.email, "test"
 

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
           <ping>
            <node id='1' lon='1' lat='1' changeset='#{changeset.id}' />
           </ping>
         </osmChange>
         <osmChange>
           <ping>
            <node id='1' lon='1' lat='1' changeset='#{changeset.id}' />
           </ping>
         </osmChange>

-CHANGESET
+      CHANGESET

       post :upload, :params => { :id => changeset.id }, :body => diff
       assert_response :bad_request, "Shouldn't be able to upload a diff with the action ping"
       assert_equal @response.body, "Unknown action ping, choices are create, modify, delete"
       post :upload, :params => { :id => changeset.id }, :body => diff
       assert_response :bad_request, "Shouldn't be able to upload a diff with the action ping"
       assert_equal @response.body, "Unknown action ping, choices are create, modify, delete"


@@ -920,7 +920,7 @@ CHANGESET
 
       basic_authorization changeset.user.email, "test"
 
 
       basic_authorization changeset.user.email, "test"
 

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify><node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}'
           version='1'></node>
         <osmChange>
          <modify><node id='#{node.id}' lon='0' lat='0' changeset='#{changeset.id}'
           version='1'></node>


@@ -932,7 +932,7 @@ CHANGESET
            <member type='relation' role='some' ref='#{other_relation.id}'/>
           </relation>
          </modify></osmChange>
            <member type='relation' role='some' ref='#{other_relation.id}'/>
           </relation>
          </modify></osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -955,7 +955,7 @@ CHANGESET
 
       basic_authorization changeset.user.email, "test"
 
 
       basic_authorization changeset.user.email, "test"
 

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>
         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}'>


@@ -969,7 +969,7 @@ CHANGESET
           <node id='-1' lon='2' lat='2' changeset='#{changeset.id}' version='2'/>
          </delete>
         </osmChange>
           <node id='-1' lon='2' lat='2' changeset='#{changeset.id}' version='2'/>
          </delete>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -989,7 +989,7 @@ CHANGESET
 
       basic_authorization changeset.user.email, "test"
 
 
       basic_authorization changeset.user.email, "test"
 

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>
         <osmChange>
          <create>
           <node id='-1' lon='0' lat='0' changeset='#{changeset.id}' version='1'/>


@@ -997,7 +997,7 @@ CHANGESET
           <node id='-1' lon='2' lat='2' changeset='#{changeset.id}' version='2'/>
          </create>
         </osmChange>
           <node id='-1' lon='2' lat='2' changeset='#{changeset.id}' version='2'/>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -1014,7 +1014,7 @@ CHANGESET
 
       basic_authorization changeset.user.email, "test"
 
 
       basic_authorization changeset.user.email, "test"
 

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id="-1" lon="0" lat="0" changeset="#{changeset.id}" version="1"/>
         <osmChange>
          <create>
           <node id="-1" lon="0" lat="0" changeset="#{changeset.id}" version="1"/>


@@ -1028,7 +1028,7 @@ CHANGESET
           </way>
          </create>
         </osmChange>
           </way>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -1037,7 +1037,7 @@ CHANGESET
       assert_equal "Placeholder node not found for reference -4 in way -1", @response.body
 
       # the same again, but this time use an existing way
       assert_equal "Placeholder node not found for reference -4 in way -1", @response.body
 
       # the same again, but this time use an existing way

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id="-1" lon="0" lat="0" changeset="#{changeset.id}" version="1"/>
         <osmChange>
          <create>
           <node id="-1" lon="0" lat="0" changeset="#{changeset.id}" version="1"/>


@@ -1051,7 +1051,7 @@ CHANGESET
           </way>
          </create>
         </osmChange>
           </way>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -1069,7 +1069,7 @@ CHANGESET
 
       basic_authorization changeset.user.email, "test"
 
 
       basic_authorization changeset.user.email, "test"
 

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id="-1" lon="0" lat="0" changeset="#{changeset.id}" version="1"/>
         <osmChange>
          <create>
           <node id="-1" lon="0" lat="0" changeset="#{changeset.id}" version="1"/>


@@ -1083,7 +1083,7 @@ CHANGESET
           </relation>
          </create>
         </osmChange>
           </relation>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -1092,7 +1092,7 @@ CHANGESET
       assert_equal "Placeholder Node not found for reference -4 in relation -1.", @response.body
 
       # the same again, but this time use an existing relation
       assert_equal "Placeholder Node not found for reference -4 in relation -1.", @response.body
 
       # the same again, but this time use an existing relation

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <create>
           <node id="-1" lon="0" lat="0" changeset="#{changeset.id}" version="1"/>
         <osmChange>
          <create>
           <node id="-1" lon="0" lat="0" changeset="#{changeset.id}" version="1"/>


@@ -1106,7 +1106,7 @@ CHANGESET
           </relation>
          </create>
         </osmChange>
           </relation>
          </create>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset.id }, :body => diff


@@ -1133,7 +1133,7 @@ CHANGESET
       diff = XML::Document.new
       diff.root = XML::Node.new "osmChange"
       modify = XML::Node.new "modify"
       diff = XML::Document.new
       diff.root = XML::Node.new "osmChange"
       modify = XML::Node.new "modify"

-      xml_old_node = old_node.to_xml_node
+      xml_old_node = xml_node_for_node(old_node)

       xml_old_node["lat"] = 2.0.to_s
       xml_old_node["lon"] = 2.0.to_s
       xml_old_node["changeset"] = changeset_id.to_s
       xml_old_node["lat"] = 2.0.to_s
       xml_old_node["lon"] = 2.0.to_s
       xml_old_node["changeset"] = changeset_id.to_s


@@ -1171,7 +1171,7 @@ CHANGESET
       diff = XML::Document.new
       diff.root = XML::Node.new "osmChange"
       modify = XML::Node.new "modify"
       diff = XML::Document.new
       diff.root = XML::Node.new "osmChange"
       modify = XML::Node.new "modify"

-      xml_old_way = old_way.to_xml_node
+      xml_old_way = xml_node_for_way(old_way)

       nd_ref = XML::Node.new "nd"
       nd_ref["ref"] = create(:node, :lat => 3, :lon => 3).id.to_s
       xml_old_way << nd_ref
       nd_ref = XML::Node.new "nd"
       nd_ref["ref"] = create(:node, :lat => 3, :lon => 3).id.to_s
       xml_old_way << nd_ref


@@ -1224,7 +1224,7 @@ CHANGESET
       diff.root = XML::Node.new "osmChange"
       delete = XML::Node.new "delete"
       diff.root << delete
       diff.root = XML::Node.new "osmChange"
       delete = XML::Node.new "delete"
       diff.root << delete

-      delete << node.to_xml_node
+      delete << xml_node_for_node(node)

 
       # upload it
       error_format "xml"
 
       # upload it
       error_format "xml"


@@ -1266,7 +1266,7 @@ CHANGESET
       changeset_id = @response.body.to_i
 
       # add a diff to it
       changeset_id = @response.body.to_i
 
       # add a diff to it

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
         <osmChange>
          <modify>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>


@@ -1279,7 +1279,7 @@ CHANGESET
           <node id='#{node.id}' lon='9' lat='9' changeset='#{changeset_id}' version='8'/>
          </modify>
         </osmChange>
           <node id='#{node.id}' lon='9' lat='9' changeset='#{changeset_id}' version='8'/>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff


@@ -1310,7 +1310,7 @@ CHANGESET
       assert_response :success
       changeset_id = @response.body.to_i
 
       assert_response :success
       changeset_id = @response.body.to_i
 

-      diff = <<OSMFILE.strip_heredoc
+      diff = <<~OSMFILE

         <osmChange version="0.6" generator="JOSM">
         <create version="0.6" generator="JOSM">
           <node id='-1' visible='true' changeset='#{changeset_id}' lat='51.49619982187321' lon='-0.18722061869438314' />
         <osmChange version="0.6" generator="JOSM">
         <create version="0.6" generator="JOSM">
           <node id='-1' visible='true' changeset='#{changeset_id}' lat='51.49619982187321' lon='-0.18722061869438314' />


@@ -1337,7 +1337,7 @@ CHANGESET
           </way>
         </create>
         </osmChange>
           </way>
         </create>
         </osmChange>

-OSMFILE
+      OSMFILE

 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff


@@ -1372,7 +1372,7 @@ OSMFILE
       changeset_id = @response.body.to_i
 
       # add a diff to it
       changeset_id = @response.body.to_i
 
       # add a diff to it

-      diff = <<CHANGESET.strip_heredoc
+      diff = <<~CHANGESET

         <osmChange>
          <delete>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
         <osmChange>
          <delete>
           <node id='#{node.id}' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>


@@ -1392,7 +1392,7 @@ OSMFILE
           </way>
          </modify>
         </osmChange>
           </way>
          </modify>
         </osmChange>

-CHANGESET
+      CHANGESET

 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff
 
       # upload it
       post :upload, :params => { :id => changeset_id }, :body => diff


@@ -1483,7 +1483,7 @@ CHANGESET
 
       # add (delete) a way to it, which contains a point at (3,3)
       with_controller(WaysController.new) do
 
       # add (delete) a way to it, which contains a point at (3,3)
       with_controller(WaysController.new) do

-        xml = update_changeset(way.to_xml, changeset_id)
+        xml = update_changeset(xml_for_way(way), changeset_id)

         put :delete, :params => { :id => way.id }, :body => xml.to_s
         assert_response :success, "Couldn't delete a way."
       end
         put :delete, :params => { :id => way.id }, :body => xml.to_s
         assert_response :success, "Couldn't delete a way."
       end