X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/017f7da76f3d59a71c3cca481e0d3a20afe1c046..45c90003c688988590e91108f2ec64a199050578:/test/controllers/api/messages_controller_test.rb diff --git a/test/controllers/api/messages_controller_test.rb b/test/controllers/api/messages_controller_test.rb index 91dbd42de..806a4a505 100644 --- a/test/controllers/api/messages_controller_test.rb +++ b/test/controllers/api/messages_controller_test.rb @@ -5,30 +5,6 @@ module Api ## # test all routes which lead to this controller def test_routes - assert_routing( - { :path => "/api/0.6/user/messages/inbox", :method => :get }, - { :controller => "api/messages", :action => "inbox" } - ) - assert_routing( - { :path => "/api/0.6/user/messages/inbox.xml", :method => :get }, - { :controller => "api/messages", :action => "inbox", :format => "xml" } - ) - assert_routing( - { :path => "/api/0.6/user/messages/inbox.json", :method => :get }, - { :controller => "api/messages", :action => "inbox", :format => "json" } - ) - assert_routing( - { :path => "/api/0.6/user/messages/outbox", :method => :get }, - { :controller => "api/messages", :action => "outbox" } - ) - assert_routing( - { :path => "/api/0.6/user/messages/outbox.xml", :method => :get }, - { :controller => "api/messages", :action => "outbox", :format => "xml" } - ) - assert_routing( - { :path => "/api/0.6/user/messages/outbox.json", :method => :get }, - { :controller => "api/messages", :action => "outbox", :format => "json" } - ) assert_routing( { :path => "/api/0.6/user/messages/1", :method => :get }, { :controller => "api/messages", :action => "show", :id => "1" } @@ -375,193 +351,5 @@ module Api assert_equal "markdown", jsm["body_format"] assert_equal msg.body, jsm["body"] end - - def test_list_messages - user1 = create(:user) - user1_auth = bearer_authorization_header(user1, :scopes => %w[send_messages consume_messages]) - - user2 = create(:user) - user2_auth = bearer_authorization_header(user2, :scopes => %w[send_messages consume_messages]) - - user3 = create(:user) - user3_auth = bearer_authorization_header(user3, :scopes => %w[send_messages consume_messages]) - - # create some messages between users - # user | inbox | outbox - # 1 | 0 | 3 - # 2 | 2 | 1 - # 3 | 2 | 0 - create(:message, :unread, :sender => user1, :recipient => user2) - create(:message, :unread, :sender => user1, :recipient => user2) - create(:message, :unread, :sender => user1, :recipient => user3) - create(:message, :unread, :sender => user2, :recipient => user3) - - # only authorized users - get inbox_api_messages_path - assert_response :unauthorized - get outbox_api_messages_path - assert_response :unauthorized - - # no messages in user1.inbox - get inbox_api_messages_path, :headers => user1_auth - assert_response :success - assert_equal "application/xml", response.media_type - assert_select "message", :count => 0 - - # 3 messages in user1.outbox - get outbox_api_messages_path, :headers => user1_auth - assert_response :success - assert_equal "application/xml", response.media_type - assert_select "message", :count => 3 do - assert_select "[from_user_id='#{user1.id}']" - assert_select "[from_display_name='#{user1.display_name}']" - assert_select "[to_user_id]" - assert_select "[to_display_name]" - assert_select "[sent_on]" - assert_select "[message_read]", 0 - assert_select "[deleted='false']" - assert_select "[body_format]" - assert_select "body", false - assert_select "title" - end - - # 2 messages in user2.inbox - get inbox_api_messages_path, :headers => user2_auth - assert_response :success - assert_equal "application/xml", response.media_type - assert_select "message", :count => 2 do - assert_select "[from_user_id]" - assert_select "[from_display_name]" - assert_select "[to_user_id='#{user2.id}']" - assert_select "[to_display_name='#{user2.display_name}']" - assert_select "[sent_on]" - assert_select "[message_read='false']" - assert_select "[deleted='false']" - assert_select "[body_format]" - assert_select "body", false - assert_select "title" - end - - # 1 message in user2.outbox - get outbox_api_messages_path, :headers => user2_auth - assert_response :success - assert_equal "application/xml", response.media_type - assert_select "message", :count => 1 do - assert_select "[from_user_id='#{user2.id}']" - assert_select "[from_display_name='#{user2.display_name}']" - assert_select "[to_user_id]" - assert_select "[to_display_name]" - assert_select "[sent_on]" - assert_select "[deleted='false']" - assert_select "[message_read]", 0 - assert_select "[body_format]" - assert_select "body", false - assert_select "title" - end - - # 2 messages in user3.inbox - get inbox_api_messages_path, :headers => user3_auth - assert_response :success - assert_equal "application/xml", response.media_type - assert_select "message", :count => 2 do - assert_select "[from_user_id]" - assert_select "[from_display_name]" - assert_select "[to_user_id='#{user3.id}']" - assert_select "[to_display_name='#{user3.display_name}']" - assert_select "[sent_on]" - assert_select "[message_read='false']" - assert_select "[deleted='false']" - assert_select "[body_format]" - assert_select "body", false - assert_select "title" - end - - # 0 messages in user3.outbox - get outbox_api_messages_path, :headers => user3_auth - assert_response :success - assert_equal "application/xml", response.media_type - assert_select "message", :count => 0 - end - - def test_paged_list_messages_asc - recipient = create(:user) - recipient_auth = bearer_authorization_header(recipient, :scopes => %w[consume_messages]) - - sender = create(:user) - - create_list(:message, 100, :unread, :sender => sender, :recipient => recipient) - - msgs_read = {} - params = { :order => "oldest", :limit => 20 } - 10.times do - get inbox_api_messages_path(:format => "json"), - :params => params, - :headers => recipient_auth - assert_response :success - assert_equal "application/json", response.media_type - js = ActiveSupport::JSON.decode(@response.body) - jsm = js["messages"] - assert_operator jsm.count, :<=, 20 - - break if jsm.nil? || jsm.count.zero? - - assert_operator(jsm[0]["id"], :>=, params[:from_id]) unless params[:from_id].nil? - # ensure ascending order - (0..jsm.count - 1).each do |i| - assert_operator(jsm[i]["id"], :<, jsm[i + 1]["id"]) unless i == jsm.count - 1 - msgs_read[jsm[i]["id"]] = jsm[i] - end - params[:from_id] = jsm[jsm.count - 1]["id"] - end - assert_equal 100, msgs_read.count - end - - def test_paged_list_messages_desc - recipient = create(:user) - recipient_auth = bearer_authorization_header(recipient, :scopes => %w[consume_messages]) - - sender = create(:user) - - create_list(:message, 100, :unread, :sender => sender, :recipient => recipient) - - real_max_id = -1 - msgs_read = {} - params = { :order => "newest", :limit => 20 } - 10.times do - get inbox_api_messages_path(:format => "json"), - :params => params, - :headers => recipient_auth - assert_response :success - assert_equal "application/json", response.media_type - js = ActiveSupport::JSON.decode(@response.body) - jsm = js["messages"] - assert_operator jsm.count, :<=, 20 - - break if jsm.nil? || jsm.count.zero? - - if params[:from_id].nil? - real_max_id = jsm[0]["id"] - else - assert_operator jsm[0]["id"], :<=, params[:from_id] - end - # ensure descending order - (0..jsm.count - 1).each do |i| - assert_operator(jsm[i]["id"], :>, jsm[i + 1]["id"]) unless i == jsm.count - 1 - msgs_read[jsm[i]["id"]] = jsm[i] - end - params[:from_id] = jsm[jsm.count - 1]["id"] - end - assert_equal 100, msgs_read.count - assert_not_equal(-1, real_max_id) - - # invoke without min_id/max_id parameters, verify that we get the last batch - get inbox_api_messages_path(:format => "json"), :params => { :limit => 20 }, :headers => recipient_auth - assert_response :success - assert_equal "application/json", response.media_type - js = ActiveSupport::JSON.decode(@response.body) - jsm = js["messages"] - assert_not_nil jsm - assert_equal real_max_id, jsm[0]["id"] - end end end