X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/02fbcf5f06917d7dea546b90932da82b8ed29d2a..8b12abd5bb1b96567ab882a3aca0780d0e4af67a:/test/unit/way_test.rb diff --git a/test/unit/way_test.rb b/test/unit/way_test.rb index cd565fd27..9c9ffe59a 100644 --- a/test/unit/way_test.rb +++ b/test/unit/way_test.rb @@ -1,8 +1,14 @@ require File.dirname(__FILE__) + '/../test_helper' -class WayTest < Test::Unit::TestCase +class WayTest < ActiveSupport::TestCase api_fixtures + # Check that we have the correct number of currnet ways in the db + # This will need to updated whenever the current_ways.yml is updated + def test_db_count + assert_equal 5, Way.count + end + def test_bbox node = current_nodes(:used_node_1) [ :visible_way, @@ -13,4 +19,117 @@ class WayTest < Test::Unit::TestCase end end + # Check that the preconditions fail when you are over the defined limit of + # the maximum number of nodes in each way. + def test_max_nodes_per_way_limit + # Take one of the current ways and add nodes to it until we are near the limit + way = Way.find(current_ways(:visible_way).id) + assert way.valid? + # it already has 1 node + 1.upto((MAX_NUMBER_OF_WAY_NODES) / 2) { + way.add_nd_num(current_nodes(:used_node_1).id) + way.add_nd_num(current_nodes(:used_node_2).id) + } + way.save + #print way.nds.size + assert way.valid? + way.add_nd_num(current_nodes(:visible_node).id) + assert way.valid? + end + + def test_from_xml_no_id + noid = "" + assert_nothing_raised(OSM::APIBadXMLError) { + Way.from_xml(noid, true) + } + message = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(noid, false) + } + assert_match /ID is required when updating/, message.message + end + + def test_from_xml_no_changeset_id + nocs = "" + message_create = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(nocs, true) + } + assert_match /Changeset id is missing/, message_create.message + message_update = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(nocs, false) + } + assert_match /Changeset id is missing/, message_update.message + end + + def test_from_xml_no_version + no_version = "" + assert_nothing_raised(OSM::APIBadXMLError) { + Way.from_xml(no_version, true) + } + message_update = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(no_version, false) + } + assert_match /Version is required when updating/, message_update.message + end + + def test_from_xml_id_zero + id_list = ["", "0", "00", "0.0", "a"] + id_list.each do |id| + zero_id = "" + assert_nothing_raised(OSM::APIBadUserInput) { + Way.from_xml(zero_id, true) + } + message_update = assert_raise(OSM::APIBadUserInput) { + Way.from_xml(zero_id, false) + } + assert_match /ID of way cannot be zero when updating/, message_update.message + end + end + + def test_from_xml_no_text + no_text = "" + message_create = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(no_text, true) + } + assert_match /Must specify a string with one or more characters/, message_create.message + message_update = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(no_text, false) + } + assert_match /Must specify a string with one or more characters/, message_update.message + end + + def test_from_xml_no_k_v + nokv = "" + message_create = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(nokv, true) + } + assert_match /tag is missing key/, message_create.message + message_update = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(nokv, false) + } + assert_match /tag is missing key/, message_update.message + end + + def test_from_xml_no_v + no_v = "" + message_create = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(no_v, true) + } + assert_match /tag is missing value/, message_create.message + message_update = assert_raise(OSM::APIBadXMLError) { + Way.from_xml(no_v, false) + } + assert_match /tag is missing value/, message_update.message + end + + def test_from_xml_duplicate_k + dupk = "" + message_create = assert_raise(OSM::APIDuplicateTagsError) { + Way.from_xml(dupk, true) + } + assert_equal "Element way/ has duplicate tags with key dup", message_create.message + message_update = assert_raise(OSM::APIDuplicateTagsError) { + Way.from_xml(dupk, false) + } + assert_equal "Element way/23 has duplicate tags with key dup", message_update.message + end end