X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/034982a12fa025af8c1d381cd09483c97fb29dbe..8225f0a6ea7cb1fd7007b8503fba7571e2b0d9fb:/app/controllers/geocoder_controller.rb diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb index f557668b6..489d89b58 100644 --- a/app/controllers/geocoder_controller.rb +++ b/app/controllers/geocoder_controller.rb @@ -21,15 +21,33 @@ class GeocoderController < ApplicationController results_count = count_results(results) render :update do |page| + page.replace_html :sidebar_content, :partial => 'results', :object => results + if results_count == 1 position = results.collect { |s| s[:results] }.compact.flatten[0] page.call "setPosition", position[:lat], position[:lon], position[:zoom] else - page.replace_html :search_results_content, :partial => 'results', :object => results - page.call "openSearchResults" + page.call "openSidebar" end end end + + def description + results = Array.new + + lat = params[:lat] + lon = params[:lon] + + results.push description_osm_namefinder("cities", lat, lon, 2) + results.push description_osm_namefinder("towns", lat, lon, 4) + results.push description_osm_namefinder("places", lat, lon, 10) + results.push description_geonames(lat, lon) + + render :update do |page| + page.replace_html :sidebar_content, :partial => 'results', :object => results + page.call "openSidebar" + end + end private @@ -37,7 +55,7 @@ private results = Array.new # ask geocoder.us (they have a non-commercial use api) - response = fetch_text("http://rpc.geocoder.us/service/csv?zip=#{URI.escape(query)}") + response = fetch_text("http://rpc.geocoder.us/service/csv?zip=#{escape_query(query)}") # parse the response unless response.match(/couldn't find this zip/) @@ -56,7 +74,7 @@ private results = Array.new # ask npemap.org.uk to do a combined npemap + freethepostcode search - response = fetch_text("http://www.npemap.org.uk/cgi/geocoder.fcgi?format=text&postcode=#{URI.escape(query)}") + response = fetch_text("http://www.npemap.org.uk/cgi/geocoder.fcgi?format=text&postcode=#{escape_query(query)}") # parse the response unless response.match(/Error/) @@ -75,7 +93,7 @@ private results = Array.new # ask geocoder.ca (note - they have a per-day limit) - response = fetch_xml("http://geocoder.ca/?geoit=XML&postal=#{URI.escape(query)}") + response = fetch_xml("http://geocoder.ca/?geoit=XML&postal=#{escape_query(query)}") # parse the response unless response.get_elements("geodata/error") @@ -94,7 +112,7 @@ private results = Array.new # ask OSM namefinder - response = fetch_xml("http://www.frankieandshadow.com/osm/search.xml?find=#{URI.escape(query)}") + response = fetch_xml("http://www.frankieandshadow.com/osm/search.xml?find=#{escape_query(query)}") # parse the response response.elements.each("searchresults/named") do |named| @@ -133,7 +151,7 @@ private results = Array.new # ask geonames.org - response = fetch_xml("http://ws.geonames.org/search?q=#{URI.escape(query)}&maxRows=20") + response = fetch_xml("http://ws.geonames.org/search?q=#{escape_query(query)}&maxRows=20") # parse the response response.elements.each("geonames/geoname") do |geoname| @@ -151,6 +169,52 @@ private return { :source => "GeoNames", :url => "http://www.geonames.org/", :error => "Error contacting ws.geonames.org: #{ex.to_s}" } end + def description_osm_namefinder(types, lat, lon, max) + results = Array.new + + # ask OSM namefinder + response = fetch_xml("http://www.frankieandshadow.com/osm/search.xml?find=#{types}+near+#{lat},#{lon}&max=#{max}") + + # parse the response + response.elements.each("searchresults/named") do |named| + lat = named.attributes["lat"].to_s + lon = named.attributes["lon"].to_s + zoom = named.attributes["zoom"].to_s + place = named.elements["place/named"] || named.elements["nearestplaces/named"] + type = named.attributes["info"].to_s + name = named.attributes["name"].to_s + description = named.elements["description"].to_s + distance = format_distance(place.attributes["approxdistance"].to_i) + direction = format_direction((place.attributes["direction"].to_i - 180) % 360) + prefix = "#{distance} #{direction} of #{type} " + results.push({:lat => lat, :lon => lon, :zoom => zoom, + :prefix => prefix.capitalize, :name => name, + :description => description}) + end + + return { :type => types.capitalize, :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :results => results } + rescue Exception => ex + return { :type => types.capitalize, :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :error => "Error contacting www.frankieandshadow.com: #{ex.to_s}" } + end + + def description_geonames(lat, lon) + results = Array.new + + # ask geonames.org + response = fetch_xml("http://ws.geonames.org/countrySubdivision?lat=#{lat}&lng=#{lon}") + + # parse the response + response.elements.each("geonames/countrySubdivision") do |geoname| + name = geoname.get_text("adminName1").to_s + country = geoname.get_text("countryName").to_s + results.push({:prefix => "#{name}, #{country}"}) + end + + return { :type => "Location", :source => "GeoNames", :url => "http://www.geonames.org/", :results => results } + rescue Exception => ex + return { :type => types.capitalize, :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :error => "Error contacting www.frankieandshadow.com: #{ex.to_s}" } + end + def fetch_text(url) return Net::HTTP.get(URI.parse(url)) end @@ -184,4 +248,8 @@ private return count end + + def escape_query(query) + return URI.escape(query, Regexp.new("[^#{URI::PATTERN::UNRESERVED}]", false, 'N')) + end end