X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/06b8558aaf911d643a7ab986dcc50d40f774d6b6..7de6943ebebc90db5f3cc61e6f3434f698833bd7:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 87bf43bc3..8c0827ab7 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2020-09-02 06:16:56 UTC using RuboCop version 0.90.0. +# on 2021-12-28 19:44:27 UTC using RuboCop version 1.24.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -12,18 +12,33 @@ require: - rubocop-minitest - rubocop-performance - rubocop-rails + - rubocop-rake -# Offense count: 568 +# Offense count: 544 # Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 370 + Max: 270 -# Offense count: 36 +# Offense count: 62 +# Cop supports --auto-correct. +Lint/AmbiguousOperatorPrecedence: + Exclude: + - 'app/controllers/geocoder_controller.rb' + - 'app/models/user.rb' + - 'lib/bounding_box.rb' + - 'lib/osm.rb' + - 'lib/rich_text.rb' + - 'lib/short_link.rb' + - 'test/controllers/api/old_nodes_controller_test.rb' + - 'test/lib/short_link_test.rb' + +# Offense count: 34 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/accounts_controller.rb' - 'app/controllers/api/traces_controller.rb' - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' @@ -33,20 +48,29 @@ Lint/AssignmentInCondition: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_tags_helper.rb' - - 'app/mailers/notifier.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 682 -# Configuration parameters: IgnoredMethods. +# Offense count: 7 +# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. +Lint/DuplicateBranch: + Exclude: + - 'app/controllers/api_controller.rb' + - 'app/controllers/diary_entries_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/helpers/browse_tags_helper.rb' + +# Offense count: 663 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: - Max: 194 + Max: 189 # Offense count: 72 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. -# ExcludedMethods: refine +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine Metrics/BlockLength: Max: 71 @@ -58,55 +82,38 @@ Metrics/BlockNesting: # Offense count: 25 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 643 + Max: 313 -# Offense count: 68 +# Offense count: 57 # Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 26 + Max: 25 -# Offense count: 735 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. +# Offense count: 739 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 -# Offense count: 4 -# Configuration parameters: CountKeywordArgs. +# Offense count: 1 +# Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: - Max: 9 + Max: 6 -# Offense count: 69 +# Offense count: 59 # Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: Max: 26 -# Offense count: 540 +# Offense count: 549 Minitest/MultipleAssertions: - Max: 81 - -# Offense count: 26 -# Cop supports --auto-correct. -Minitest/TestMethodName: - Exclude: - - 'test/abilities/api_capability_test.rb' - - 'test/controllers/api/nodes_controller_test.rb' - - 'test/controllers/api/old_nodes_controller_test.rb' - - 'test/controllers/api/relations_controller_test.rb' - - 'test/controllers/api/ways_controller_test.rb' - - 'test/helpers/browse_helper_test.rb' - - 'test/integration/client_applications_test.rb' - - 'test/integration/short_links_test.rb' - - 'test/integration/user_blocks_test.rb' - - 'test/integration/user_creation_test.rb' + Max: 52 -# Offense count: 6 +# Offense count: 3 Naming/AccessorMethodName: Exclude: - 'app/controllers/application_controller.rb' - 'app/helpers/title_helper.rb' - - 'app/models/old_way.rb' - 'lib/osm.rb' - - 'lib/potlatch.rb' # Offense count: 8 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. @@ -116,7 +123,6 @@ Naming/AccessorMethodName: # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: - - 'spec/**/*' - 'app/models/changeset.rb' - 'app/models/old_node.rb' - 'app/models/old_relation.rb' @@ -142,7 +148,7 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' -# Offense count: 4 +# Offense count: 3 # Configuration parameters: Include. # Include: app/helpers/**/*.rb Rails/HelperInstanceVariable: @@ -150,12 +156,12 @@ Rails/HelperInstanceVariable: - 'app/helpers/title_helper.rb' # Offense count: 1 -# Cop supports --auto-correct. # Configuration parameters: Include. -# Include: app/mailers/**/*.rb -Rails/MailerName: +# Include: app/controllers/**/*.rb +Rails/LexicallyScopedActionFilter: Exclude: - - 'app/mailers/notifier.rb' + - 'app/controllers/oauth2_applications_controller.rb' + - 'app/controllers/oauth2_authorizations_controller.rb' # Offense count: 5 # Configuration parameters: Include. @@ -168,71 +174,45 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 19 +# Offense count: 9 Rails/OutputSafety: Exclude: + - 'app/controllers/sessions_controller.rb' - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changesets_helper.rb' - - 'app/helpers/geocoder_helper.rb' - - 'app/helpers/note_helper.rb' - - 'app/helpers/open_graph_helper.rb' - - 'app/helpers/user_blocks_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 95 +# Offense count: 23 +# Cop supports --auto-correct. +Rails/RedundantPresenceValidationOnBelongsTo: + Enabled: false + +# Offense count: 90 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: Enabled: false -# Offense count: 1 -Style/CombinableLoops: +# Offense count: 6 +# Cop supports --auto-correct. +Rake/Desc: Exclude: - - 'db/migrate/021_move_to_innodb.rb' + - 'lib/tasks/auto_annotate_models.rake' + - 'lib/tasks/eslint.rake' + - 'lib/tasks/subscribe_diary_authors.rake' + - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 572 +# Offense count: 609 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 78 +# Offense count: 72 # Cop supports --auto-correct. -# Configuration parameters: Strict. +# Configuration parameters: Strict, AllowedNumbers. Style/NumericLiterals: - MinDigits: 11 - -# Offense count: 20 -Style/OptionalBooleanParameter: - Exclude: - - 'app/controllers/api/notes_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/helpers/browse_helper.rb' - - 'app/models/changeset.rb' - - 'app/models/node.rb' - - 'app/models/relation.rb' - - 'app/models/trace.rb' - - 'app/models/tracepoint.rb' - - 'app/models/way.rb' - - 'test/models/diary_entry_test.rb' - - 'test/models/trace_test.rb' - - 'test/models/tracetag_test.rb' - -# Offense count: 6 -# Configuration parameters: AllowModifier. -Style/SoleNestedConditional: - Exclude: - - 'app/controllers/user_blocks_controller.rb' - - 'app/models/old_way.rb' - - 'app/validators/characters_validator.rb' - - 'app/validators/whitespace_validator.rb' - - 'lib/classic_pagination/pagination.rb' - -# Offense count: 28 -# Cop supports --auto-correct. -Style/StringConcatenation: - Enabled: false + MinDigits: 15