X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/0814b4096c443e2ab3c09baa058aa81a00d205d1..c69c547d01a03f5be7cbd1d2f27881fdde31bbda:/test/models/trace_test.rb diff --git a/test/models/trace_test.rb b/test/models/trace_test.rb index c9530b067..f95ebe4c3 100644 --- a/test/models/trace_test.rb +++ b/test/models/trace_test.rb @@ -1,26 +1,7 @@ require "test_helper" -require "digest" -require "minitest/mock" +require "gpx" class TraceTest < ActiveSupport::TestCase - fixtures :users - - def setup - @gpx_trace_dir = Object.send("remove_const", "GPX_TRACE_DIR") - Object.const_set("GPX_TRACE_DIR", File.dirname(__FILE__) + "/../traces") - - @gpx_image_dir = Object.send("remove_const", "GPX_IMAGE_DIR") - Object.const_set("GPX_IMAGE_DIR", File.dirname(__FILE__) + "/../traces") - end - - def teardown - Object.send("remove_const", "GPX_TRACE_DIR") - Object.const_set("GPX_TRACE_DIR", @gpx_trace_dir) - - Object.send("remove_const", "GPX_IMAGE_DIR") - Object.const_set("GPX_IMAGE_DIR", @gpx_image_dir) - end - def test_visible public_trace_file = create(:trace) create(:trace, :deleted) @@ -28,21 +9,25 @@ class TraceTest < ActiveSupport::TestCase end def test_visible_to - public_trace_file = create(:trace, :visibility => "public", :user => users(:normal_user)) - anon_trace_file = create(:trace, :visibility => "private", :user => users(:public_user)) - identifiable_trace_file = create(:trace, :visibility => "identifiable", :user => users(:normal_user)) - pending_trace_file = create(:trace, :visibility => "public", :user => users(:public_user), :inserted => false) - trackable_trace_file = create(:trace, :visibility => "trackable", :user => users(:public_user)) - _other_trace_file = create(:trace, :visibility => "private", :user => users(:second_public_user)) - - check_query(Trace.visible_to(users(:normal_user).id), [ + first_user = create(:user) + second_user = create(:user) + third_user = create(:user) + fourth_user = create(:user) + public_trace_file = create(:trace, :visibility => "public", :user => first_user) + anon_trace_file = create(:trace, :visibility => "private", :user => second_user) + identifiable_trace_file = create(:trace, :visibility => "identifiable", :user => first_user) + pending_trace_file = create(:trace, :visibility => "public", :user => second_user, :inserted => false) + trackable_trace_file = create(:trace, :visibility => "trackable", :user => second_user) + _other_trace_file = create(:trace, :visibility => "private", :user => third_user) + + check_query(Trace.visible_to(first_user), [ public_trace_file, identifiable_trace_file, pending_trace_file ]) - check_query(Trace.visible_to(users(:public_user)), [ + check_query(Trace.visible_to(second_user), [ public_trace_file, anon_trace_file, trackable_trace_file, identifiable_trace_file, pending_trace_file ]) - check_query(Trace.visible_to(users(:inactive_user)), [ + check_query(Trace.visible_to(fourth_user), [ public_trace_file, identifiable_trace_file, pending_trace_file ]) end @@ -75,30 +60,34 @@ class TraceTest < ActiveSupport::TestCase def test_validations trace_valid({}) - trace_valid({ :user_id => nil }, false) - trace_valid(:name => "a" * 255) - trace_valid({ :name => "a" * 256 }, false) - trace_valid({ :description => nil }, false) - trace_valid(:description => "a" * 255) - trace_valid({ :description => "a" * 256 }, false) - trace_valid(:visibility => "private") - trace_valid(:visibility => "public") - trace_valid(:visibility => "trackable") - trace_valid(:visibility => "identifiable") - trace_valid({ :visibility => "foo" }, false) - end - - def test_tagstring + trace_valid({ :user_id => nil }, :valid => false) + trace_valid({ :name => "a" * 255 }) + trace_valid({ :name => "a" * 256 }, :valid => false) + trace_valid({ :description => nil }, :valid => false) + trace_valid({ :description => "a" * 255 }) + trace_valid({ :description => "a" * 256 }, :valid => false) + trace_valid({ :visibility => "private" }) + trace_valid({ :visibility => "public" }) + trace_valid({ :visibility => "trackable" }) + trace_valid({ :visibility => "identifiable" }) + trace_valid({ :visibility => "foo" }, :valid => false) + end + + def test_tagstring_handles_space_separated_tags trace = build(:trace) trace.tagstring = "foo bar baz" - assert trace.valid? + assert_predicate trace, :valid? assert_equal 3, trace.tags.length assert_equal "foo", trace.tags[0].tag assert_equal "bar", trace.tags[1].tag assert_equal "baz", trace.tags[2].tag assert_equal "foo, bar, baz", trace.tagstring + end + + def test_tagstring_handles_comma_separated_tags + trace = build(:trace) trace.tagstring = "foo, bar baz ,qux" - assert trace.valid? + assert_predicate trace, :valid? assert_equal 3, trace.tags.length assert_equal "foo", trace.tags[0].tag assert_equal "bar baz", trace.tags[1].tag @@ -106,28 +95,39 @@ class TraceTest < ActiveSupport::TestCase assert_equal "foo, bar baz, qux", trace.tagstring end + def test_tagstring_strips_whitespace + trace = build(:trace) + trace.tagstring = " zero , one , two " + assert_predicate trace, :valid? + assert_equal 3, trace.tags.length + assert_equal "zero", trace.tags[0].tag + assert_equal "one", trace.tags[1].tag + assert_equal "two", trace.tags[2].tag + assert_equal "zero, one, two", trace.tagstring + end + def test_public? - assert_equal true, build(:trace, :visibility => "public").public? - assert_equal false, build(:trace, :visibility => "private").public? - assert_equal false, build(:trace, :visibility => "trackable").public? - assert_equal true, build(:trace, :visibility => "identifiable").public? - assert_equal true, build(:trace, :deleted, :visibility => "public").public? + assert_predicate build(:trace, :visibility => "public"), :public? + assert_not_predicate build(:trace, :visibility => "private"), :public? + assert_not_predicate build(:trace, :visibility => "trackable"), :public? + assert_predicate build(:trace, :visibility => "identifiable"), :public? + assert_predicate build(:trace, :deleted, :visibility => "public"), :public? end def test_trackable? - assert_equal false, build(:trace, :visibility => "public").trackable? - assert_equal false, build(:trace, :visibility => "private").trackable? - assert_equal true, build(:trace, :visibility => "trackable").trackable? - assert_equal true, build(:trace, :visibility => "identifiable").trackable? - assert_equal false, build(:trace, :deleted, :visibility => "public").trackable? + assert_not_predicate build(:trace, :visibility => "public"), :trackable? + assert_not_predicate build(:trace, :visibility => "private"), :trackable? + assert_predicate build(:trace, :visibility => "trackable"), :trackable? + assert_predicate build(:trace, :visibility => "identifiable"), :trackable? + assert_not_predicate build(:trace, :deleted, :visibility => "public"), :trackable? end def test_identifiable? - assert_equal false, build(:trace, :visibility => "public").identifiable? - assert_equal false, build(:trace, :visibility => "private").identifiable? - assert_equal false, build(:trace, :visibility => "trackable").identifiable? - assert_equal true, build(:trace, :visibility => "identifiable").identifiable? - assert_equal false, build(:trace, :deleted, :visibility => "public").identifiable? + assert_not_predicate build(:trace, :visibility => "public"), :identifiable? + assert_not_predicate build(:trace, :visibility => "private"), :identifiable? + assert_not_predicate build(:trace, :visibility => "trackable"), :identifiable? + assert_predicate build(:trace, :visibility => "identifiable"), :identifiable? + assert_not_predicate build(:trace, :deleted, :visibility => "public"), :identifiable? end def test_mime_type @@ -135,11 +135,11 @@ class TraceTest < ActiveSupport::TestCase check_mime_type("a", "application/gpx+xml") check_mime_type("b", "application/gpx+xml") check_mime_type("c", "application/x-bzip2") - check_mime_type("d", "application/x-gzip") - check_mime_type("f", "application/x-zip") + check_mime_type("d", "application/gzip") + check_mime_type("f", "application/zip") check_mime_type("g", "application/x-tar") - check_mime_type("h", "application/x-gzip") - check_mime_type("i", "application/x-bzip2") + check_mime_type("h", "application/x-tar+gzip") + check_mime_type("i", "application/x-tar+x-bzip2") end def test_extension_name @@ -156,41 +156,149 @@ class TraceTest < ActiveSupport::TestCase def test_xml_file check_xml_file("a", "848caa72f2f456d1bd6a0fdf228aa1b9") - check_xml_file("b", "66179ca44f1e93d8df62e2b88cbea732") + check_xml_file("b", "db4cb5ed2d7d2b627b3b504296c4f701") check_xml_file("c", "848caa72f2f456d1bd6a0fdf228aa1b9") check_xml_file("d", "abd6675fdf3024a84fc0a1deac147c0d") - check_xml_file("f", "848caa72f2f456d1bd6a0fdf228aa1b9") - check_xml_file("g", "848caa72f2f456d1bd6a0fdf228aa1b9") - check_xml_file("h", "848caa72f2f456d1bd6a0fdf228aa1b9") - check_xml_file("i", "848caa72f2f456d1bd6a0fdf228aa1b9") + check_xml_file("f", "a7c05d676c77dc14369c21be216a3713") + check_xml_file("g", "a7c05d676c77dc14369c21be216a3713") + check_xml_file("h", "a7c05d676c77dc14369c21be216a3713") + check_xml_file("i", "a7c05d676c77dc14369c21be216a3713") end def test_large_picture - trace = create(:trace) - picture = trace.stub :large_picture_name, "#{GPX_IMAGE_DIR}/a.gif" do - trace.large_picture - end + picture = Rails.root.join("test/gpx/fixtures/a.gif").read(:mode => "rb") + trace = create(:trace, :fixture => "a") - trace = Trace.create - trace.large_picture = picture - assert_equal "7c841749e084ee4a5d13f12cd3bef456", md5sum(File.new(trace.large_picture_name)) assert_equal picture, trace.large_picture - - trace.destroy end def test_icon_picture - trace = create(:trace) - picture = trace.stub :icon_picture_name, "#{GPX_IMAGE_DIR}/a_icon.gif" do - trace.icon_picture - end + picture = Rails.root.join("test/gpx/fixtures/a_icon.gif").read(:mode => "rb") + trace = create(:trace, :fixture => "a") - trace = Trace.create - trace.icon_picture = picture - assert_equal "b47baf22ed0e85d77e808694fad0ee27", md5sum(File.new(trace.icon_picture_name)) assert_equal picture, trace.icon_picture + end - trace.destroy + def test_import_removes_previous_tracepoints + trace = create(:trace, :fixture => "a") + # Tracepoints don't have a primary key, so we use a specific latitude to + # check for successful deletion + create(:tracepoint, :latitude => 54321, :trace => trace) + assert_equal 1, Tracepoint.where(:latitude => 54321).count + + trace.import + + assert_equal 0, Tracepoint.where(:latitude => 54321).count + end + + def test_import_creates_tracepoints + trace = create(:trace, :fixture => "a") + assert_equal 0, Tracepoint.where(:trace => trace).count + + trace.import + + trace.reload + assert_equal 1, Tracepoint.where(:trace => trace).count + + # Check that the tile has been set prior to the bulk import + # i.e. that the callbacks have been run correctly + assert_equal 3221331576, Tracepoint.find_by(:trace => trace).tile + end + + def test_import_creates_icon + trace = create(:trace, :inserted => false, :fixture => "a") + + assert_not_predicate trace.icon, :attached? + + trace.import + + assert_predicate trace.icon, :attached? + end + + def test_import_creates_large_picture + trace = create(:trace, :inserted => false, :fixture => "a") + + assert_not_predicate trace.image, :attached? + + trace.import + + assert_predicate trace.image, :attached? + end + + def test_import_handles_bz2 + trace = create(:trace, :inserted => false, :fixture => "c") + + trace.import + + assert_equal 1, trace.size + end + + def test_import_handles_plain + trace = create(:trace, :inserted => false, :fixture => "a") + + trace.import + + assert_equal 1, trace.size + end + + def test_import_handles_plain_with_bom + trace = create(:trace, :inserted => false, :fixture => "b") + + trace.import + + assert_equal 1, trace.size + end + + def test_import_handles_gz + trace = create(:trace, :inserted => false, :fixture => "d") + + trace.import + + assert_equal 1, trace.size + end + + def test_import_handles_zip + trace = create(:trace, :inserted => false, :fixture => "f") + + trace.import + + assert_equal 2, trace.size + end + + def test_import_handles_tar + trace = create(:trace, :inserted => false, :fixture => "g") + + trace.import + + assert_equal 2, trace.size + end + + def test_import_handles_tar_gz + trace = create(:trace, :inserted => false, :fixture => "h") + + trace.import + + assert_equal 2, trace.size + end + + def test_import_handles_tar_bz2 + trace = create(:trace, :inserted => false, :fixture => "i") + + trace.import + + assert_equal 2, trace.size + end + + def test_import_enforces_limit + trace = create(:trace, :inserted => false, :fixture => "f") + + with_settings(:max_trace_size => 1) do + assert_raise GPX::FileTooBigError do + trace.import + end + end + + assert_not trace.inserted end private @@ -201,30 +309,20 @@ class TraceTest < ActiveSupport::TestCase end def check_mime_type(id, mime_type) - trace = create(:trace) - trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do - assert_equal mime_type, trace.mime_type - end + assert_equal mime_type, create(:trace, :fixture => id).mime_type end def check_extension_name(id, extension_name) - trace = create(:trace) - trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do - assert_equal extension_name, trace.extension_name - end + assert_equal extension_name, create(:trace, :fixture => id).extension_name end def check_xml_file(id, md5sum) - trace = create(:trace) - trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do - assert_equal md5sum, md5sum(trace.xml_file) - end + assert_equal md5sum, md5sum(create(:trace, :fixture => id).xml_file) end - def trace_valid(attrs, result = true) - entry = build(:trace) - entry.assign_attributes(attrs) - assert_equal result, entry.valid?, "Expected #{attrs.inspect} to be #{result}" + def trace_valid(attrs, valid: true) + entry = build(:trace, attrs) + assert_equal valid, entry.valid?, "Expected #{attrs.inspect} to be #{valid}" end def md5sum(io)