X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/0cb97bd7d96030c07d9716c3d26d39bcd4f712ff..e2f55c1c1b3345be7c7737a27eb27c8964420b9c:/app/models/old_node.rb?ds=sidebyside diff --git a/app/models/old_node.rb b/app/models/old_node.rb index 7bafca053..ab25d4dbc 100644 --- a/app/models/old_node.rb +++ b/app/models/old_node.rb @@ -1,23 +1,26 @@ class OldNode < ActiveRecord::Base include GeoRecord + include ConsistencyValidations - set_table_name 'nodes' - - validates_presence_of :user_id, :timestamp + self.table_name = "nodes" + self.primary_keys = "node_id", "version" + + # note this needs to be included after the table name changes, or + # the queries generated by Redactable will use the wrong table name. + include Redactable + + validates_presence_of :changeset_id, :timestamp validates_inclusion_of :visible, :in => [ true, false ] validates_numericality_of :latitude, :longitude validate :validate_position + validates_associated :changeset - belongs_to :user - - def validate_position - errors.add_to_base("Node is not in the world") unless in_world? - end + belongs_to :changeset + belongs_to :redaction + belongs_to :current_node, :class_name => "Node", :foreign_key => "node_id" - def in_world? - return false if self.lat < -90 or self.lat > 90 - return false if self.lon < -180 or self.lon > 180 - return true + def validate_position + errors.add(:base, "Node is not in the world") unless in_world? end def self.from_node(node) @@ -27,19 +30,51 @@ class OldNode < ActiveRecord::Base old_node.visible = node.visible old_node.tags = node.tags old_node.timestamp = node.timestamp - old_node.user_id = node.user_id - old_node.id = node.id + old_node.changeset_id = node.changeset_id + old_node.node_id = node.id + old_node.version = node.version return old_node end + + def to_xml + doc = OSM::API.new.get_xml_doc + doc.root << to_xml_node() + return doc + end - def to_xml_node + def to_xml_node(changeset_cache = {}, user_display_name_cache = {}) el1 = XML::Node.new 'node' - el1['id'] = self.id.to_s - el1['lat'] = self.lat.to_s - el1['lon'] = self.lon.to_s - el1['user'] = self.user.display_name if self.user.data_public? + el1['id'] = self.node_id.to_s + el1['version'] = self.version.to_s + el1['changeset'] = self.changeset_id.to_s + + if self.visible? + el1['lat'] = self.lat.to_s + el1['lon'] = self.lon.to_s + end + + if changeset_cache.key?(self.changeset_id) + # use the cache if available + else + changeset_cache[self.changeset_id] = self.changeset.user_id + end + + user_id = changeset_cache[self.changeset_id] + + if user_display_name_cache.key?(user_id) + # use the cache if available + elsif self.changeset.user.data_public? + user_display_name_cache[user_id] = self.changeset.user.display_name + else + user_display_name_cache[user_id] = nil + end - Tags.split(self.tags) do |k,v| + if not user_display_name_cache[user_id].nil? + el1['user'] = user_display_name_cache[user_id] + el1['uid'] = user_id.to_s + end + + self.tags.each do |k,v| el2 = XML::Node.new('tag') el2['k'] = k.to_s el2['v'] = v.to_s @@ -48,14 +83,62 @@ class OldNode < ActiveRecord::Base el1['visible'] = self.visible.to_s el1['timestamp'] = self.timestamp.xmlschema + + el1['redacted'] = self.redaction.id.to_s if self.redacted? + return el1 end - - def tags_as_hash - hash = {} - Tags.split(self.tags) do |k,v| - hash[k] = v + + def save_with_dependencies! + save! + #not sure whats going on here + clear_aggregation_cache + clear_association_cache + #ok from here + @attributes.update(OldNode.where(:node_id => self.node_id, :timestamp => self.timestamp, :version => self.version).first.instance_variable_get('@attributes')) + + self.tags.each do |k,v| + tag = OldNodeTag.new + tag.k = k + tag.v = v + tag.node_id = self.node_id + tag.version = self.version + tag.save! + end + end + + def tags + unless @tags + @tags = Hash.new + OldNodeTag.where(:node_id => self.node_id, :version => self.version).each do |tag| + @tags[tag.k] = tag.v + end end - hash + @tags = Hash.new unless @tags + @tags + end + + def tags=(t) + @tags = t + end + + def tags_as_hash + return self.tags + end + + # Pretend we're not in any ways + def ways + return [] + end + + # Pretend we're not in any relations + def containing_relation_members + return [] + end + + # check whether this element is the latest version - that is, + # has the same version as its "current" counterpart. + def is_latest_version? + current_node.version == self.version end end