X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/0d936de9c90f0bf7ab9fe672c3ca8c7397d9ac85..6094a97ce6297d390e5bbf733f5c2b4cc6b2076c:/.rubocop.yml?ds=inline diff --git a/.rubocop.yml b/.rubocop.yml index 5bf565c31..60d144544 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,11 +1,18 @@ inherit_from: .rubocop_todo.yml require: + - rubocop-capybara + - rubocop-factory_bot + - rubocop-minitest - rubocop-performance - rubocop-rails + - rubocop-rake AllCops: - TargetRubyVersion: 2.5 + TargetRubyVersion: 3.1 + NewCops: enable + Exclude: + - 'vendor/**/*' Rails: Enabled: true @@ -19,21 +26,35 @@ Lint/PercentStringArray: - 'app/controllers/application_controller.rb' - 'app/controllers/site_controller.rb' +Metrics/BlockLength: + Exclude: + - 'config/routes.rb' + +Metrics/ClassLength: + Exclude: + - 'test/**/*' + +Metrics/ModuleLength: + Max: 150 + Naming/FileName: Exclude: - 'script/deliver-message' - - 'script/locale/reload-languages' - 'script/update-spam-blocks' -Naming/UncommunicativeMethodParamName: +Naming/MethodParameterName: Enabled: false -Rails/ApplicationRecord: +# This conflicts with Strong Migrations, which can't check `change_table` +Rails/BulkChangeTable: Enabled: false Rails/CreateTableWithTimestamps: Enabled: false +Rails/FindBy: + IgnoreWhereFirst: false + Rails/FindEach: Enabled: false @@ -43,19 +64,20 @@ Rails/HasManyOrHasOneDependent: Rails/HttpPositionalArguments: Enabled: false -Rails/InverseOf: +Rails/ReflectionClassName: Enabled: false Rails/SkipsModelValidations: Exclude: - 'db/migrate/*.rb' - - 'app/controllers/users_controller.rb' + - 'app/controllers/users/lists_controller.rb' -Style/BracesAroundHashParameters: - EnforcedStyle: context_dependent +Style/Documentation: + Enabled: false Style/FormatStringToken: - EnforcedStyle: template + Exclude: + - 'config/routes.rb' Style/IfInsideElse: Enabled: false @@ -63,12 +85,21 @@ Style/IfInsideElse: Style/GuardClause: Enabled: false +Style/HashEachMethods: + Enabled: true + Style/HashSyntax: EnforcedStyle: hash_rockets Exclude: - 'lib/tasks/testing.rake' - 'config/initializers/wrap_parameters.rb' +Style/HashTransformKeys: + Enabled: true + +Style/HashTransformValues: + Enabled: true + Style/MixinUsage: Exclude: - 'bin/setup'