X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/109e69efc186113380eccca35bfdb4bd83365db5..95abc14b305f03de27352a252a451d1e0b200a4d:/test/integration/user_creation_test.rb?ds=sidebyside

diff --git a/test/integration/user_creation_test.rb b/test/integration/user_creation_test.rb
index db35be5f3..93e55939c 100644
--- a/test/integration/user_creation_test.rb
+++ b/test/integration/user_creation_test.rb
@@ -1,8 +1,6 @@
 require "test_helper"
 
 class UserCreationTest < ActionDispatch::IntegrationTest
-  fixtures :users
-
   def setup
     I18n.locale = "en"
 
@@ -33,7 +31,7 @@ class UserCreationTest < ActionDispatch::IntegrationTest
 
   def test_user_create_submit_duplicate_email
     I18n.available_locales.each do |locale|
-      dup_email = users(:public_user).email
+      dup_email = create(:user).email
       display_name = "#{locale}_new_tester"
       assert_difference("User.count", 0) do
         assert_difference("ActionMailer::Base.deliveries.size", 0) do
@@ -52,7 +50,7 @@ class UserCreationTest < ActionDispatch::IntegrationTest
 
   def test_user_create_submit_duplicate_username
     I18n.available_locales.each do |locale|
-      dup_display_name = users(:public_user).display_name
+      dup_display_name = create(:user).display_name
       email = "#{locale}_new_tester"
       assert_difference("User.count", 0) do
         assert_difference("ActionMailer::Base.deliveries.size", 0) do
@@ -92,7 +90,7 @@ class UserCreationTest < ActionDispatch::IntegrationTest
       # Check the e-mail
       register_email = ActionMailer::Base.deliveries.first
 
-      assert_equal register_email.to[0], new_email
+      assert_equal register_email.to.first, new_email
       # Check that the confirm account url is correct
       assert_match /#{@url}/, register_email.body.to_s
 
@@ -132,13 +130,13 @@ class UserCreationTest < ActionDispatch::IntegrationTest
     # Check the e-mail
     register_email = ActionMailer::Base.deliveries.first
 
-    assert_equal register_email.to[0], new_email
+    assert_equal register_email.to.first, new_email
     # Check that the confirm account url is correct
     confirm_regex = Regexp.new("/user/redirect_tester/confirm\\?confirm_string=([a-zA-Z0-9]*)")
-    register_email.parts.each do |part|
+    email_text_parts(register_email).each do |part|
       assert_match confirm_regex, part.body.to_s
     end
-    confirm_string = register_email.parts[0].body.match(confirm_regex)[1]
+    confirm_string = email_text_parts(register_email).first.body.match(confirm_regex)[1]
 
     # Check the page
     assert_response :success
@@ -245,13 +243,13 @@ class UserCreationTest < ActionDispatch::IntegrationTest
     # Check the e-mail
     register_email = ActionMailer::Base.deliveries.first
 
-    assert_equal register_email.to[0], new_email
+    assert_equal register_email.to.first, new_email
     # Check that the confirm account url is correct
     confirm_regex = Regexp.new("/user/redirect_tester_openid/confirm\\?confirm_string=([a-zA-Z0-9]*)")
-    register_email.parts.each do |part|
+    email_text_parts(register_email).each do |part|
       assert_match confirm_regex, part.body.to_s
     end
-    confirm_string = register_email.parts[0].body.match(confirm_regex)[1]
+    confirm_string = email_text_parts(register_email).first.body.match(confirm_regex)[1]
 
     # Check the page
     assert_response :success
@@ -362,13 +360,13 @@ class UserCreationTest < ActionDispatch::IntegrationTest
     # Check the e-mail
     register_email = ActionMailer::Base.deliveries.first
 
-    assert_equal register_email.to[0], new_email
+    assert_equal register_email.to.first, new_email
     # Check that the confirm account url is correct
     confirm_regex = Regexp.new("/user/redirect_tester_google/confirm\\?confirm_string=([a-zA-Z0-9]*)")
-    register_email.parts.each do |part|
+    email_text_parts(register_email).each do |part|
       assert_match confirm_regex, part.body.to_s
     end
-    confirm_string = register_email.parts[0].body.match(confirm_regex)[1]
+    confirm_string = email_text_parts(register_email).first.body.match(confirm_regex)[1]
 
     # Check the page
     assert_response :success
@@ -475,13 +473,13 @@ class UserCreationTest < ActionDispatch::IntegrationTest
     # Check the e-mail
     register_email = ActionMailer::Base.deliveries.first
 
-    assert_equal register_email.to[0], new_email
+    assert_equal register_email.to.first, new_email
     # Check that the confirm account url is correct
     confirm_regex = Regexp.new("/user/redirect_tester_facebook/confirm\\?confirm_string=([a-zA-Z0-9]*)")
-    register_email.parts.each do |part|
+    email_text_parts(register_email).each do |part|
       assert_match confirm_regex, part.body.to_s
     end
-    confirm_string = register_email.parts[0].body.match(confirm_regex)[1]
+    confirm_string = email_text_parts(register_email).first.body.match(confirm_regex)[1]
 
     # Check the page
     assert_response :success
@@ -515,7 +513,7 @@ class UserCreationTest < ActionDispatch::IntegrationTest
         assert_redirected_to auth_path(:provider => "windowslive", :origin => "/user/new")
         follow_redirect!
         assert_response :redirect
-        assert_redirected_to auth_success_path(:provider => "windowslive", :origin => "/user/new")
+        assert_redirected_to auth_success_path(:provider => "windowslive")
         follow_redirect!
         assert_response :redirect
         assert_redirected_to "/user/terms"
@@ -546,7 +544,7 @@ class UserCreationTest < ActionDispatch::IntegrationTest
         assert_redirected_to auth_path(:provider => "windowslive", :origin => "/user/new")
         follow_redirect!
         assert_response :redirect
-        assert_redirected_to auth_success_path(:provider => "windowslive", :origin => "/user/new")
+        assert_redirected_to auth_success_path(:provider => "windowslive")
         follow_redirect!
         assert_response :redirect
         assert_redirected_to auth_failure_path(:strategy => "windowslive", :message => "connection_failed", :origin => "/user/new")
@@ -576,7 +574,7 @@ class UserCreationTest < ActionDispatch::IntegrationTest
         assert_redirected_to auth_path(:provider => "windowslive", :origin => "/user/new")
         follow_redirect!
         assert_response :redirect
-        assert_redirected_to auth_success_path(:provider => "windowslive", :origin => "/user/new")
+        assert_redirected_to auth_success_path(:provider => "windowslive")
         follow_redirect!
         assert_response :redirect
         assert_redirected_to "/user/terms"
@@ -588,13 +586,13 @@ class UserCreationTest < ActionDispatch::IntegrationTest
     # Check the e-mail
     register_email = ActionMailer::Base.deliveries.first
 
-    assert_equal register_email.to[0], new_email
+    assert_equal register_email.to.first, new_email
     # Check that the confirm account url is correct
     confirm_regex = Regexp.new("/user/redirect_tester_windowslive/confirm\\?confirm_string=([a-zA-Z0-9]*)")
-    register_email.parts.each do |part|
+    email_text_parts(register_email).each do |part|
       assert_match confirm_regex, part.body.to_s
     end
-    confirm_string = register_email.parts[0].body.match(confirm_regex)[1]
+    confirm_string = email_text_parts(register_email).first.body.match(confirm_regex)[1]
 
     # Check the page
     assert_response :success
@@ -701,13 +699,13 @@ class UserCreationTest < ActionDispatch::IntegrationTest
     # Check the e-mail
     register_email = ActionMailer::Base.deliveries.first
 
-    assert_equal register_email.to[0], new_email
+    assert_equal register_email.to.first, new_email
     # Check that the confirm account url is correct
     confirm_regex = Regexp.new("/user/redirect_tester_github/confirm\\?confirm_string=([a-zA-Z0-9]*)")
-    register_email.parts.each do |part|
+    email_text_parts(register_email).each do |part|
       assert_match confirm_regex, part.body.to_s
     end
-    confirm_string = register_email.parts[0].body.match(confirm_regex)[1]
+    confirm_string = email_text_parts(register_email).first.body.match(confirm_regex)[1]
 
     # Check the page
     assert_response :success
@@ -814,13 +812,13 @@ class UserCreationTest < ActionDispatch::IntegrationTest
     # Check the e-mail
     register_email = ActionMailer::Base.deliveries.first
 
-    assert_equal register_email.to[0], new_email
+    assert_equal register_email.to.first, new_email
     # Check that the confirm account url is correct
     confirm_regex = Regexp.new("/user/redirect_tester_wikipedia/confirm\\?confirm_string=([a-zA-Z0-9]*)")
-    register_email.parts.each do |part|
+    email_text_parts(register_email).each do |part|
       assert_match confirm_regex, part.body.to_s
     end
-    confirm_string = register_email.parts[0].body.match(confirm_regex)[1]
+    confirm_string = email_text_parts(register_email).first.body.match(confirm_regex)[1]
 
     # Check the page
     assert_response :success