X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/11cc4a5e601dd288d601e6e35a72d159062f18b5..d6f8302eaeac711f8738c956f46c92de9743fed3:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 4d772ed6e..8c1ce723c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,15 +1,44 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2019-06-05 09:04:25 +0100 using RuboCop version 0.71.0. +# on 2022-02-23 19:11:04 UTC using RuboCop version 1.25.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 33 +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-minitest + - rubocop-performance + - rubocop-rails + - rubocop-rake + +# Offense count: 550 +# Cop supports --auto-correct. +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 270 + +# Offense count: 62 +# Cop supports --auto-correct. +Lint/AmbiguousOperatorPrecedence: + Exclude: + - 'app/controllers/geocoder_controller.rb' + - 'app/models/user.rb' + - 'lib/bounding_box.rb' + - 'lib/osm.rb' + - 'lib/rich_text.rb' + - 'lib/short_link.rb' + - 'test/controllers/api/old_nodes_controller_test.rb' + - 'test/lib/short_link_test.rb' + +# Offense count: 34 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/accounts_controller.rb' - 'app/controllers/api/traces_controller.rb' - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' @@ -19,26 +48,20 @@ Lint/AssignmentInCondition: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_tags_helper.rb' - - 'app/mailers/notifier.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 4 -# Configuration parameters: AllowComments. -Lint/HandleExceptions: - Exclude: - - 'app/controllers/api/amf_controller.rb' - - 'app/controllers/users_controller.rb' - -# Offense count: 703 +# Offense count: 665 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: - Max: 279 + Max: 189 -# Offense count: 40 -# Configuration parameters: CountComments, ExcludedMethods. -# ExcludedMethods: refine +# Offense count: 73 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine Metrics/BlockLength: Max: 71 @@ -47,67 +70,57 @@ Metrics/BlockLength: Metrics/BlockNesting: Max: 5 -# Offense count: 68 -# Configuration parameters: CountComments. +# Offense count: 25 +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 1397 + Max: 313 -# Offense count: 73 +# Offense count: 58 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 22 + Max: 25 -# Offense count: 714 -# Configuration parameters: CountComments, ExcludedMethods. +# Offense count: 742 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 # Offense count: 1 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 107 - -# Offense count: 4 -# Configuration parameters: CountKeywordArgs. +# Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: - Max: 9 + Max: 6 -# Offense count: 71 +# Offense count: 59 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: - Max: 25 + Max: 26 -# Offense count: 6 +# Offense count: 550 +Minitest/MultipleAssertions: + Max: 52 + +# Offense count: 1 Naming/AccessorMethodName: Exclude: - - 'app/controllers/application_controller.rb' - 'app/helpers/title_helper.rb' - - 'app/models/old_way.rb' - - 'lib/osm.rb' - - 'lib/potlatch.rb' # Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: - - 'spec/**/*' - - 'app/models/changeset.rb' - - 'app/models/old_node.rb' - - 'app/models/old_relation.rb' - - 'app/models/old_way.rb' - 'app/models/user.rb' - - 'lib/classic_pagination/pagination.rb' -# Offense count: 6 +# Offense count: 5 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql # Include: db/migrate/*.rb Rails/BulkChangeTable: Exclude: - 'db/migrate/20111116184519_update_oauth.rb' - - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb' - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' @@ -119,14 +132,33 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' -# Offense count: 11 +# Offense count: 3 # Configuration parameters: Include. # Include: app/helpers/**/*.rb Rails/HelperInstanceVariable: Exclude: - - 'app/helpers/application_helper.rb' - 'app/helpers/title_helper.rb' - - 'app/helpers/trace_helper.rb' + +# Offense count: 16 +# Configuration parameters: IgnoreScopes, Include. +# Include: app/models/**/*.rb +Rails/InverseOf: + Exclude: + - 'app/models/changeset.rb' + - 'app/models/diary_entry.rb' + - 'app/models/friendship.rb' + - 'app/models/issue.rb' + - 'app/models/message.rb' + - 'app/models/note.rb' + - 'app/models/user.rb' + +# Offense count: 2 +# Configuration parameters: Include. +# Include: app/controllers/**/*.rb +Rails/LexicallyScopedActionFilter: + Exclude: + - 'app/controllers/oauth2_applications_controller.rb' + - 'app/controllers/oauth2_authorizations_controller.rb' # Offense count: 5 # Configuration parameters: Include. @@ -139,58 +171,33 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 18 +# Offense count: 9 Rails/OutputSafety: Exclude: + - 'app/controllers/sessions_controller.rb' - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changesets_helper.rb' - - 'app/helpers/geocoder_helper.rb' - - 'app/helpers/note_helper.rb' - - 'app/helpers/open_graph_helper.rb' - - 'app/helpers/user_blocks_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 94 +# Offense count: 6 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: strict, flexible -Rails/TimeZone: - Enabled: false - -# Offense count: 1 -# Configuration parameters: AllowedChars. -Style/AsciiComments: +Rake/Desc: Exclude: - - 'test/models/message_test.rb' + - 'lib/tasks/auto_annotate_models.rake' + - 'lib/tasks/eslint.rake' + - 'lib/tasks/subscribe_diary_authors.rake' + - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 255 -Style/Documentation: - Enabled: false - -# Offense count: 503 +# Offense count: 617 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: always, never +# SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 2 -# Cop supports --auto-correct. -Style/IfUnlessModifier: - Exclude: - - 'app/controllers/api/ways_controller.rb' - -# Offense count: 74 +# Offense count: 72 # Cop supports --auto-correct. -# Configuration parameters: Strict. +# Configuration parameters: Strict, AllowedNumbers. Style/NumericLiterals: - MinDigits: 11 - -# Offense count: 3320 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 307 + MinDigits: 15