X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/1340fca8f17e4e3cce211e6eafed18cde7f57386..925bd812a2c9000c4901384b70f20e65b0f53cd4:/app/controllers/user_roles_controller.rb?ds=inline diff --git a/app/controllers/user_roles_controller.rb b/app/controllers/user_roles_controller.rb index 54dc90dee..7dad891e2 100644 --- a/app/controllers/user_roles_controller.rb +++ b/app/controllers/user_roles_controller.rb @@ -8,7 +8,6 @@ class UserRolesController < ApplicationController before_filter :require_valid_role before_filter :not_in_role, :only => [:grant] before_filter :in_role, :only => [:revoke] - around_filter :setup_nonce def grant @this_user.roles.create({ @@ -23,6 +22,9 @@ class UserRolesController < ApplicationController end private + ## + # require that the user is an administrator, or fill out a helpful error message + # and return them to theuser page. def require_administrator unless @user.administrator? flash[:error] = t'user_role.filter.not_an_administrator' @@ -30,30 +32,6 @@ class UserRolesController < ApplicationController end end - ## - # ensure that there is a "this_user" instance variable - def lookup_this_user - @this_user = User.find_by_display_name(params[:display_name]) - rescue ActiveRecord::RecordNotFound - redirect_to :controller => 'user', :action => 'view', :display_name => params[:display_name] unless @this_user - end - - ## - # the random nonce here which isn't predictable, making an CSRF - # procedure much, much more difficult. setup the nonce. if the given - # nonce matches the session nonce then yield into the actual method. - # otherwise, just sets up the nonce for the form. - def setup_nonce - if params[:nonce] and params[:nonce] == session[:nonce] - @nonce = params[:nonce] - yield - else - @nonce = OAuth::Helper.generate_nonce - session[:nonce] = @nonce - render - end - end - ## # require that the given role is valid. the role is a URL # parameter, so should always be present.