X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/1766c3216f335721ce4259f4049c14439c1777dc..57941554f718b586548f6df1bf1ccade114bfab2:/test/controllers/issues_controller_test.rb

diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index a77ef8660..a988fc909 100644
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -1,91 +1,232 @@
 require "test_helper"
 
-class IssuesControllerTest < ActionController::TestCase
-  teardown do
-    # cleanup any emails set off by the test
-    ActionMailer::Base.deliveries.clear
-  end
-
-  def test_view_dashboard_without_auth
-    # Access issues_path without login
-    get :index
-    assert_response :redirect
+class IssuesControllerTest < ActionDispatch::IntegrationTest
+  def test_index
+    # Access issues list without login
+    get issues_path
     assert_redirected_to login_path(:referer => issues_path)
 
-    # Access issues_path as normal user
-    session[:user] = create(:user).id
-    get :index
-    assert_response :redirect
-    assert_redirected_to root_path
+    # Access issues list as normal user
+    session_for(create(:user))
+    get issues_path
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Access issues_path by admin
-    session[:user] = create(:administrator_user).id
-    get :index
+    # Access issues list as administrator
+    session_for(create(:administrator_user))
+    get issues_path
     assert_response :success
 
-    # Access issues_path by moderator
-    session[:user] = create(:moderator_user).id
-    get :index
+    # Access issues list as moderator
+    session_for(create(:moderator_user))
+    get issues_path
     assert_response :success
   end
 
-  def test_change_status_by_normal_user
+  def test_show_moderator
     target_user = create(:user)
-    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
-    # Login as normal user
-    session[:user] = create(:user).id
+    # Access issue without login
+    get issue_path(:id => issue)
+    assert_redirected_to login_path(:referer => issue_path(issue))
 
-    assert_equal Issue.count, 1
+    # Access issue as normal user
+    session_for(create(:user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    get :resolve, :params => { :id => issue.id }
+    # Access issue as administrator
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
 
-    assert_response :redirect
-    assert_redirected_to root_path
+    # Access issue as moderator
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)
+    assert_response :success
   end
 
-  def test_change_status_by_admin
+  def test_show_administrator
     target_user = create(:user)
-    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
-    # Login as administrator
-    session[:user] = create(:administrator_user).id
+    # Access issue without login
+    get issue_path(:id => issue)
+    assert_redirected_to login_path(:referer => issue_path(issue))
 
-    # Test 'Resolved'
-    get :resolve, :params => { :id => issue.id }
-    assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").resolved?, true
-    assert_response :redirect
+    # Access issue as normal user
+    session_for(create(:user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Test 'Reopen'
-    get :reopen, :params => { :id => issue.id }
-    assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").open?, true
+    # Access issue as moderator
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+
+    # Access issue as administrator
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)
+    assert_response :success
+  end
+
+  def test_resolve_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
+
+    # Resolve issue without login
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Resolve issue as normal user
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Resolve issue as administrator
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.resolved?
+
+    # Resolve issue as moderator
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)
     assert_response :redirect
+    assert_predicate issue.reload, :resolved?
+  end
 
-    # Test 'Ignored'
-    get :ignore, :params => { :id => issue.id }
-    assert_equal Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored?, true
+  def test_resolve_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
+
+    # Resolve issue without login
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Resolve issue as normal user
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Resolve issue as moderator
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.resolved?
+
+    # Resolve issue as administrator
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)
     assert_response :redirect
+    assert_predicate issue.reload, :resolved?
   end
 
-  def test_search_issues
-    good_user = create(:user)
-    bad_user = create(:user)
-    create(:issue, :reportable => bad_user, :reported_user => bad_user, :issue_type => "administrator")
-    # Login as administrator
-    session[:user] = create(:administrator_user).id
+  def test_ignore_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
+
+    # Ignore issue without login
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Ignore issue as normal user
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Ignore issue as administrator
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.ignored?
+
+    # Ignore issue as moderator
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)
+    assert_response :redirect
+    assert_predicate issue.reload, :ignored?
+  end
 
-    # No issues against the user
-    get :index, :params => { :search_by_user => good_user.display_name }
+  def test_ignore_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
+
+    # Ignore issue without login
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Ignore issue as normal user
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Ignore issue as moderator
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.ignored?
+
+    # Ignore issue as administrator
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)
     assert_response :redirect
-    assert_redirected_to issues_path
+    assert_predicate issue.reload, :ignored?
+  end
+
+  def test_reopen_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
+
+    issue.resolve!
 
-    # User doesn't exist
-    get :index, :params => { :search_by_user => "test1000" }
+    # Reopen issue without login
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Reopen issue as normal user
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Reopen issue as administrator
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.open?
+
+    # Reopen issue as moderator
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)
     assert_response :redirect
-    assert_redirected_to issues_path
+    assert_predicate issue.reload, :open?
+  end
 
-    # Find Issue against bad_user
-    get :index, :params => { :search_by_user => bad_user.display_name }
-    assert_response :success
+  def test_reopen_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
+
+    issue.resolve!
+
+    # Reopen issue without login
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Reopen issue as normal user
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Reopen issue as moderator
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.open?
+
+    # Reopen issue as administrator
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)
+    assert_response :redirect
+    assert_predicate issue.reload, :open?
   end
 end