X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/21d60e359a6e972731e0385c51dd86536b7ea777..88f156a41a5c9ae45d404747819b446861db7a8c:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a993d5fff..90bfaa8f9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,126 +1,212 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2015-02-25 00:27:05 +0000 using RuboCop version 0.29.1. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2021-09-14 19:29:59 UTC using RuboCop version 1.21.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 13 -Lint/AmbiguousOperator: - Enabled: false +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-minitest + - rubocop-performance + - rubocop-rails + - rubocop-rake -# Offense count: 107 -Lint/AmbiguousRegexpLiteral: - Enabled: false +# Offense count: 524 +# Cop supports --auto-correct. +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 270 -# Offense count: 29 +# Offense count: 62 +# Cop supports --auto-correct. +Lint/AmbiguousOperatorPrecedence: + Exclude: + - 'app/controllers/geocoder_controller.rb' + - 'app/models/user.rb' + - 'lib/bounding_box.rb' + - 'lib/osm.rb' + - 'lib/rich_text.rb' + - 'lib/short_link.rb' + - 'test/controllers/api/old_nodes_controller_test.rb' + - 'test/lib/short_link_test.rb' + +# Offense count: 34 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: - Enabled: false - -# Offense count: 5 -Lint/HandleExceptions: - Enabled: false + Exclude: + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/controllers/notes_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/mailers/user_mailer.rb' + - 'app/models/client_application.rb' + - 'lib/nominatim.rb' + - 'lib/osm.rb' + - 'script/deliver-message' # Offense count: 8 -Lint/ParenthesesAsGroupedExpression: - Enabled: false - -# Offense count: 542 +# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. +Lint/DuplicateBranch: + Exclude: + - 'app/controllers/api_controller.rb' + - 'app/controllers/diary_entries_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'lib/password_hash.rb' + +# Offense count: 643 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: - Max: 270 + Max: 189 + +# Offense count: 69 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine +Metrics/BlockLength: + Max: 71 -# Offense count: 12 +# Offense count: 15 +# Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 60 -# Configuration parameters: CountComments. +# Offense count: 25 +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 1552 + Max: 337 -# Offense count: 68 +# Offense count: 58 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 21 + Max: 25 -# Offense count: 2092 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 694 - -# Offense count: 520 -# Configuration parameters: CountComments. +# Offense count: 716 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 -# Offense count: 4 -# Configuration parameters: CountKeywordArgs. +# Offense count: 1 +# Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: - Max: 9 + Max: 6 -# Offense count: 70 +# Offense count: 62 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: - Max: 24 + Max: 26 + +# Offense count: 528 +Minitest/MultipleAssertions: + Max: 54 + +# Offense count: 3 +Naming/AccessorMethodName: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/helpers/title_helper.rb' + - 'lib/osm.rb' + +# Offense count: 8 +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. +# NamePrefix: is_, has_, have_ +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? +# MethodDefinitionMacros: define_method, define_singleton_method +Naming/PredicateName: + Exclude: + - 'app/models/changeset.rb' + - 'app/models/old_node.rb' + - 'app/models/old_relation.rb' + - 'app/models/old_way.rb' + - 'app/models/user.rb' + - 'lib/classic_pagination/pagination.rb' + +# Offense count: 5 +# Configuration parameters: Database, Include. +# SupportedDatabases: mysql, postgresql +# Include: db/migrate/*.rb +Rails/BulkChangeTable: + Exclude: + - 'db/migrate/20111116184519_update_oauth.rb' + - 'db/migrate/20120208194454_add_domain_to_acl.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' # Offense count: 2 # Configuration parameters: Include. +# Include: app/models/**/*.rb Rails/HasAndBelongsToMany: - Enabled: false + Exclude: + - 'app/models/changeset.rb' + - 'app/models/user.rb' -# Offense count: 5 -Style/AccessorMethodName: - Enabled: false +# Offense count: 3 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/title_helper.rb' # Offense count: 1 -Style/AsciiComments: - Enabled: false - -# Offense count: 305 -Style/Documentation: - Enabled: false - -# Offense count: 39 -# Configuration parameters: MinBodyLength. -Style/GuardClause: - Enabled: false +# Configuration parameters: Include. +# Include: app/controllers/**/*.rb +Rails/LexicallyScopedActionFilter: + Exclude: + - 'app/controllers/oauth2_applications_controller.rb' -# Offense count: 60 +# Offense count: 5 +# Configuration parameters: Include. +# Include: db/migrate/*.rb +Rails/NotNullColumn: + Exclude: + - 'db/migrate/002_cleanup_osm_db.rb' + - 'db/migrate/020_populate_node_tags_and_remove.rb' + - 'db/migrate/021_move_to_innodb.rb' + - 'db/migrate/025_add_end_time_to_changesets.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' + +# Offense count: 9 +Rails/OutputSafety: + Exclude: + - 'app/controllers/sessions_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/helpers/application_helper.rb' + - 'lib/rich_text.rb' + - 'test/helpers/application_helper_test.rb' + +# Offense count: 91 # Cop supports --auto-correct. -Style/LineEndConcatenation: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, flexible +Rails/TimeZone: Enabled: false -# Offense count: 53 -# Cop supports --auto-correct. -Style/NumericLiterals: - MinDigits: 11 - -# Offense count: 44 +# Offense count: 6 # Cop supports --auto-correct. -Style/PerlBackrefs: - Enabled: false - -# Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist. -Style/PredicateName: - Enabled: false - -# Offense count: 95 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/RaiseArgs: - Enabled: false - -# Offense count: 2 -Style/RescueModifier: - Enabled: false - -# Offense count: 8 +Rake/Desc: + Exclude: + - 'lib/tasks/auto_annotate_models.rake' + - 'lib/tasks/eslint.rake' + - 'lib/tasks/subscribe_diary_authors.rake' + - 'lib/tasks/subscribe_old_changesets.rake' + +# Offense count: 602 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiteralsInInterpolation: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, always_true, never +Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 4 +# Offense count: 73 # Cop supports --auto-correct. -# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist. -Style/TrivialAccessors: - Enabled: false +# Configuration parameters: Strict. +Style/NumericLiterals: + MinDigits: 15