X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/2651db7254e4173de4698351eeeb2dc5ae66bdd1..ab8d3485bd004f4597d9fd43d6414a9797d831af:/.rubocop_todo.yml?ds=sidebyside diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 4627479f5..32514771c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,11 +1,10 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2020-08-06 20:53:30 UTC using RuboCop version 0.89.0. +# on 2021-06-29 17:25:37 UTC using RuboCop version 1.18.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# versions of RuboCop, may require this file to be generated again. # Work around erblint issues. # https://github.com/openstreetmap/openstreetmap-website/issues/2472 @@ -13,15 +12,16 @@ require: - rubocop-minitest - rubocop-performance - rubocop-rails + - rubocop-rake -# Offense count: 568 +# Offense count: 510 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 370 + Max: 270 -# Offense count: 36 +# Offense count: 34 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -34,20 +34,30 @@ Lint/AssignmentInCondition: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_tags_helper.rb' - - 'app/mailers/notifier.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 682 -# Configuration parameters: IgnoredMethods. +# Offense count: 8 +# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. +Lint/DuplicateBranch: + Exclude: + - 'app/controllers/api_controller.rb' + - 'app/controllers/diary_entries_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'lib/password_hash.rb' + +# Offense count: 631 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: - Max: 194 + Max: 235 -# Offense count: 72 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. -# ExcludedMethods: refine +# Offense count: 68 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine Metrics/BlockLength: Max: 71 @@ -59,55 +69,53 @@ Metrics/BlockNesting: # Offense count: 25 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 645 + Max: 361 -# Offense count: 68 +# Offense count: 56 # Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 26 + Max: 25 -# Offense count: 735 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. +# Offense count: 703 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 -# Offense count: 4 -# Configuration parameters: CountKeywordArgs. +# Offense count: 1 +# Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: - Max: 9 + Max: 6 -# Offense count: 69 +# Offense count: 60 # Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: Max: 26 -# Offense count: 540 +# Offense count: 519 Minitest/MultipleAssertions: - Max: 81 + Max: 88 -# Offense count: 26 -# Cop supports --auto-correct. -Minitest/TestMethodName: - Exclude: - - 'test/abilities/api_capability_test.rb' - - 'test/controllers/api/nodes_controller_test.rb' - - 'test/controllers/api/old_nodes_controller_test.rb' - - 'test/controllers/api/relations_controller_test.rb' - - 'test/controllers/api/ways_controller_test.rb' - - 'test/helpers/browse_helper_test.rb' - - 'test/integration/client_applications_test.rb' - - 'test/integration/short_links_test.rb' - - 'test/integration/user_blocks_test.rb' - - 'test/integration/user_creation_test.rb' - -# Offense count: 6 +# Offense count: 4 Naming/AccessorMethodName: Exclude: - 'app/controllers/application_controller.rb' - 'app/helpers/title_helper.rb' - - 'app/models/old_way.rb' - 'lib/osm.rb' - - 'lib/potlatch.rb' + +# Offense count: 21 +# Configuration parameters: CheckIdentifiers, CheckConstants, CheckVariables, CheckStrings, CheckSymbols, CheckComments, CheckFilepaths, FlaggedTerms. +Naming/InclusiveLanguage: + Exclude: + - 'app/controllers/sessions_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/views/api/capabilities/show.builder' + - 'app/views/confirmations/_resend_success_flash.html.erb' + - 'app/views/users/suspended.html.erb' + - 'config/environments/production.rb' + - 'config/initializers/canonical_rails.rb' + - 'config/initializers/config.rb' + - 'config/initializers/doorkeeper.rb' # Offense count: 8 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. @@ -117,7 +125,6 @@ Naming/AccessorMethodName: # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: - - 'spec/**/*' - 'app/models/changeset.rb' - 'app/models/old_node.rb' - 'app/models/old_relation.rb' @@ -143,7 +150,7 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' -# Offense count: 4 +# Offense count: 3 # Configuration parameters: Include. # Include: app/helpers/**/*.rb Rails/HelperInstanceVariable: @@ -151,12 +158,11 @@ Rails/HelperInstanceVariable: - 'app/helpers/title_helper.rb' # Offense count: 1 -# Cop supports --auto-correct. # Configuration parameters: Include. -# Include: app/mailers/**/*.rb -Rails/MailerName: +# Include: app/controllers/**/*.rb +Rails/LexicallyScopedActionFilter: Exclude: - - 'app/mailers/notifier.rb' + - 'app/controllers/oauth2_applications_controller.rb' # Offense count: 5 # Configuration parameters: Include. @@ -169,20 +175,16 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 19 +# Offense count: 9 Rails/OutputSafety: Exclude: + - 'app/controllers/sessions_controller.rb' - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changesets_helper.rb' - - 'app/helpers/geocoder_helper.rb' - - 'app/helpers/note_helper.rb' - - 'app/helpers/open_graph_helper.rb' - - 'app/helpers/user_blocks_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 95 +# Offense count: 91 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible @@ -191,43 +193,22 @@ Rails/TimeZone: # Offense count: 6 # Cop supports --auto-correct. -Style/ExplicitBlockArgument: +Rake/Desc: Exclude: - - 'app/controllers/api/amf_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/mailers/notifier.rb' - - 'test/integration/client_applications_test.rb' + - 'lib/tasks/auto_annotate_models.rake' + - 'lib/tasks/eslint.rake' + - 'lib/tasks/subscribe_diary_authors.rake' + - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 572 +# Offense count: 597 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 78 +# Offense count: 73 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: - MinDigits: 11 - -# Offense count: 20 -Style/OptionalBooleanParameter: - Exclude: - - 'app/controllers/api/notes_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/helpers/browse_helper.rb' - - 'app/models/changeset.rb' - - 'app/models/node.rb' - - 'app/models/relation.rb' - - 'app/models/trace.rb' - - 'app/models/tracepoint.rb' - - 'app/models/way.rb' - - 'test/models/diary_entry_test.rb' - - 'test/models/trace_test.rb' - - 'test/models/tracetag_test.rb' - -# Offense count: 44 -# Cop supports --auto-correct. -Style/StringConcatenation: - Enabled: false + MinDigits: 15