X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/2722cc60be5107d7f99c9818b5b24005a73245b2..6094a97ce6297d390e5bbf733f5c2b4cc6b2076c:/.rubocop.yml?ds=inline diff --git a/.rubocop.yml b/.rubocop.yml index 1ae01086a..60d144544 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,11 +1,16 @@ inherit_from: .rubocop_todo.yml require: + - rubocop-capybara + - rubocop-factory_bot + - rubocop-minitest - rubocop-performance - rubocop-rails + - rubocop-rake AllCops: - TargetRubyVersion: 2.5 + TargetRubyVersion: 3.1 + NewCops: enable Exclude: - 'vendor/**/*' @@ -29,18 +34,27 @@ Metrics/ClassLength: Exclude: - 'test/**/*' +Metrics/ModuleLength: + Max: 150 + Naming/FileName: Exclude: - 'script/deliver-message' - - 'script/locale/reload-languages' - 'script/update-spam-blocks' Naming/MethodParameterName: Enabled: false +# This conflicts with Strong Migrations, which can't check `change_table` +Rails/BulkChangeTable: + Enabled: false + Rails/CreateTableWithTimestamps: Enabled: false +Rails/FindBy: + IgnoreWhereFirst: false + Rails/FindEach: Enabled: false @@ -50,22 +64,20 @@ Rails/HasManyOrHasOneDependent: Rails/HttpPositionalArguments: Enabled: false -Rails/InverseOf: +Rails/ReflectionClassName: Enabled: false Rails/SkipsModelValidations: Exclude: - 'db/migrate/*.rb' - - 'app/controllers/users_controller.rb' - -Style/BracesAroundHashParameters: - EnforcedStyle: context_dependent + - 'app/controllers/users/lists_controller.rb' Style/Documentation: Enabled: false Style/FormatStringToken: - EnforcedStyle: template + Exclude: + - 'config/routes.rb' Style/IfInsideElse: Enabled: false @@ -73,12 +85,21 @@ Style/IfInsideElse: Style/GuardClause: Enabled: false +Style/HashEachMethods: + Enabled: true + Style/HashSyntax: EnforcedStyle: hash_rockets Exclude: - 'lib/tasks/testing.rake' - 'config/initializers/wrap_parameters.rb' +Style/HashTransformKeys: + Enabled: true + +Style/HashTransformValues: + Enabled: true + Style/MixinUsage: Exclude: - 'bin/setup'