X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/28726e5f11cb46add4e6b86eb9a958798b83c46a..79c306ad06155549ff6e5929ff20a1149b4862c4:/.rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 6fe5b2e57..0dd79ea2a 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-04-11 16:47:05 UTC using RuboCop version 1.50.0.
+# on 2024-08-27 18:01:13 UTC using RuboCop version 1.65.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,19 +14,28 @@ require:
   - rubocop-rails
   - rubocop-rake
 
-# Offense count: 11
-# Configuration parameters: Include, MaxAmount
+# Offense count: 13
+# Configuration parameters: Include, MaxAmount.
+# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
 FactoryBot/ExcessiveCreateList:
-  MaxAmount: 200
-
-# Offense count: 557
+  Exclude:
+    - 'test/controllers/api/changeset_comments_controller_test.rb'
+    - 'test/controllers/api/messages_controller_test.rb'
+    - 'test/controllers/changesets_controller_test.rb'
+    - 'test/controllers/diary_entries_controller_test.rb'
+    - 'test/controllers/notes_controller_test.rb'
+    - 'test/controllers/traces_controller_test.rb'
+    - 'test/controllers/user_blocks_controller_test.rb'
+    - 'test/system/users_test.rb'
+
+# Offense count: 635
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
-  Max: 266
+  Max: 234
 
-# Offense count: 29
+# Offense count: 23
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
@@ -34,9 +43,7 @@ Lint/AssignmentInCondition:
     - 'app/controllers/accounts_controller.rb'
     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
-    - 'app/controllers/application_controller.rb'
     - 'app/controllers/geocoder_controller.rb'
-    - 'app/controllers/notes_controller.rb'
     - 'app/controllers/traces_controller.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
@@ -47,33 +54,33 @@ Lint/AssignmentInCondition:
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
-# Offense count: 680
+# Offense count: 762
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 189
 
-# Offense count: 73
+# Offense count: 37
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 # AllowedMethods: refine
 Metrics/BlockLength:
   Max: 71
 
-# Offense count: 20
-# Configuration parameters: CountBlocks.
+# Offense count: 8
+# Configuration parameters: CountBlocks, CountModifierForms.
 Metrics/BlockNesting:
   Max: 5
 
 # Offense count: 26
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 314
+  Max: 309
 
-# Offense count: 59
+# Offense count: 58
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
-  Max: 29
+  Max: 25
 
-# Offense count: 753
+# Offense count: 844
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 179
@@ -83,35 +90,33 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 56
+# Offense count: 58
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
-  Max: 30
+  Max: 26
 
-# Offense count: 2394
+# Offense count: 2784
 # This cop supports safe autocorrection (--autocorrect).
 Minitest/EmptyLineBeforeAssertionMethods:
   Enabled: false
 
-# Offense count: 565
+# Offense count: 695
 Minitest/MultipleAssertions:
-  Max: 54
+  Max: 60
 
-# Offense count: 1
+# Offense count: 10
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/ActionControllerFlashBeforeRender:
   Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/controllers/confirmations_controller.rb'
+    - 'app/controllers/friendships_controller.rb'
+    - 'app/controllers/issue_comments_controller.rb'
+    - 'app/controllers/messages_controller.rb'
+    - 'app/controllers/passwords_controller.rb'
     - 'app/controllers/traces_controller.rb'
-
-# Offense count: 5
-# Configuration parameters: Database, Include.
-# SupportedDatabases: mysql, postgresql
-# Include: db/migrate/*.rb
-Rails/BulkChangeTable:
-  Exclude:
-    - 'db/migrate/20111116184519_update_oauth.rb'
-    - 'db/migrate/20120208194454_add_domain_to_acl.rb'
-    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+    - 'app/controllers/user_blocks_controller.rb'
+    - 'app/controllers/users_controller.rb'
 
 # Offense count: 2
 # Configuration parameters: Include.
@@ -128,7 +133,7 @@ Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/title_helper.rb'
 
-# Offense count: 16
+# Offense count: 17
 # Configuration parameters: IgnoreScopes, Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:
@@ -141,17 +146,17 @@ Rails/InverseOf:
     - 'app/models/note.rb'
     - 'app/models/user.rb'
 
-# Offense count: 2
+# Offense count: 1
 # Configuration parameters: Include.
 # Include: app/controllers/**/*.rb, app/mailers/**/*.rb
 Rails/LexicallyScopedActionFilter:
   Exclude:
     - 'app/controllers/oauth2_applications_controller.rb'
-    - 'app/controllers/oauth2_authorizations_controller.rb'
 
 # Offense count: 5
-# Configuration parameters: Include.
-# Include: db/migrate/*.rb
+# Configuration parameters: Database, Include.
+# SupportedDatabases: mysql
+# Include: db/**/*.rb
 Rails/NotNullColumn:
   Exclude:
     - 'db/migrate/002_cleanup_osm_db.rb'
@@ -164,6 +169,7 @@ Rails/NotNullColumn:
 Rails/OutputSafety:
   Exclude:
     - 'app/helpers/application_helper.rb'
+    - 'app/helpers/user_mailer_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
@@ -187,14 +193,14 @@ Rake/Desc:
     - 'lib/tasks/subscribe_diary_authors.rake'
     - 'lib/tasks/subscribe_old_changesets.rake'
 
-# Offense count: 632
+# Offense count: 712
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# Offense count: 72
+# Offense count: 78
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.
 Style/NumericLiterals: