X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/2a89bf2e6cbd9eaa98143a38437b063c8c73aa96..c71fd544e0b33246dfcc677ec830efc2031d419e:/app/helpers/issues_helper.rb diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index 456507d4c..3c13c6536 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -1,17 +1,14 @@ module IssuesHelper def reportable_url(reportable) - class_name = reportable.class.name - case class_name - when "DiaryEntry" - link_to reportable.title, :controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.user.display_name, :id => reportable.id - when "User" - link_to reportable.display_name.to_s, :controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.display_name - when "DiaryComment" - link_to "#{reportable.diary_entry.title}, Comment id ##{reportable.id}", :controller => reportable.diary_entry.class.name.underscore, :action => :view, :display_name => reportable.diary_entry.user.display_name, :id => reportable.diary_entry.id, :anchor => "comment#{reportable.id}" - when "Changeset" - link_to "Changeset ##{reportable.id}", :controller => :browse, :action => :changeset, :id => reportable.id - when "Note" - link_to "Note ##{reportable.id}", :controller => :browse, :action => :note, :id => reportable.id + case reportable + when DiaryEntry + url_for(:controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.user.display_name, :id => reportable.id) + when User + url_for(:controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.display_name) + when DiaryComment + url_for(:controller => reportable.diary_entry.class.name.underscore, :action => :view, :display_name => reportable.diary_entry.user.display_name, :id => reportable.diary_entry.id, :anchor => "comment#{reportable.id}") + when Note + url_for(:controller => :browse, :action => :note, :id => reportable.id) end end @@ -23,26 +20,8 @@ module IssuesHelper reportable.display_name when DiaryComment "#{reportable.diary_entry.title}, Comment id ##{reportable.id}" - when Changeset - "Changeset ##{reportable.id}" when Note "Note ##{reportable.id}" end end - - def instance_url(reportable) - class_name = reportable.class.name - case class_name - when "DiaryEntry" - link_to "Show Instance", :controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.user.display_name, :id => reportable.id - when "User" - link_to "Show Instance", :controller => reportable.class.name.underscore, :action => :view, :display_name => reportable.display_name - when "DiaryComment" - link_to "Show Instance", :controller => reportable.diary_entry.class.name.underscore, :action => :view, :display_name => reportable.diary_entry.user.display_name, :id => reportable.diary_entry.id, :anchor => "comment#{reportable.id}" - when "Changeset" - link_to "Show Instance", :controller => :browse, :action => :changeset, :id => reportable.id - when "Note" - link_to "Show Instance", :controller => :browse, :action => :note, :id => reportable.id - end - end end