X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/2cfc030bbac65d8cb687ee17e6fbf18ffa5ea2cc..87363858cb4e9cff9b5c29ac6e95425c5c3fab8b:/app/assets/javascripts/index/directions.js diff --git a/app/assets/javascripts/index/directions.js b/app/assets/javascripts/index/directions.js index 356dc6271..c6f83a575 100644 --- a/app/assets/javascripts/index/directions.js +++ b/app/assets/javascripts/index/directions.js @@ -3,60 +3,52 @@ //= require_tree ./directions OSM.Directions = function (map) { - var routeRequest = null; // jqXHR object of an ongoing route request or null - var chosenEngine; + let controller = null; // the AbortController for the current route request if a route request is in progress + let lastLocation = []; + let chosenEngine; - var popup = L.popup({ autoPanPadding: [100, 100] }); + const popup = L.popup({ autoPanPadding: [100, 100] }); - var polyline = L.polyline([], { + const polyline = L.polyline([], { color: "#03f", opacity: 0.3, weight: 10 }); - var highlight = L.polyline([], { + const highlight = L.polyline([], { color: "#ff0", opacity: 0.5, weight: 12 }); - var endpointDragCallback = function (dragging) { + const endpointDragCallback = function (dragging) { if (!map.hasLayer(polyline)) return; if (dragging && !chosenEngine.draggable) return; - if (dragging && routeRequest) return; + if (dragging && controller) return; getRoute(false, !dragging); }; - var endpointChangeCallback = function () { + const endpointChangeCallback = function () { getRoute(true, true); }; - var endpoints = [ + const endpoints = [ OSM.DirectionsEndpoint(map, $("input[name='route_from']"), OSM.MARKER_GREEN, endpointDragCallback, endpointChangeCallback), OSM.DirectionsEndpoint(map, $("input[name='route_to']"), OSM.MARKER_RED, endpointDragCallback, endpointChangeCallback) ]; - var expiry = new Date(); - expiry.setYear(expiry.getFullYear() + 10); - - var engines = OSM.Directions.engines; + let downloadURL = null; - engines.sort(function (a, b) { - var localised_a = I18n.t("javascripts.directions.engines." + a.id), - localised_b = I18n.t("javascripts.directions.engines." + b.id); - return localised_a.localeCompare(localised_b); - }); + const expiry = new Date(); + expiry.setYear(expiry.getFullYear() + 10); - var select = $("select.routing_engines"); - - engines.forEach(function (engine, i) { - select.append(""); - }); + const modeGroup = $(".routing_modes"); + const select = $("select.routing_engines"); $(".directions_form .reverse_directions").on("click", function () { - var coordFrom = endpoints[0].latlng, - coordTo = endpoints[1].latlng, - routeFrom = "", + const coordFrom = endpoints[0].latlng, + coordTo = endpoints[1].latlng; + let routeFrom = "", routeTo = ""; if (coordFrom) { routeFrom = coordFrom.lat + "," + coordFrom.lng; @@ -73,8 +65,8 @@ OSM.Directions = function (map) { $(".directions_form .btn-close").on("click", function (e) { e.preventDefault(); - $(".describe_location").toggle(!endpoints[0].value); - $(".search_form input[name='query']").val(endpoints[0].value); + $(".describe_location").toggle(!endpoints[1].value); + $(".search_form input[name='query']").val(endpoints[1].value); OSM.router.route("/" + OSM.formatHash(map)); }); @@ -90,26 +82,44 @@ OSM.Directions = function (map) { } function formatTime(s) { - var m = Math.round(s / 60); - var h = Math.floor(m / 60); + let m = Math.round(s / 60); + const h = Math.floor(m / 60); m -= h * 60; return h + ":" + (m < 10 ? "0" : "") + m; } - function findEngine(id) { - return engines.findIndex(function (engine) { - return engine.id === id; - }); - } + function setEngine(id) { + const engines = OSM.Directions.engines; + const desired = engines.find(engine => engine.id === id); + if (!desired || (chosenEngine && chosenEngine.id === id)) return; + chosenEngine = desired; + + const modes = engines + .filter(engine => engine.provider === chosenEngine.provider) + .map(engine => engine.mode); + modeGroup + .find("input[id]") + .prop("disabled", function () { + return !modes.includes(this.id); + }) + .prop("checked", function () { + return this.id === chosenEngine.mode; + }); - function setEngine(index) { - chosenEngine = engines[index]; - select.val(index); + const providers = engines + .filter(engine => engine.mode === chosenEngine.mode) + .map(engine => engine.provider); + select + .find("option[value]") + .prop("disabled", function () { + return !providers.includes(this.value); + }); + select.val(chosenEngine.provider); } function getRoute(fitRoute, reportErrors) { // Cancel any route that is already in progress - if (routeRequest) routeRequest.abort(); + if (controller) controller.abort(); const points = endpoints.map(p => p.latlng); @@ -126,20 +136,8 @@ OSM.Directions = function (map) { // again. $("#sidebar_content").html($(".directions_form .loader_copy").html()); map.setSidebarOverlaid(false); - - routeRequest = chosenEngine.getRoute(points, function (err, route) { - routeRequest = null; - - if (err) { - map.removeLayer(polyline); - - if (reportErrors) { - $("#sidebar_content").html("
" + I18n.t("javascripts.directions.errors.no_route") + "
"); - } - - return; - } - + controller = new AbortController(); + chosenEngine.getRoute(points, controller.signal).then(function (route) { polyline .setLatLngs(route.line) .addTo(map); @@ -148,7 +146,7 @@ OSM.Directions = function (map) { map.fitBounds(polyline.getBounds().pad(0.05)); } - var distanceText = $("

").append( + const distanceText = $("

").append( I18n.t("javascripts.directions.distance") + ": " + formatDistance(route.distance) + ". " + I18n.t("javascripts.directions.time") + ": " + formatTime(route.time) + "."); if (typeof route.ascend !== "undefined" && typeof route.descend !== "undefined") { @@ -158,9 +156,9 @@ OSM.Directions = function (map) { I18n.t("javascripts.directions.descend") + ": " + formatHeight(route.descend) + "."); } - var turnByTurnTable = $("") + const turnByTurnTable = $("
") .append($("")); - var directionsCloseButton = $(""); + const row = $(""); row.append(" "); row.append("
" + instruction); row.append("" + getDistText(dist)); @@ -201,6 +199,16 @@ OSM.Directions = function (map) { turnByTurnTable.append(row); }); + const blob = new Blob([JSON.stringify(polyline.toGeoJSON())], { type: "application/json" }); + URL.revokeObjectURL(downloadURL); + downloadURL = URL.createObjectURL(blob); + + $("#sidebar_content").append(`

${ + I18n.t("javascripts.directions.download") + }

`); + $("#sidebar_content").append("

" + I18n.t("javascripts.directions.instructions.courtesy", { link: chosenEngine.creditline }) + "

"); @@ -212,6 +220,13 @@ OSM.Directions = function (map) { map.setSidebarOverlaid(true); // TODO: collapse width of sidebar back to previous }); + }).catch(function () { + map.removeLayer(polyline); + if (reportErrors) { + $("#sidebar_content").html("
" + I18n.t("javascripts.directions.errors.no_route") + "
"); + } + }).finally(function () { + controller = null; }); function getDistText(dist) { @@ -223,14 +238,17 @@ OSM.Directions = function (map) { } } - var chosenEngineIndex = findEngine("fossgis_osrm_car"); - if (Cookies.get("_osm_directions_engine")) { - chosenEngineIndex = findEngine(Cookies.get("_osm_directions_engine")); - } - setEngine(chosenEngineIndex); + setEngine("fossgis_osrm_car"); + setEngine(Cookies.get("_osm_directions_engine")); + + modeGroup.on("change", "input[name='modes']", function (e) { + setEngine(chosenEngine.provider + "_" + e.target.id); + Cookies.set("_osm_directions_engine", chosenEngine.id, { secure: true, expires: expiry, path: "/", samesite: "lax" }); + getRoute(true, true); + }); select.on("change", function (e) { - chosenEngine = engines[e.target.selectedIndex]; + setEngine(e.target.value + "_" + chosenEngine.mode); Cookies.set("_osm_directions_engine", chosenEngine.id, { secure: true, expires: expiry, path: "/", samesite: "lax" }); getRoute(true, true); }); @@ -241,17 +259,30 @@ OSM.Directions = function (map) { }); $(".routing_marker_column img").on("dragstart", function (e) { - var dt = e.originalEvent.dataTransfer; + const dt = e.originalEvent.dataTransfer; dt.effectAllowed = "move"; - var dragData = { type: $(this).data("type") }; + const dragData = { type: $(this).data("type") }; dt.setData("text", JSON.stringify(dragData)); if (dt.setDragImage) { - var img = $("").attr("src", $(e.originalEvent.target).attr("src")); + const img = $("").attr("src", $(e.originalEvent.target).attr("src")); dt.setDragImage(img.get(0), 12, 21); } }); - var page = {}; + function sendstartinglocation({ latlng: { lat, lng } }) { + map.fire("startinglocation", { latlng: [lat, lng] }); + } + + map.on("locationfound", ({ latlng: { lat, lng } }) => + lastLocation = [lat, lng] + ).on("locateactivate", () => { + map.once("startinglocation", ({ latlng }) => { + if (endpoints[0].value) return; + endpoints[0].setValue(latlng.join(", ")); + }); + }); + + const page = {}; page.pushstate = page.popstate = function () { $(".search_form").hide(); @@ -263,31 +294,27 @@ OSM.Directions = function (map) { $("#map").on("drop", function (e) { e.preventDefault(); - var oe = e.originalEvent; - var dragData = JSON.parse(oe.dataTransfer.getData("text")); - var type = dragData.type; - var pt = L.DomEvent.getMousePosition(oe, map.getContainer()); // co-ordinates of the mouse pointer at present + const oe = e.originalEvent; + const dragData = JSON.parse(oe.dataTransfer.getData("text")); + const type = dragData.type; + const pt = L.DomEvent.getMousePosition(oe, map.getContainer()); // co-ordinates of the mouse pointer at present pt.y += 20; - var ll = map.containerPointToLatLng(pt); + const ll = map.containerPointToLatLng(pt); const llWithPrecision = OSM.cropLocation(ll, map.getZoom()); endpoints[type === "from" ? 0 : 1].setValue(llWithPrecision.join(", ")); }); + map.on("locationfound", sendstartinglocation); + endpoints[0].enable(); endpoints[1].enable(); const params = new URLSearchParams(location.search), route = (params.get("route") || "").split(";"); - if (params.has("engine")) { - var engineIndex = findEngine(params.get("engine")); - - if (engineIndex >= 0) { - setEngine(engineIndex); - } - } + if (params.has("engine")) setEngine(params.get("engine")); - endpoints[0].setValue(params.get("from") || route[0] || ""); + endpoints[0].setValue(params.get("from") || route[0] || lastLocation.join(", ")); endpoints[1].setValue(params.get("to") || route[1] || ""); map.setSidebarOverlaid(!endpoints[0].latlng || !endpoints[1].latlng); @@ -301,6 +328,7 @@ OSM.Directions = function (map) { $(".search_form").show(); $(".directions_form").hide(); $("#map").off("dragend dragover drop"); + map.off("locationfound", sendstartinglocation); endpoints[0].disable(); endpoints[1].disable(); @@ -317,6 +345,7 @@ OSM.Directions.engines = []; OSM.Directions.addEngine = function (engine, supportsHTTPS) { if (document.location.protocol === "http:" || supportsHTTPS) { + engine.id = engine.provider + "_" + engine.mode; OSM.Directions.engines.push(engine); } };