X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/2df389c97e52437f964e4b4ee22c8493a9cc7fbc..6cc31259e4e96784e4937c8c0ae561f8291ecaa2:/test/controllers/user_blocks_controller_test.rb diff --git a/test/controllers/user_blocks_controller_test.rb b/test/controllers/user_blocks_controller_test.rb index 0b9c82f6a..ddb33e903 100644 --- a/test/controllers/user_blocks_controller_test.rb +++ b/test/controllers/user_blocks_controller_test.rb @@ -36,15 +36,6 @@ class UserBlocksControllerTest < ActionDispatch::IntegrationTest { :path => "/user_blocks/1", :method => :delete }, { :controller => "user_blocks", :action => "destroy", :id => "1" } ) - - assert_routing( - { :path => "/user/username/blocks/revoke_all", :method => :get }, - { :controller => "user_blocks", :action => "revoke_all", :display_name => "username" } - ) - assert_routing( - { :path => "/user/username/blocks/revoke_all", :method => :post }, - { :controller => "user_blocks", :action => "revoke_all", :display_name => "username" } - ) end ## @@ -598,83 +589,6 @@ class UserBlocksControllerTest < ActionDispatch::IntegrationTest assert_equal other_moderator_user, block.revoker end - ## - # test the revoke all page - def test_revoke_all_page - blocked_user = create(:user) - create(:user_block, :user => blocked_user) - - # Asking for the revoke all blocks page with a bogus user name should fail - get user_received_blocks_path("non_existent_user") - assert_response :not_found - - # Check that the revoke all blocks page requires us to login - get revoke_all_user_blocks_path(blocked_user) - assert_redirected_to login_path(:referer => revoke_all_user_blocks_path(blocked_user)) - - # Login as a normal user - session_for(create(:user)) - - # Check that normal users can't load the revoke all blocks page - get revoke_all_user_blocks_path(blocked_user) - assert_redirected_to :controller => "errors", :action => "forbidden" - - # Login as a moderator - session_for(create(:moderator_user)) - - # Check that the revoke all blocks page loads for moderators - get revoke_all_user_blocks_path(blocked_user) - assert_response :success - assert_select "h1 a[href='#{user_path blocked_user}']", :text => blocked_user.display_name - end - - ## - # test the revoke all action - def test_revoke_all_action - blocked_user = create(:user) - active_block1 = create(:user_block, :user => blocked_user) - active_block2 = create(:user_block, :user => blocked_user) - expired_block1 = create(:user_block, :expired, :user => blocked_user) - blocks = [active_block1, active_block2, expired_block1] - moderator_user = create(:moderator_user) - - assert_predicate active_block1, :active? - assert_predicate active_block2, :active? - assert_not_predicate expired_block1, :active? - - # Login as a normal user - session_for(create(:user)) - - # Check that normal users can't load the block revoke page - get revoke_all_user_blocks_path(:blocked_user) - assert_redirected_to :controller => "errors", :action => "forbidden" - - # Login as a moderator - session_for(moderator_user) - - # Check that revoking blocks using GET should fail - get revoke_all_user_blocks_path(blocked_user, :confirm => true) - assert_response :success - assert_template "revoke_all" - - blocks.each(&:reload) - assert_predicate active_block1, :active? - assert_predicate active_block2, :active? - assert_not_predicate expired_block1, :active? - - # Check that revoking blocks works using POST - post revoke_all_user_blocks_path(blocked_user, :confirm => true) - assert_redirected_to user_received_blocks_path(blocked_user) - - blocks.each(&:reload) - assert_not_predicate active_block1, :active? - assert_not_predicate active_block2, :active? - assert_not_predicate expired_block1, :active? - assert_equal moderator_user, active_block1.revoker - assert_equal moderator_user, active_block2.revoker - assert_not_equal moderator_user, expired_block1.revoker - end - ## # test changes to end/deactivation dates def test_dates_when_viewed_before_end