X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/2e34b62fac7d0a9a7b03e92bdf26f691736e2954..f3c4099b593bd800db0576a1337a1473574ed108:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 240e46c31..c03cf665c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2022-02-23 19:11:04 UTC using RuboCop version 1.25.1. +# on 2022-11-01 18:20:38 UTC using RuboCop version 1.38.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,14 +14,14 @@ require: - rubocop-rails - rubocop-rake -# Offense count: 550 -# Cop supports --auto-correct. -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Offense count: 555 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 270 + Max: 248 -# Offense count: 34 +# Offense count: 29 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -41,14 +41,14 @@ Lint/AssignmentInCondition: - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 665 -# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. +# Offense count: 676 +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: Max: 189 # Offense count: 73 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. -# IgnoredMethods: refine +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. +# AllowedMethods: refine Metrics/BlockLength: Max: 71 @@ -63,12 +63,12 @@ Metrics/ClassLength: Max: 316 # Offense count: 58 -# Configuration parameters: IgnoredMethods. +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/CyclomaticComplexity: Max: 25 -# Offense count: 742 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# Offense count: 751 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/MethodLength: Max: 179 @@ -77,21 +77,21 @@ Metrics/MethodLength: Metrics/ParameterLists: Max: 6 -# Offense count: 59 -# Configuration parameters: IgnoredMethods. +# Offense count: 57 +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/PerceivedComplexity: Max: 26 -# Offense count: 550 +# Offense count: 2495 +# This cop supports safe autocorrection (--autocorrect). +Minitest/EmptyLineBeforeAssertionMethods: + Enabled: false + +# Offense count: 560 Minitest/MultipleAssertions: Max: 52 # Offense count: 1 -Naming/AccessorMethodName: - Exclude: - - 'app/helpers/title_helper.rb' - -# Offense count: 8 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ # ForbiddenPrefixes: is_, has_, have_ @@ -101,6 +101,17 @@ Naming/PredicateName: Exclude: - 'app/models/user.rb' +# Offense count: 8 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ActionControllerFlashBeforeRender: + Exclude: + - 'app/controllers/confirmations_controller.rb' + - 'app/controllers/friendships_controller.rb' + - 'app/controllers/oauth_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/user_blocks_controller.rb' + - 'app/controllers/users_controller.rb' + # Offense count: 5 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql @@ -141,7 +152,7 @@ Rails/InverseOf: # Offense count: 2 # Configuration parameters: Include. -# Include: app/controllers/**/*.rb +# Include: app/controllers/**/*.rb, app/mailers/**/*.rb Rails/LexicallyScopedActionFilter: Exclude: - 'app/controllers/oauth2_applications_controller.rb' @@ -168,7 +179,7 @@ Rails/OutputSafety: - 'test/helpers/application_helper_test.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Rake/Desc: Exclude: - 'lib/tasks/auto_annotate_models.rake' @@ -176,15 +187,15 @@ Rake/Desc: - 'lib/tasks/subscribe_diary_authors.rake' - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 617 -# Cop supports --auto-correct. +# Offense count: 625 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false # Offense count: 72 -# Cop supports --auto-correct. -# Configuration parameters: Strict, AllowedNumbers. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: MinDigits: 15