X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/2f9291ba5764fe104264ae7e3b6a361e11212e8b..0e78061cdba5cfb3f299f57b7643d2b396ee235b:/test/abilities/abilities_test.rb diff --git a/test/abilities/abilities_test.rb b/test/abilities/abilities_test.rb index b951e23e5..c27f75833 100644 --- a/test/abilities/abilities_test.rb +++ b/test/abilities/abilities_test.rb @@ -23,20 +23,15 @@ class GuestAbilityTest < AbilityTest [:create, :edit, :comment, :subscribe, :unsubscribe, :hide, :hidecomment].each do |action| assert ability.cannot?(action, DiaryEntry), "should not be able to #{action} DiaryEntries" - assert ability.cannot?(action, DiaryComment), "should not be able to #{action} DiaryEntries" end end test "note permissions for a guest" do ability = Ability.new nil - [:index, :create, :comment, :feed, :show, :search, :mine].each do |action| + [:index].each do |action| assert ability.can?(action, Note), "should be able to #{action} Notes" end - - [:close, :reopen, :destroy].each do |action| - assert ability.cannot?(action, Note), "should not be able to #{action} Notes" - end end test "user roles permissions for a guest" do @@ -58,25 +53,12 @@ class UserAbilityTest < AbilityTest [:hide, :hidecomment].each do |action| assert ability.cannot?(action, DiaryEntry), "should not be able to #{action} DiaryEntries" - assert ability.cannot?(action, DiaryComment), "should not be able to #{action} DiaryEntries" end [:index, :show, :resolve, :ignore, :reopen].each do |action| assert ability.cannot?(action, Issue), "should not be able to #{action} Issues" end end - - test "Note permissions" do - ability = Ability.new create(:user) - - [:index, :create, :comment, :feed, :show, :search, :mine, :close, :reopen].each do |action| - assert ability.can?(action, Note), "should be able to #{action} Notes" - end - - [:destroy].each do |action| - assert ability.cannot?(action, Note), "should not be able to #{action} Notes" - end - end end class ModeratorAbilityTest < AbilityTest @@ -88,20 +70,16 @@ class ModeratorAbilityTest < AbilityTest end end - test "Note permissions" do - ability = Ability.new create(:moderator_user) - - [:index, :create, :comment, :feed, :show, :search, :mine, :close, :reopen, :destroy].each do |action| - assert ability.can?(action, Note), "should be able to #{action} Notes" - end - end - test "User Roles permissions" do ability = Ability.new create(:moderator_user) [:grant, :revoke].each do |action| assert ability.cannot?(action, UserRole), "should not be able to #{action} UserRoles" end + + [:hide, :hidecomment].each do |action| + assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries" + end end end @@ -111,10 +89,6 @@ class AdministratorAbilityTest < AbilityTest [:index, :rss, :show, :comments, :create, :edit, :comment, :subscribe, :unsubscribe, :hide, :hidecomment].each do |action| assert ability.can?(action, DiaryEntry), "should be able to #{action} DiaryEntries" end - - [:hide, :hidecomment].each do |action| - assert ability.can?(action, DiaryComment), "should be able to #{action} DiaryComment" - end end test "User Roles permissions for an administrator" do