X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/30a01fb7f9dedc757a27f9bf97e3d720f4530508..a35f360d5eb96fc553afaf17818a3ace0665a03d:/test/lib/i18n_test.rb diff --git a/test/lib/i18n_test.rb b/test/lib/i18n_test.rb index 3f46955b3..fe94cbdd3 100644 --- a/test/lib/i18n_test.rb +++ b/test/lib/i18n_test.rb @@ -2,7 +2,7 @@ require "test_helper" class I18nTest < ActiveSupport::TestCase I18n.available_locales.each do |locale| - define_method("test_#{locale.to_s.underscore}".to_sym) do + test locale.to_s do without_i18n_exceptions do # plural_keys = plural_keys(locale) @@ -42,7 +42,7 @@ class I18nTest < ActiveSupport::TestCase assert_includes value, :other, "#{key}.other plural key missing" else - assert value.is_a?(String), "#{key} is not a string" + assert_kind_of String, value, "#{key} is not a string" value.scan(/%\{(\w+)\}/) do assert_includes variables, Regexp.last_match(1), "#{key} uses unknown interpolation variable #{Regexp.last_match(1)}" @@ -55,10 +55,13 @@ class I18nTest < ActiveSupport::TestCase end end - def test_en_for_raw_html - en = YAML.load_file(Rails.root.join("config/locales/en.yml")) - assert_nothing_raised do - check_values_for_raw_html(en) + Rails.root.glob("config/locales/*.yml").each do |filename| + lang = File.basename(filename, ".yml") + test "#{lang} for raw html" do + yml = YAML.load_file(filename) + assert_nothing_raised do + check_values_for_raw_html(yml) + end end end @@ -69,6 +72,15 @@ class I18nTest < ActiveSupport::TestCase end end + # We should avoid using the key `zero:` in English, since that key + # is used for "numbers ending in zero" in other languages. + def test_en_for_zero_key + en = YAML.load_file(Rails.root.join("config/locales/en.yml")) + assert_nothing_raised do + check_keys_for_zero(en) + end + end + private def translation_keys(scope = nil) @@ -101,7 +113,7 @@ class I18nTest < ActiveSupport::TestCase if v.is_a? Hash check_values_for_raw_html(v) else - next unless k.end_with?("_html") + next unless k.to_s.end_with?("_html") raise "Avoid using raw html in '#{k}: #{v}'" if v.include? "<" end end @@ -116,4 +128,14 @@ class I18nTest < ActiveSupport::TestCase end end end + + def check_keys_for_zero(hash) + hash.each_pair do |k, v| + if v.is_a? Hash + check_keys_for_zero(v) + else + raise "Avoid using 'zero' key in '#{k}: #{v}'" if k.to_s == "zero" + end + end + end end