X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/314b734aa59ac762de09daacd08bbb952c94783d..9448eab143cd052e9ee48cabdf13a8525add1b2c:/app/controllers/application_controller.rb diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index acadfcc25..0c4117047 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -192,6 +192,8 @@ class ApplicationController < ActionController::Base report_error message, :bad_request rescue OSM::APIError => ex report_error ex.message, ex.status + rescue ActionController::UnknownAction => ex + raise rescue Exception => ex logger.info("API threw unexpected #{ex.class} exception: #{ex.message}") ex.backtrace.each { |l| logger.info(l) } @@ -208,9 +210,11 @@ class ApplicationController < ActionController::Base end def api_call_timeout - Timeout::timeout(APP_CONFIG['api_timeout'], OSM::APITimeoutError) do + SystemTimer.timeout_after(APP_CONFIG['api_timeout']) do yield end + rescue Timeout::Error + raise OSM::APITimeoutError end ## @@ -226,6 +230,8 @@ class ApplicationController < ActionController::Base case when user.nil? then user = :none when user.display_name == controller.params[:display_name] then user = :self + when user.administrator? then user = :administrator + when user.moderator? then user = :moderator else user = :other end @@ -240,10 +246,16 @@ class ApplicationController < ActionController::Base ## # extend expire_action to expire all variants def expire_action(options = {}) - path = fragment_cache_key(options).gsub('?', '.').gsub(':', '.') + path = ActionCachePath.path_for(self, options, false).gsub('?', '.').gsub(':', '.') expire_fragment(Regexp.new(Regexp.escape(path) + "\\..*")) end + ## + # is the requestor logged in? + def logged_in? + !@user.nil? + end + private # extract authorisation credentials from headers, returns user = nil if none