X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/332bcb6b181109d56fc8b30ae78ade3961849a83..2c5ffbaaaf5f61f8c8162f32ec0fc5a0ac0e7a21:/app/controllers/api_controller.rb?ds=sidebyside diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb index fd9ce22ed..be00b9f9c 100644 --- a/app/controllers/api_controller.rb +++ b/app/controllers/api_controller.rb @@ -73,7 +73,7 @@ class ApiController < ApplicationController min_lon = min_lon * 1000000 max_lon = max_lon * 1000000 # get all the points - points = Tracepoint.find(:all, :conditions => ['gps_points.latitude > ? AND gps_points.longitude > ? AND gps_points.latitude < ? AND gps_points.longitude < ? AND ( public = 1 OR gpx_files.user_id = ? ) AND visible = 1', min_lat.to_i, min_lon.to_i, max_lat.to_i, max_lon.to_i, @user.id ], :select => "gps_points.*", :joins => "INNER JOIN gpx_files ON gpx_files.id = gpx_id", :offset => offset, :limit => TRACEPOINTS_PER_PAGE, :order => "timestamp DESC" ) + points = Tracepoint.find(:all, :conditions => ['latitude BETWEEN ? AND ? AND longitude BETWEEN ? AND ?', min_lat.to_i, max_lat.to_i, min_lon.to_i, max_lon.to_i], :select => "DISTINCT *", :offset => offset, :limit => TRACEPOINTS_PER_PAGE, :order => "timestamp DESC" ) doc = XML::Document.new doc.encoding = 'UTF-8' @@ -155,7 +155,7 @@ class ApiController < ApplicationController end if node_ids.length == 0 - render :text => '' + render :text => "" return end @@ -186,7 +186,7 @@ class ApiController < ApplicationController if segment_ids.length > 0 way_segments = WaySegment.find_all_by_segment_id(segment_ids) way_ids = way_segments.collect {|way_segment| way_segment.id } - ways = Way.find(way_ids, :include => [:way_tags]) # NB: doesn't pick up segments, tags from db until accessed via way.way_segments etc. + ways = Way.find(way_ids) # NB: doesn't pick up segments, tags from db until accessed via way.way_segments etc. # seg_ids = way_segments.collect {|way_segment| way_segment.segment_id } @@ -195,6 +195,8 @@ class ApiController < ApplicationController list_of_way_segments = list_of_way_segs.collect { |way_seg| way_seg.segment_id } + else + list_of_way_segments = Array.new end # - [0] in case some thing links to segment 0 which doesn't exist. Shouldn't actually ever happen but it does. FIXME: file a ticket for this @@ -243,6 +245,7 @@ class ApiController < ApplicationController #exit when we have too many requests if @@count > MAX_COUNT @@count = COUNT + exit! end