X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/34e3e51456774127d43408b7ab65c24f41373f62..18d5cf1957c6f52499acee507178170a10d1786b:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0c09cb1b7..fe8947599 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,122 +1,54 @@ # This configuration was generated by `rubocop --auto-gen-config` -# on 2015-02-16 18:44:13 +0000 using RuboCop version 0.29.1. +# on 2015-04-14 09:29:11 +0100 using RuboCop version 0.30.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 13 +# Offense count: 34 Lint/AmbiguousOperator: Enabled: false -# Offense count: 110 +# Offense count: 125 Lint/AmbiguousRegexpLiteral: Enabled: false -# Offense count: 29 +# Offense count: 31 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Enabled: false -# Offense count: 4 -# Cop supports --auto-correct. -Lint/BlockAlignment: - Enabled: false - -# Offense count: 1 -# Configuration parameters: AlignWith, SupportedStyles. -Lint/DefEndAlignment: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -Lint/DeprecatedClassMethods: - Enabled: false - -# Offense count: 2 -Lint/DuplicateMethods: - Enabled: false - # Offense count: 5 -# Configuration parameters: AlignWith, SupportedStyles. -Lint/EndAlignment: - Enabled: false - -# Offense count: 8 Lint/HandleExceptions: Enabled: false -# Offense count: 1 -Lint/LiteralInCondition: - Enabled: false - # Offense count: 8 Lint/ParenthesesAsGroupedExpression: Enabled: false -# Offense count: 18 -Lint/RescueException: - Enabled: false - -# Offense count: 3 -Lint/ShadowingOuterLocalVariable: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -Lint/SpaceBeforeFirstArg: - Enabled: false - -# Offense count: 21 -# Cop supports --auto-correct. -Lint/StringConversionInInterpolation: - Enabled: false - -# Offense count: 17 -# Cop supports --auto-correct. -Lint/UnusedBlockArgument: - Enabled: false - -# Offense count: 16 -# Cop supports --auto-correct. -Lint/UnusedMethodArgument: - Enabled: false - -# Offense count: 2 -Lint/UselessAccessModifier: - Enabled: false - -# Offense count: 48 -Lint/UselessAssignment: - Enabled: false - -# Offense count: 2 -Lint/Void: - Enabled: false - -# Offense count: 546 +# Offense count: 646 Metrics/AbcSize: - Max: 194 + Max: 277 # Offense count: 12 Metrics/BlockNesting: Max: 5 -# Offense count: 60 +# Offense count: 62 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1515 + Max: 1653 # Offense count: 68 Metrics/CyclomaticComplexity: - Max: 21 + Max: 20 -# Offense count: 2076 +# Offense count: 2454 # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: - Max: 253 + Max: 694 -# Offense count: 520 +# Offense count: 601 # Configuration parameters: CountComments. Metrics/MethodLength: Max: 179 @@ -128,328 +60,46 @@ Metrics/ParameterLists: # Offense count: 70 Metrics/PerceivedComplexity: - Max: 24 - -# Offense count: 46 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/AccessModifierIndentation: - Enabled: false - -# Offense count: 5 -Style/AccessorMethodName: - Enabled: false - -# Offense count: 6 -# Cop supports --auto-correct. -Style/Alias: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -Style/AlignArray: - Enabled: false + Max: 23 -# Offense count: 6 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles. -Style/AlignHash: +# Offense count: 2 +# Configuration parameters: Include. +Rails/HasAndBelongsToMany: Enabled: false -# Offense count: 159 -# Cop supports --auto-correct. +# Offense count: 70 # Configuration parameters: EnforcedStyle, SupportedStyles. -Style/AlignParameters: +Rails/TimeZone: Enabled: false -# Offense count: 217 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/AndOr: +# Offense count: 5 +Style/AccessorMethodName: Enabled: false # Offense count: 1 Style/AsciiComments: Enabled: false -# Offense count: 87 -# Cop supports --auto-correct. -Style/Blocks: - Enabled: false - -# Offense count: 636 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/BracesAroundHashParameters: - Enabled: false - -# Offense count: 21 -# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep. -Style/CaseIndentation: - Enabled: false - -# Offense count: 3 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/ClassAndModuleChildren: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/ClassCheck: - Enabled: false - -# Offense count: 9 -Style/ClassVars: - Enabled: false - -# Offense count: 12 -# Cop supports --auto-correct. -Style/ColonMethodCall: - Enabled: false - -# Offense count: 12 -# Configuration parameters: Keywords. -Style/CommentAnnotation: - Enabled: false - -# Offense count: 25 -# Cop supports --auto-correct. -Style/CommentIndentation: - Enabled: false - -# Offense count: 9 -Style/ConstantName: - Enabled: false - -# Offense count: 17 -# Cop supports --auto-correct. -Style/DeprecatedHashMethods: - Enabled: false - -# Offense count: 306 +# Offense count: 307 Style/Documentation: Enabled: false -# Offense count: 14 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/DotPosition: - Enabled: false - -# Offense count: 2 -Style/EachWithObject: - Enabled: false - -# Offense count: 5 -# Cop supports --auto-correct. -Style/ElseAlignment: - Enabled: false - -# Offense count: 3 -Style/EmptyElse: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -# Configuration parameters: AllowAdjacentOneLineDefs. -Style/EmptyLineBetweenDefs: - Enabled: false - -# Offense count: 16 -# Cop supports --auto-correct. -Style/EmptyLines: - Enabled: false - -# Offense count: 15 -# Cop supports --auto-correct. -Style/EmptyLinesAroundAccessModifier: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/EmptyLinesAroundBlockBody: - Enabled: false - -# Offense count: 28 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/EmptyLinesAroundClassBody: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -Style/EmptyLinesAroundMethodBody: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/EmptyLinesAroundModuleBody: - Enabled: false - -# Offense count: 45 -# Cop supports --auto-correct. -Style/EmptyLiteral: - Enabled: false - -# Offense count: 3 -# Configuration parameters: Exclude. -Style/FileName: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/FirstParameterIndentation: - Enabled: false - -# Offense count: 3 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/For: - Enabled: false - -# Offense count: 8 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/FormatString: - Enabled: false - -# Offense count: 1 -# Configuration parameters: AllowedVariables. -Style/GlobalVars: - Enabled: false - -# Offense count: 41 +# Offense count: 39 # Configuration parameters: MinBodyLength. Style/GuardClause: Enabled: false -# Offense count: 5687 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/HashSyntax: - Enabled: false - -# Offense count: 42 -# Configuration parameters: MaxLineLength. -Style/IfUnlessModifier: - Enabled: false - -# Offense count: 18 -# Cop supports --auto-correct. -Style/IndentArray: - Enabled: false - -# Offense count: 15 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/IndentHash: - Enabled: false - -# Offense count: 22 -# Cop supports --auto-correct. -Style/IndentationConsistency: - Enabled: false - -# Offense count: 40 -# Cop supports --auto-correct. -# Configuration parameters: Width. -Style/IndentationWidth: - Enabled: false - -# Offense count: 67 -# Cop supports --auto-correct. -Style/LeadingCommentSpace: - Enabled: false - -# Offense count: 74 +# Offense count: 60 # Cop supports --auto-correct. Style/LineEndConcatenation: Enabled: false -# Offense count: 17 -# Cop supports --auto-correct. -Style/MethodCallParentheses: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MethodDefParentheses: - Enabled: false - -# Offense count: 12 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MethodName: - Enabled: false - -# Offense count: 28 -# Cop supports --auto-correct. -Style/MultilineIfThen: - Enabled: false - -# Offense count: 34 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MultilineOperationIndentation: - Enabled: false - -# Offense count: 3 -Style/MultilineTernaryOperator: - Enabled: false - -# Offense count: 19 -# Cop supports --auto-correct. -Style/NegatedIf: - Enabled: false - -# Offense count: 1 -Style/NestedTernaryOperator: - Enabled: false - -# Offense count: 11 -# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles. -Style/Next: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: IncludeSemanticChanges. -Style/NonNilCheck: - Enabled: false - -# Offense count: 32 -# Cop supports --auto-correct. -Style/Not: - Enabled: false - -# Offense count: 53 +# Offense count: 69 # Cop supports --auto-correct. Style/NumericLiterals: MinDigits: 11 -# Offense count: 42 -Style/OneLineConditional: - Enabled: false - -# Offense count: 2 -Style/OpMethod: - Enabled: false - -# Offense count: 7 -# Cop supports --auto-correct. -# Configuration parameters: AllowSafeAssignment. -Style/ParenthesesAroundCondition: - Enabled: false - -# Offense count: 21 -# Cop supports --auto-correct. -# Configuration parameters: PreferredDelimiters. -Style/PercentLiteralDelimiters: - Enabled: false - -# Offense count: 44 +# Offense count: 41 # Cop supports --auto-correct. Style/PerlBackrefs: Enabled: false @@ -459,211 +109,23 @@ Style/PerlBackrefs: Style/PredicateName: Enabled: false -# Offense count: 8 -# Cop supports --auto-correct. -Style/Proc: - Enabled: false - -# Offense count: 95 +# Offense count: 97 # Configuration parameters: EnforcedStyle, SupportedStyles. Style/RaiseArgs: Enabled: false -# Offense count: 11 -# Cop supports --auto-correct. -Style/RedundantBegin: - Enabled: false - -# Offense count: 113 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleReturnValues. -Style/RedundantReturn: - Enabled: false - -# Offense count: 200 -# Cop supports --auto-correct. -Style/RedundantSelf: - Enabled: false - -# Offense count: 11 -Style/RegexpLiteral: - MaxSlashes: 5 - # Offense count: 2 Style/RescueModifier: Enabled: false -# Offense count: 7 -# Cop supports --auto-correct. -Style/SelfAssignment: - Enabled: false - -# Offense count: 60 -# Cop supports --auto-correct. -# Configuration parameters: AllowAsExpressionSeparator. -Style/Semicolon: - Enabled: false - -# Offense count: 156 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SignalException: - Enabled: false - -# Offense count: 4 -# Configuration parameters: Methods. -Style/SingleLineBlockParams: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -Style/SingleSpaceBeforeFirstArg: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -Style/SpaceAfterColon: - Enabled: false - -# Offense count: 409 -# Cop supports --auto-correct. -Style/SpaceAfterComma: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -Style/SpaceAfterControlKeyword: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -Style/SpaceAfterMethodName: - Enabled: false - -# Offense count: 34 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SpaceAroundEqualsInParameterDefault: - Enabled: false - -# Offense count: 493 -# Cop supports --auto-correct. -Style/SpaceAroundOperators: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SpaceBeforeBlockBraces: - Enabled: false - -# Offense count: 13 -# Cop supports --auto-correct. -Style/SpaceBeforeComma: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -Style/SpaceBeforeComment: - Enabled: false - -# Offense count: 76 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. -Style/SpaceInsideBlockBraces: - Enabled: false - -# Offense count: 133 -# Cop supports --auto-correct. -Style/SpaceInsideBrackets: - Enabled: false - -# Offense count: 778 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles. -Style/SpaceInsideHashLiteralBraces: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -Style/SpaceInsideParens: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -Style/SpaceInsideRangeLiteral: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -Style/SpecialGlobalVars: - Enabled: false - -# Offense count: 6639 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiterals: - Enabled: false - # Offense count: 8 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/StringLiteralsInInterpolation: Enabled: false -# Offense count: 1 -Style/StructInheritance: - Enabled: false - -# Offense count: 38 -# Cop supports --auto-correct. -# Configuration parameters: IgnoredMethods. -Style/SymbolProc: - Enabled: false - -# Offense count: 218 -# Cop supports --auto-correct. -Style/Tab: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles. -Style/TrailingComma: - Enabled: false - -# Offense count: 13 -# Cop supports --auto-correct. -# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist. -Style/TrivialAccessors: - Enabled: false - -# Offense count: 10 -Style/UnlessElse: - Enabled: false - # Offense count: 2 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/VariableName: - Enabled: false - -# Offense count: 27 -# Cop supports --auto-correct. -Style/WhenThen: - Enabled: false - -# Offense count: 3 # Cop supports --auto-correct. -Style/WhileUntilDo: - Enabled: false - -# Offense count: 1 -# Configuration parameters: MaxLineLength. -Style/WhileUntilModifier: +# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist. +Style/TrivialAccessors: Enabled: false - -# Offense count: 85 -# Cop supports --auto-correct. -# Configuration parameters: WordRegex. -Style/WordArray: - MinSize: 14