X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/34e3e51456774127d43408b7ab65c24f41373f62..bd79c197cc8919e566f4563aafe1f01d9cfc94bc:/test/test_helper.rb diff --git a/test/test_helper.rb b/test/test_helper.rb index 2787ed83f..747edf016 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,170 +1,159 @@ -ENV["RAILS_ENV"] = "test" -require File.expand_path('../../config/environment', __FILE__) -require 'rails/test_help' -load 'composite_primary_keys/fixtures.rb' - -class ActiveSupport::TestCase - # Load standard fixtures needed to test API methods - def self.api_fixtures - #print "setting up the api_fixtures" - fixtures :users, :user_roles, :changesets, :changeset_tags - - fixtures :current_nodes, :nodes - set_fixture_class :current_nodes => Node - set_fixture_class :nodes => OldNode +require "coveralls" +Coveralls.wear!("rails") - fixtures :current_node_tags,:node_tags - set_fixture_class :current_node_tags => NodeTag - set_fixture_class :node_tags => OldNodeTag - - fixtures :current_ways - set_fixture_class :current_ways => Way - - fixtures :current_way_nodes, :current_way_tags - set_fixture_class :current_way_nodes => WayNode - set_fixture_class :current_way_tags => WayTag +ENV["RAILS_ENV"] = "test" +require_relative "../config/environment" +require "rails/test_help" +require "webmock/minitest" + +WebMock.disable_net_connect!(:allow_localhost => true) + +module ActiveSupport + class TestCase + include FactoryBot::Syntax::Methods + include ActiveJob::TestHelper + + ## + # takes a block which is executed in the context of a different + # ActionController instance. this is used so that code can call methods + # on the node controller whilst testing the old_node controller. + def with_controller(new_controller) + controller_save = @controller + begin + @controller = new_controller + yield + ensure + @controller = controller_save + end + end - fixtures :ways - set_fixture_class :ways => OldWay + ## + # work round minitest insanity that causes it to tell you + # to use assert_nil to test for nil, which is fine if you're + # comparing to a nil constant but not if you're comparing + # an expression that might be nil sometimes + def assert_equal_allowing_nil(exp, act, msg = nil) + if exp.nil? + assert_nil act, msg + else + assert_equal exp, act, msg + end + end - fixtures :way_nodes, :way_tags - set_fixture_class :way_nodes => OldWayNode - set_fixture_class :way_tags => OldWayTag + ## + # for some reason assert_equal a, b fails when the relations are + # actually equal, so this method manually checks the fields... + def assert_relations_are_equal(a, b) + assert_not_nil a, "first relation is not allowed to be nil" + assert_not_nil b, "second relation #{a.id} is not allowed to be nil" + assert_equal a.id, b.id, "relation IDs" + assert_equal a.changeset_id, b.changeset_id, "changeset ID on relation #{a.id}" + assert_equal a.visible, b.visible, "visible on relation #{a.id}, #{a.visible.inspect} != #{b.visible.inspect}" + assert_equal a.version, b.version, "version on relation #{a.id}" + assert_equal a.tags, b.tags, "tags on relation #{a.id}" + assert_equal a.members, b.members, "member references on relation #{a.id}" + end - fixtures :current_relations - set_fixture_class :current_relations => Relation + ## + # for some reason assert_equal a, b fails when the ways are actually + # equal, so this method manually checks the fields... + def assert_ways_are_equal(a, b) + assert_not_nil a, "first way is not allowed to be nil" + assert_not_nil b, "second way #{a.id} is not allowed to be nil" + assert_equal a.id, b.id, "way IDs" + assert_equal a.changeset_id, b.changeset_id, "changeset ID on way #{a.id}" + assert_equal a.visible, b.visible, "visible on way #{a.id}, #{a.visible.inspect} != #{b.visible.inspect}" + assert_equal a.version, b.version, "version on way #{a.id}" + assert_equal a.tags, b.tags, "tags on way #{a.id}" + assert_equal a.nds, b.nds, "node references on way #{a.id}" + end - fixtures :current_relation_members, :current_relation_tags - set_fixture_class :current_relation_members => RelationMember - set_fixture_class :current_relation_tags => RelationTag + ## + # for some reason a==b is false, but there doesn't seem to be any + # difference between the nodes, so i'm checking all the attributes + # manually and blaming it on ActiveRecord + def assert_nodes_are_equal(a, b) + assert_equal a.id, b.id, "node IDs" + assert_equal a.latitude, b.latitude, "latitude on node #{a.id}" + assert_equal a.longitude, b.longitude, "longitude on node #{a.id}" + assert_equal a.changeset_id, b.changeset_id, "changeset ID on node #{a.id}" + assert_equal a.visible, b.visible, "visible on node #{a.id}" + assert_equal a.version, b.version, "version on node #{a.id}" + assert_equal a.tags, b.tags, "tags on node #{a.id}" + end - fixtures :relations - set_fixture_class :relations => OldRelation + ## + # set request headers for HTTP basic authentication + def basic_authorization(user, pass) + @request.env["HTTP_AUTHORIZATION"] = format("Basic %{auth}", :auth => Base64.encode64("#{user}:#{pass}")) + end - fixtures :relation_members, :relation_tags - set_fixture_class :relation_members => OldRelationMember - set_fixture_class :relation_tags => OldRelationTag + ## + # set request readers to ask for a particular error format + def error_format(format) + @request.env["HTTP_X_ERROR_FORMAT"] = format + end - fixtures :gpx_files, :gps_points, :gpx_file_tags - set_fixture_class :gpx_files => Trace - set_fixture_class :gps_points => Tracepoint - set_fixture_class :gpx_file_tags => Tracetag + ## + # Used to check that the error header and the forbidden responses are given + # when the owner of the changset has their data not marked as public + def assert_require_public_data(msg = "Shouldn't be able to use API when the user's data is not public") + assert_response :forbidden, msg + assert_equal @response.headers["Error"], "You must make your edits public to upload new data", "Wrong error message" + end - fixtures :client_applications + ## + # Not sure this is the best response we could give + def assert_inactive_user(msg = "an inactive user shouldn't be able to access the API") + assert_response :unauthorized, msg + # assert_equal @response.headers['Error'], "" + end - fixtures :redactions + ## + # Check for missing translations in an HTML response + def assert_no_missing_translations(msg = "") + assert_select "span[class=translation_missing]", false, "Missing translation #{msg}" + end - fixtures :notes, :note_comments - end + ## + # execute a block with a given set of HTTP responses stubbed + def with_http_stubs(stubs_file) + stubs = YAML.load_file(File.expand_path("../http/#{stubs_file}.yml", __FILE__)) + stubs.each do |url, response| + stub_request(:get, Regexp.new(Regexp.quote(url))).to_return(:status => response["code"], :body => response["body"]) + end - ## - # takes a block which is executed in the context of a different - # ActionController instance. this is used so that code can call methods - # on the node controller whilst testing the old_node controller. - def with_controller(new_controller) - controller_save = @controller - begin - @controller = new_controller yield - ensure - @controller = controller_save end - end - - ## - # for some reason assert_equal a, b fails when the ways are actually - # equal, so this method manually checks the fields... - def assert_ways_are_equal(a, b) - assert_not_nil a, "first way is not allowed to be nil" - assert_not_nil b, "second way #{a.id} is not allowed to be nil" - assert_equal a.id, b.id, "way IDs" - assert_equal a.changeset_id, b.changeset_id, "changeset ID on way #{a.id}" - assert_equal a.visible, b.visible, "visible on way #{a.id}, #{a.visible.inspect} != #{b.visible.inspect}" - assert_equal a.version, b.version, "version on way #{a.id}" - assert_equal a.tags, b.tags, "tags on way #{a.id}" - assert_equal a.nds, b.nds, "node references on way #{a.id}" - end - - ## - # for some reason a==b is false, but there doesn't seem to be any - # difference between the nodes, so i'm checking all the attributes - # manually and blaming it on ActiveRecord - def assert_nodes_are_equal(a, b) - assert_equal a.id, b.id, "node IDs" - assert_equal a.latitude, b.latitude, "latitude on node #{a.id}" - assert_equal a.longitude, b.longitude, "longitude on node #{a.id}" - assert_equal a.changeset_id, b.changeset_id, "changeset ID on node #{a.id}" - assert_equal a.visible, b.visible, "visible on node #{a.id}" - assert_equal a.version, b.version, "version on node #{a.id}" - assert_equal a.tags, b.tags, "tags on node #{a.id}" - end - - def basic_authorization(user, pass) - @request.env["HTTP_AUTHORIZATION"] = "Basic %s" % Base64.encode64("#{user}:#{pass}") - end - - def error_format(format) - @request.env["HTTP_X_ERROR_FORMAT"] = format - end - - def content(c) - @request.env["RAW_POST_DATA"] = c.to_s - end - - # Used to check that the error header and the forbidden responses are given - # when the owner of the changset has their data not marked as public - def assert_require_public_data(msg = "Shouldn't be able to use API when the user's data is not public") - assert_response :forbidden, msg - assert_equal @response.headers['Error'], "You must make your edits public to upload new data", "Wrong error message" - end - # Not sure this is the best response we could give - def assert_inactive_user(msg = "an inactive user shouldn't be able to access the API") - assert_response :unauthorized, msg - #assert_equal @response.headers['Error'], "" - end - - def assert_no_missing_translations(msg="") - assert_select "span[class=translation_missing]", false, "Missing translation #{msg}" - end + def stub_gravatar_request(email, status = 200, body = nil) + hash = ::Digest::MD5.hexdigest(email.downcase) + url = "https://www.gravatar.com/avatar/#{hash}?d=404" + stub_request(:get, url).and_return(:status => status, :body => body) + end - # Set things up for OpenID testing - def openid_setup - begin - # Test if the ROTS (Ruby OpenID Test Server) is already running - rots_response = Net::HTTP.get_response(URI.parse("http://localhost:1123/")) - rescue - # It isn't, so start a new instance. - rots = IO.popen("#{Rails.root}/vendor/gems/rots-0.2.1/bin/rots --silent") - - # Wait for up to 30 seconds for the server to start and respond before continuing - for i in (1 .. 30) - begin - sleep 1 - rots_response = Net::HTTP.get_response(URI.parse("http://localhost:1123/")) - # If the rescue block doesn't fire, ROTS is up and running and we can continue - break - rescue - # If the connection failed, do nothing and repeat the loop - end - end + def stub_hostip_requests + # Controller tests and integration tests use different IPs + stub_request(:get, "https://api.hostip.info/country.php?ip=0.0.0.0") + stub_request(:get, "https://api.hostip.info/country.php?ip=127.0.0.1") + end - # Arrange to kill the process when we exit - note that we need - # to kill it really har due to a bug in ROTS - Kernel.at_exit do - Process.kill("KILL", rots.pid) + def email_text_parts(message) + message.parts.each_with_object([]) do |part, text_parts| + if part.content_type.start_with?("text/") + text_parts.push(part) + elsif part.multipart? + text_parts.concat(email_text_parts(part)) + end end end - end - - def openid_request(openid_request_uri) - openid_response = Net::HTTP.get_response(URI.parse(openid_request_uri)) - openid_response_uri = URI(openid_response['Location']) - openid_response_qs = Rack::Utils.parse_query(openid_response_uri.query) - return openid_response_qs + def sign_in_as(user) + stub_hostip_requests + visit login_path + fill_in "username", :with => user.email + fill_in "password", :with => "test" + click_on "Login", :match => :first + end end - - - # Add more helper methods to be used by all tests here... end