X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/43988beec3fd4da67b2cacad771ca339ef60a8ab..c22958faed2e60b7277607fdee6f94976b9caf39:/test/functional/way_controller_test.rb diff --git a/test/functional/way_controller_test.rb b/test/functional/way_controller_test.rb index cf123972a..6b58137ae 100644 --- a/test/functional/way_controller_test.rb +++ b/test/functional/way_controller_test.rb @@ -41,11 +41,10 @@ class WayControllerTest < ActionController::TestCase assert_select "osm way[id=#{way.id}][version=#{way.version}][visible=#{way.visible}]", 1 # check that each node in the way appears once in the output as a - # reference and as the node element. note the slightly dodgy assumption - # that nodes appear only once. this is currently the case with the - # fixtures, but it doesn't have to be. + # reference and as the node element. way.nodes.each do |n| - assert_select "osm way nd[ref=#{n.id}]", 1 + count = (way.nodes - (way.nodes - [n])).length + assert_select "osm way nd[ref=#{n.id}]", count assert_select "osm node[id=#{n.id}][version=#{n.version}][lat=#{n.lat}][lon=#{n.lon}]", 1 end end @@ -349,7 +348,7 @@ class WayControllerTest < ActionController::TestCase put :update, :id => current_ways(:visible_way).id assert_response :bad_request, "adding a duplicate tag to a way should fail with 'bad request'" - assert_equal "Element way/#{current_ways(:visible_way).id} has duplicate tags with key #{current_way_tags(:t1).k}.", @response.body + assert_equal "Element way/#{current_ways(:visible_way).id} has duplicate tags with key #{current_way_tags(:t1).k}", @response.body end ## @@ -396,7 +395,7 @@ class WayControllerTest < ActionController::TestCase put :update, :id => current_ways(:visible_way).id assert_response :bad_request, "adding new duplicate tags to a way should fail with 'bad request'" - assert_equal "Element way/#{current_ways(:visible_way).id} has duplicate tags with key i_am_a_duplicate.", @response.body + assert_equal "Element way/#{current_ways(:visible_way).id} has duplicate tags with key i_am_a_duplicate", @response.body end @@ -436,7 +435,7 @@ class WayControllerTest < ActionController::TestCase put :create assert_response :bad_request, "adding new duplicate tags to a way should fail with 'bad request'" - assert_equal "Element way/ has duplicate tags with key addr:housenumber.", @response.body + assert_equal "Element way/ has duplicate tags with key addr:housenumber", @response.body end ##