X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/4424cd5b947432848fe7f5bc7518fd1b718ecf6c..d1aa084d2804137d2c1d4bf04f7fd5fe319d6772:/app/models/old_node.rb diff --git a/app/models/old_node.rb b/app/models/old_node.rb index 2f960d886..c2ec43c9c 100644 --- a/app/models/old_node.rb +++ b/app/models/old_node.rb @@ -1,21 +1,26 @@ -class OldNode < GeoRecord - set_table_name 'nodes' - - validates_presence_of :user_id, :timestamp +class OldNode < ActiveRecord::Base + include GeoRecord + include ConsistencyValidations + + self.table_name = "nodes" + self.primary_keys = "node_id", "version" + + # note this needs to be included after the table name changes, or + # the queries generated by Redactable will use the wrong table name. + include Redactable + + validates_presence_of :changeset_id, :timestamp validates_inclusion_of :visible, :in => [ true, false ] validates_numericality_of :latitude, :longitude validate :validate_position + validates_associated :changeset - belongs_to :user - - def validate_position - errors.add_to_base("Node is not in the world") unless in_world? - end + belongs_to :changeset + belongs_to :redaction + belongs_to :current_node, :class_name => "Node", :foreign_key => "node_id" - def in_world? - return false if self.lat < -90 or self.lat > 90 - return false if self.lon < -180 or self.lon > 180 - return true + def validate_position + errors.add(:base, "Node is not in the world") unless in_world? end def self.from_node(node) @@ -25,18 +30,21 @@ class OldNode < GeoRecord old_node.visible = node.visible old_node.tags = node.tags old_node.timestamp = node.timestamp - old_node.user_id = node.user_id - old_node.id = node.id + old_node.changeset_id = node.changeset_id + old_node.node_id = node.id old_node.version = node.version return old_node end + + def to_xml + doc = OSM::API.new.get_xml_doc + doc.root << to_xml_node() + return doc + end def to_xml_node el1 = XML::Node.new 'node' - el1['id'] = self.id.to_s - el1['lat'] = self.lat.to_s - el1['lon'] = self.lon.to_s - el1['user'] = self.user.display_name if self.user.data_public? + el1['id'] = self.node_id.to_s self.tags.each do |k,v| el2 = XML::Node.new('tag') @@ -45,8 +53,23 @@ class OldNode < GeoRecord el1 << el2 end + if self.visible? + el1['lat'] = self.lat.to_s + el1['lon'] = self.lon.to_s + end + + el1['changeset'] = self.changeset.id.to_s + if self.changeset.user.data_public? + el1['user'] = self.changeset.user.display_name + el1['uid'] = self.changeset.user.id.to_s + end + el1['visible'] = self.visible.to_s el1['timestamp'] = self.timestamp.xmlschema + el1['version'] = self.version.to_s + + el1['redacted'] = self.redaction.id.to_s if self.redacted? + return el1 end @@ -56,13 +79,13 @@ class OldNode < GeoRecord clear_aggregation_cache clear_association_cache #ok from here - @attributes.update(OldNode.find(:first, :conditions => ['id = ? AND timestamp = ?', self.id, self.timestamp]).instance_variable_get('@attributes')) + @attributes.update(OldNode.where(:node_id => self.node_id, :timestamp => self.timestamp, :version => self.version).first.instance_variable_get('@attributes')) self.tags.each do |k,v| tag = OldNodeTag.new tag.k = k tag.v = v - tag.id = self.id + tag.node_id = self.node_id tag.version = self.version tag.save! end @@ -70,10 +93,10 @@ class OldNode < GeoRecord def tags unless @tags - @tags = Hash.new - OldNodeTag.find(:all, :conditions => ["id = ? AND version = ?", self.id, self.version]).each do |tag| - @tags[tag.k] = tag.v - end + @tags = Hash.new + OldNodeTag.where(:node_id => self.node_id, :version => self.version).each do |tag| + @tags[tag.k] = tag.v + end end @tags = Hash.new unless @tags @tags @@ -81,6 +104,25 @@ class OldNode < GeoRecord def tags=(t) @tags = t + end + + def tags_as_hash + return self.tags + end + + # Pretend we're not in any ways + def ways + return [] + end + + # Pretend we're not in any relations + def containing_relation_members + return [] end + # check whether this element is the latest version - that is, + # has the same version as its "current" counterpart. + def is_latest_version? + current_node.version == self.version + end end