X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/4b3c207a818b936310f48b768488a6a39845fe81..3a386f185c954d71a9b5d0747d017f99c8ccb6ff:/app/controllers/user_preference_controller.rb

diff --git a/app/controllers/user_preference_controller.rb b/app/controllers/user_preference_controller.rb
index a4de5c099..16165513a 100644
--- a/app/controllers/user_preference_controller.rb
+++ b/app/controllers/user_preference_controller.rb
@@ -1,95 +1,87 @@
 # Update and read user preferences, which are arbitrayr key/val pairs
 class UserPreferenceController < ApplicationController
-  before_filter :authorize
-
-  def read_one
-    pref = UserPreference.find(:first, :conditions => ['user_id = ? AND k = ?', @user.id, params[:preference_key]])
-
-    if pref
-      render :text => pref.v.to_s
-    else
-      render :text => 'OH NOES! PREF NOT FOUND!', :status => 404
-    end
-  end
-
-  def update_one
-    pref = UserPreference.find(:first, :conditions => ['user_id = ? AND k = ?', @user.id, params[:preference_key]])
-  
-    if pref
-      pref.v = request.raw_post.chomp
-      pref.save
-    else
-      pref = UserPreference.new
-      pref.user = @user
-      pref.k = params[:preference_key]
-      pref.v = request.raw_post.chomp
-      pref.save
-    end
-  end
-
-
-  # print out all the preferences as a big xml block
+  skip_before_action :verify_authenticity_token
+  before_action :authorize
+  before_action :require_allow_read_prefs, :only => [:read_one, :read]
+  before_action :require_allow_write_prefs, :except => [:read_one, :read]
+  around_action :api_call_handle_error
+
+  ##
+  # return all the preferences as an XML document
   def read
     doc = OSM::API.new.get_xml_doc
 
-    prefs = @user.preferences
+    prefs = current_user.preferences
 
-    el1 = XML::Node.new 'preferences'
+    el1 = XML::Node.new "preferences"
 
     prefs.each do |pref|
-      el1 <<  pref.to_xml_node
+      el1 << pref.to_xml_node
     end
 
     doc.root << el1
-    render :text => doc.to_s, :content_type => "text/xml"
+    render :xml => doc.to_s
   end
 
-  # update the entire set of preferences
-  def update
-    begin
-      p = XML::Parser.new
-      p.string = request.raw_post
-      doc = p.parse
-
-      prefs = []
+  ##
+  # return the value for a single preference
+  def read_one
+    pref = UserPreference.find([current_user.id, params[:preference_key]])
 
-      keyhash = {}
+    render :plain => pref.v.to_s
+  end
 
-      doc.find('//preferences/preference').each do |pt|
-        pref = UserPreference.new
+  # update the entire set of preferences
+  def update
+    old_preferences = current_user.preferences.each_with_object({}) do |preference, preferences|
+      preferences[preference.k] = preference
+    end
 
-        unless keyhash[pt['k']].nil? # already have that key
-          render :text => 'OH NOES! CAN HAS UNIQUE KEYS?', :status => :not_acceptable
-          return
-        end
+    new_preferences = {}
 
-        keyhash[pt['k']] = 1
+    doc = XML::Parser.string(request.raw_post, :options => XML::Parser::Options::NOERROR).parse
 
-        pref.k = pt['k']
-        pref.v = pt['v']
-        pref.user_id = @user.id
-        prefs << pref
+    doc.find("//preferences/preference").each do |pt|
+      if preference = old_preferences.delete(pt["k"])
+        preference.v = pt["v"]
+      elsif new_preferences.include?(pt["k"])
+        raise OSM::APIDuplicatePreferenceError, pt["k"]
+      else
+        preference = current_user.preferences.build(:k => pt["k"], :v => pt["v"])
       end
 
-      if prefs.size > 150
-        render :text => 'Too many preferences', :status => :request_entity_too_large
-        return
-      end
+      new_preferences[preference.k] = preference
+    end
 
-      # kill the existing ones
-      UserPreference.delete_all(['user_id = ?', @user.id])
+    old_preferences.each_value(&:delete)
 
-      # save the new ones
-      prefs.each do |pref|
-        pref.save!
-      end
+    new_preferences.each_value(&:save!)
 
-    rescue Exception => ex
-      render :text => 'OH NOES! FAIL!: ' + ex.to_s, :status => :internal_server_error
-      return
+    render :plain => ""
+  end
+
+  ##
+  # update the value of a single preference
+  def update_one
+    begin
+      pref = UserPreference.find([current_user.id, params[:preference_key]])
+    rescue ActiveRecord::RecordNotFound
+      pref = UserPreference.new
+      pref.user = current_user
+      pref.k = params[:preference_key]
     end
 
-    render :nothing => true
+    pref.v = request.raw_post.chomp
+    pref.save!
+
+    render :plain => ""
   end
 
+  ##
+  # delete a single preference
+  def delete_one
+    UserPreference.find([current_user.id, params[:preference_key]]).delete
+
+    render :plain => ""
+  end
 end