X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/4c7279ba1f55d059ecba3be9f059ee073d09e9e4..4543e85441b758edaf7b4a8f7ed589ca428a9be7:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index fbae24baa..35107e9b9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -14,12 +14,13 @@ Lint/AssignmentInCondition: - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' - 'app/controllers/traces_controller.rb' - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/controllers/user_preferences_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_helper.rb' + - 'app/helpers/browse_tags_helper.rb' - 'app/models/client_application.rb' - - 'app/models/notifier.rb' + - 'app/mailers/notifier.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' @@ -28,17 +29,17 @@ Lint/AssignmentInCondition: Lint/HandleExceptions: Exclude: - 'app/controllers/amf_controller.rb' - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' # Offense count: 692 Metrics/AbcSize: - Max: 280 + Max: 283 # Offense count: 40 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: - Max: 259 + Max: 262 # Offense count: 11 # Configuration parameters: CountBlocks. @@ -48,11 +49,11 @@ Metrics/BlockNesting: # Offense count: 63 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1795 + Max: 1627 # Offense count: 72 Metrics/CyclomaticComplexity: - Max: 20 + Max: 23 # Offense count: 691 # Configuration parameters: CountComments. @@ -139,9 +140,9 @@ Rails/NotNullColumn: # Offense count: 20 Rails/OutputSafety: Exclude: - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changeset_helper.rb' + - 'app/helpers/changesets_helper.rb' - 'app/helpers/geocoder_helper.rb' - 'app/helpers/note_helper.rb' - 'app/helpers/open_graph_helper.rb' @@ -177,7 +178,7 @@ Style/FrozenStringLiteralComment: # Cop supports --auto-correct. Style/IfUnlessModifier: Exclude: - - 'app/controllers/way_controller.rb' + - 'app/controllers/ways_controller.rb' # Offense count: 70 # Cop supports --auto-correct. @@ -185,49 +186,6 @@ Style/IfUnlessModifier: Style/NumericLiterals: MinDigits: 11 -# Offense count: 21 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, EnforcedStyle. -# SupportedStyles: predicate, comparison -Style/NumericPredicate: - Exclude: - - 'spec/**/*' - - 'app/controllers/amf_controller.rb' - - 'app/controllers/changeset_controller.rb' - - 'app/controllers/notes_controller.rb' - - 'app/helpers/banner_helper.rb' - - 'app/helpers/issues_helper.rb' - - 'app/models/relation.rb' - - 'app/models/trace.rb' - - 'app/models/way.rb' - - 'db/migrate/021_move_to_innodb.rb' - - 'lib/classic_pagination/pagination.rb' - - 'lib/daemons/gpx_import.rb' - - 'lib/gpx.rb' - - 'test/controllers/amf_controller_test.rb' - -# Offense count: 30 -# Cop supports --auto-correct. -# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist. -# Whitelist: present?, blank?, presence, try, try! -Style/SafeNavigation: - Exclude: - - 'app/controllers/amf_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/browse_controller.rb' - - 'app/controllers/issues_controller.rb' - - 'app/controllers/notes_controller.rb' - - 'app/controllers/old_controller.rb' - - 'app/controllers/traces_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/helpers/user_roles_helper.rb' - - 'app/models/changeset.rb' - - 'app/models/client_application.rb' - - 'app/models/notifier.rb' - - 'app/models/relation.rb' - - 'app/models/way.rb' - - 'script/deliver-message' - # Offense count: 3080 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https