X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/4c7279ba1f55d059ecba3be9f059ee073d09e9e4..5c933868dbff434a0810b44ee945f3c0f109dd53:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index fbae24baa..06a9c76f0 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,68 +1,84 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2018-09-19 14:24:02 +0100 using RuboCop version 0.58.2. +# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 32 +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-performance + - rubocop-rails + +# Offense count: 3338 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 260 + +# Offense count: 35 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' - 'app/controllers/traces_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/controllers/user_preferences_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/browse_helper.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/mailers/notifier.rb' - 'app/models/client_application.rb' - - 'app/models/notifier.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' # Offense count: 4 -Lint/HandleExceptions: +# Configuration parameters: AllowComments. +Lint/SuppressedException: Exclude: - - 'app/controllers/amf_controller.rb' - - 'app/controllers/user_controller.rb' + - 'app/controllers/api/amf_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/controllers/site_controller.rb' -# Offense count: 692 +# Offense count: 701 Metrics/AbcSize: - Max: 280 + Max: 189 -# Offense count: 40 +# Offense count: 39 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: - Max: 259 + Max: 71 -# Offense count: 11 +# Offense count: 15 # Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 63 +# Offense count: 25 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1795 + Max: 645 -# Offense count: 72 +# Offense count: 74 Metrics/CyclomaticComplexity: - Max: 20 + Max: 22 -# Offense count: 691 -# Configuration parameters: CountComments. +# Offense count: 722 +# Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: Max: 179 # Offense count: 2 # Configuration parameters: CountComments. Metrics/ModuleLength: - Max: 135 + Max: 117 # Offense count: 4 # Configuration parameters: CountKeywordArgs. @@ -71,7 +87,7 @@ Metrics/ParameterLists: # Offense count: 72 Metrics/PerceivedComplexity: - Max: 23 + Max: 25 # Offense count: 6 Naming/AccessorMethodName: @@ -98,6 +114,14 @@ Naming/PredicateName: - 'app/models/user.rb' - 'lib/classic_pagination/pagination.rb' +# Offense count: 5 +# Cop supports --auto-correct. +Performance/RegexpMatch: + Exclude: + - 'app/helpers/browse_tags_helper.rb' + - 'app/validators/characters_validator.rb' + - 'app/validators/whitespace_validator.rb' + # Offense count: 6 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql @@ -109,14 +133,6 @@ Rails/BulkChangeTable: - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 2 -# Configuration parameters: Include. -# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb -Rails/Exit: - Exclude: - - 'lib/**/*.rake' - - 'lib/daemons/gpx_import.rb' - # Offense count: 2 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -125,6 +141,15 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' +# Offense count: 11 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/application_helper.rb' + - 'app/helpers/title_helper.rb' + - 'app/helpers/trace_helper.rb' + # Offense count: 5 # Configuration parameters: Include. # Include: db/migrate/*.rb @@ -136,21 +161,21 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 20 +# Offense count: 18 Rails/OutputSafety: Exclude: - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changeset_helper.rb' + - 'app/helpers/changesets_helper.rb' - 'app/helpers/geocoder_helper.rb' - 'app/helpers/note_helper.rb' - 'app/helpers/open_graph_helper.rb' - 'app/helpers/user_blocks_helper.rb' - - 'app/helpers/user_roles_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 86 +# Offense count: 94 +# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: @@ -162,14 +187,23 @@ Style/AsciiComments: Exclude: - 'test/models/message_test.rb' -# Offense count: 230 -Style/Documentation: - Enabled: false - -# Offense count: 462 +# Offense count: 27 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: annotated, template, unannotated +Style/FormatStringToken: + Exclude: + - 'app/models/concerns/geo_record.rb' + - 'app/views/api/map/_bounds.xml.builder' + - 'lib/bounding_box.rb' + - 'test/controllers/api/map_controller_test.rb' + - 'test/controllers/api/relations_controller_test.rb' + - 'test/controllers/api/ways_controller_test.rb' + - 'test/lib/bounding_box_test.rb' + +# Offense count: 539 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: when_needed, always, never +# SupportedStyles: always, never Style/FrozenStringLiteralComment: Enabled: false @@ -177,59 +211,10 @@ Style/FrozenStringLiteralComment: # Cop supports --auto-correct. Style/IfUnlessModifier: Exclude: - - 'app/controllers/way_controller.rb' + - 'app/controllers/api/ways_controller.rb' # Offense count: 70 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 - -# Offense count: 21 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, EnforcedStyle. -# SupportedStyles: predicate, comparison -Style/NumericPredicate: - Exclude: - - 'spec/**/*' - - 'app/controllers/amf_controller.rb' - - 'app/controllers/changeset_controller.rb' - - 'app/controllers/notes_controller.rb' - - 'app/helpers/banner_helper.rb' - - 'app/helpers/issues_helper.rb' - - 'app/models/relation.rb' - - 'app/models/trace.rb' - - 'app/models/way.rb' - - 'db/migrate/021_move_to_innodb.rb' - - 'lib/classic_pagination/pagination.rb' - - 'lib/daemons/gpx_import.rb' - - 'lib/gpx.rb' - - 'test/controllers/amf_controller_test.rb' - -# Offense count: 30 -# Cop supports --auto-correct. -# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist. -# Whitelist: present?, blank?, presence, try, try! -Style/SafeNavigation: - Exclude: - - 'app/controllers/amf_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/controllers/browse_controller.rb' - - 'app/controllers/issues_controller.rb' - - 'app/controllers/notes_controller.rb' - - 'app/controllers/old_controller.rb' - - 'app/controllers/traces_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/helpers/user_roles_helper.rb' - - 'app/models/changeset.rb' - - 'app/models/client_application.rb' - - 'app/models/notifier.rb' - - 'app/models/relation.rb' - - 'app/models/way.rb' - - 'script/deliver-message' - -# Offense count: 3080 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 1073